Bug#1024677: protobuf: autopkgtest failure (error: file not found: com/example/tutorial/AddressBookProtos.java)

2022-11-23 Thread Sebastiaan Couwenberg

Control: tags -1 fixed-upstream

On 11/23/22 07:11, Bas Couwenberg wrote:

The attached patch fixes the issue by correcting the paths in the Makefile.


Upstream has already fixed this issue:


https://github.com/protocolbuffers/protobuf/commit/9c02fff2559f1c7cd93924af27a28a546ad4e197

--
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1



Bug#1024677: protobuf: autopkgtest failure (error: file not found: com/example/tutorial/AddressBookProtos.java)

2022-11-22 Thread Bas Couwenberg
Source: protobuf
Version: 3.21.9-3
Severity: serious
Tags: upstream patch
Control: block 1023535 by -1

Dear Maintainer,

The autopkgtest for your package is failing:

 autopkgtest [02:27:53]: test simple: [---
 *** Building example programs
 protoc $PROTO_PATH --cpp_out=. --java_out=. --python_out=. addressbook.proto
 pkg-config --cflags protobuf  # fails if protobuf is not installed
 
 c++ -std=c++11 add_person.cc addressbook.pb.cc -o add_person_cpp `pkg-config 
--cflags --libs protobuf`
 pkg-config --cflags protobuf  # fails if protobuf is not installed
 
 c++ -std=c++11 list_people.cc addressbook.pb.cc -o list_people_cpp `pkg-config 
--cflags --libs protobuf`
 javac -cp $CLASSPATH AddPerson.java ListPeople.java 
com/example/tutorial/AddressBookProtos.java
 error: file not found: com/example/tutorial/AddressBookProtos.java
 Usage: javac  
 use --help for a list of possible options
 make: *** [Makefile:66: javac_middleman] Error 2

https://ci.debian.net/data/autopkgtest/unstable/amd64/p/protobuf/28586956/log.gz

The attached patch fixes the issue by correcting the paths in the Makefile.

Kind Regards,

Bas
--- a/examples/Makefile 2022-10-26 19:50:48.0 +0200
+++ b/examples/Makefile 2022-11-23 07:07:29.963242439 +0100
@@ -13,8 +13,8 @@
 
 clean:
rm -f add_person_cpp list_people_cpp add_person_java list_people_java 
add_person_python list_people_python
-   rm -f javac_middleman AddPerson*.class ListPeople*.class 
com/example/tutorial/*.class
-   rm -f protoc_middleman addressbook.pb.cc addressbook.pb.h 
addressbook_pb2.py com/example/tutorial/AddressBookProtos.java
+   rm -f javac_middleman AddPerson*.class ListPeople*.class 
com/example/tutorial/protos/*.class
+   rm -f protoc_middleman addressbook.pb.cc addressbook.pb.h 
addressbook_pb2.py com/example/tutorial/protos/*.java
rm -f *.pyc
rm -f go/tutorialpb/*.pb.go add_person_go list_people_go
rm -f protoc_middleman_dart dart_tutorial/*.pb*.dart
@@ -63,7 +63,7 @@
cd go && go test ./cmd/list_people
 
 javac_middleman: AddPerson.java ListPeople.java protoc_middleman
-   javac -cp $$CLASSPATH AddPerson.java ListPeople.java 
com/example/tutorial/AddressBookProtos.java
+   javac -cp $$CLASSPATH AddPerson.java ListPeople.java 
com/example/tutorial/protos/*.java
@touch javac_middleman
 
 add_person_java: javac_middleman