Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Santiago Vila

El 2/1/23 a las 13:00, Bernhard Schmidt escribió:

I somehow have my doubt that the release-team would be happy to have a lot of 
stable updates fixing just a FTBFS that does not happen with the default buildd 
configuration. I totally agree about the severity of other FTBFS bugs in stable.


Please note that this was already serious in bullseye, as release policy has 
not changed between bullseye and bookworm regarding this.

https://release.debian.org/bullseye/rc_policy.txt

   Packages must list any packages they require to build beyond those
   that are "build-essential" in the appropriate Build-Depends: fields.
   Ref: 4.2

Thanks.



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Bernhard Schmidt

Control: tags -1 + pending
Control: tags -1 - moreinfo

Hi,

I have no problem fixing this up in unstable, but I think this does 
not warrant a stable update.


That would be unfortunate, as it means we will probably never have a 
stable release without FTBFS bugs.


"Never" is too hard, I will fix it in unstable targetting bookworm, so 
the next release should have it.


Since backporting those kind of bugs is completely trivial, I'm still 
aiming at having a stable distribution which is free from FTBFS bugs (of 
any kind). You are of course free not to help me in my goal, but it would
help immensely if every maintainer ensured that their own packages are 
free from FTBFS bugs in stable.


I somehow have my doubt that the release-team would be happy to have a 
lot of stable updates fixing just a FTBFS that does not happen with the 
default buildd configuration. I totally agree about the severity of 
other FTBFS bugs in stable.


Bernhard



Processed: Re: Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Debian Bug Tracking System
Processing control commands:

> tags -1 + pending
Bug #1027379 [src:nfdump] nfdump: FTBFS in bullseye (missing build-depends on 
tzdata)
Added tag(s) pending.
> tags -1 - moreinfo
Bug #1027379 [src:nfdump] nfdump: FTBFS in bullseye (missing build-depends on 
tzdata)
Removed tag(s) moreinfo.

-- 
1027379: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027379
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Santiago Vila

El 2/1/23 a las 12:04, Bernhard Schmidt escribió:

BTW, it is reproducible using "sbuild --add-conflicts=tzdata"


Yes (just tried).

Thanks.



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Santiago Vila

El 2/1/23 a las 12:04, Bernhard Schmidt escribió:

Both the official buildds and schroots created using the documented 
sbuild-createchroot then apparently do not follow recommended procedure?


Yes, exactly. There is a bug in debootstrap asking for such 
required-but-not-build-essential packages
not to be installed by default.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837060

Apparently, they have not agreed about the way to fix this. Some people suggest 
that debootstrap
explicitly should not install those packages. Others suggest that debootstrap 
keeps installing
all required packages not matter what, and instead we downgrade those packages 
to important.

In the meantime, it's 2023 and I still have to explain that priority required 
does not imply
build-essential. Believe me that this is also odd for me.


I have no problem fixing this up in unstable, but I think this does not warrant 
a stable update.


That would be unfortunate, as it means we will probably never have a stable 
release without FTBFS bugs.

I have rebuilt the entire bullseye archive from scratch, and I'm reporting 
every FTBFS bug I find,
because "packages in stable must build in stable". This is not only Policy but 
also Release Policy,
i.e. something that our users should take for granted because we promised it as 
a release goal.

The bugs I find are very diverse and in most cases they have been already 
reported in unstable and forgotten.
There are also bugs which happen in bookworm but had not been reported yet, 
like this one.
Since backporting those kind of bugs is completely trivial, I'm still aiming at 
having a stable distribution which is free from FTBFS bugs (of any kind). You 
are of course free not to help me in my goal, but it would
help immensely if every maintainer ensured that their own packages are free 
from FTBFS bugs in stable.

Thanks.



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Bernhard Schmidt

Hi,

That's an odd one. I cannot reproduce it in any version, because in 
all my attempts (1.6.22-2 in a bullseye sbuild, in an sid sbuild, as 
well as in the build logs of the official buildds for all of 1.6.22-2, 
1.6.25-1 and 1.7.1-1) tzdata is actually installed in the build 
environment, even without additional build-dep.


tzdata is not really build essential, you should not install it in a 
chroot used to build packages from scratch. It follows from this that if 
you want to be sure that you don't miss build-dependencies, you should 
not accept debootstrap defaults when creating a chroot, as it installs

several packages which are not build-essential.

To reproduce, try building the package in a chroot which does not 
contain tzdata.


Both the official buildds and schroots created using the documented 
sbuild-createchroot then apparently do not follow recommended procedure?


I have no problem fixing this up in unstable, but I think this does not 
warrant a stable update.


BTW, it is reproducible using "sbuild --add-conflicts=tzdata"

Bernhard



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Santiago Vila

El 2/1/23 a las 9:28, Bernhard Schmidt escribió:

Control: tags -1 + moreinfo

Hi Santiago,


During a rebuild of all packages in bullseye, your package failed to build:


[...]


Note: I'm using the "patch" tag because there is an obvious fix > (indicated in 
the subject).


That's an odd one. I cannot reproduce it in any version, because in all my 
attempts (1.6.22-2 in a bullseye sbuild, in an sid sbuild, as well as in the 
build logs of the official buildds for all of 1.6.22-2, 1.6.25-1 and 1.7.1-1) 
tzdata is actually installed in the build environment, even without additional 
build-dep.


tzdata is not really build essential, you should not install it in a chroot 
used to build packages from scratch. It follows from this that if you want to 
be sure that you don't miss build-dependencies, you should not accept 
debootstrap defaults when creating a chroot, as it installs
several packages which are not build-essential.

To reproduce, try building the package in a chroot which does not contain 
tzdata.

I can also give you ssh access to a machine where this is easily reproducible, 
as I said in the bug report, but I trust that you should be able to create a 
chroot without tzdata.

Thanks.



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Bernhard Schmidt

Control: tags -1 + moreinfo

Hi Santiago,


During a rebuild of all packages in bullseye, your package failed to build:


[...]


Note: I'm using the "patch" tag because there is an obvious fix > (indicated in 
the subject).


That's an odd one. I cannot reproduce it in any version, because in all 
my attempts (1.6.22-2 in a bullseye sbuild, in an sid sbuild, as well as 
in the build logs of the official buildds for all of 1.6.22-2, 1.6.25-1 
and 1.7.1-1) tzdata is actually installed in the build environment, even 
without additional build-dep.


Bernhard



Processed: Re: Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2023-01-02 Thread Debian Bug Tracking System
Processing control commands:

> tags -1 + moreinfo
Bug #1027379 [src:nfdump] nfdump: FTBFS in bullseye (missing build-depends on 
tzdata)
Added tag(s) moreinfo.

-- 
1027379: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027379
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#1027379: nfdump: FTBFS in bullseye (missing build-depends on tzdata)

2022-12-30 Thread Santiago Vila

Package: src:nfdump
Version: 1.6.22-2
Severity: serious
Tags: ftbfs patch

Dear maintainer:

During a rebuild of all packages in bullseye, your package failed to build:


[...]
 debian/rules binary-arch
dh binary-arch
   dh_update_autotools_config -a
   dh_autoreconf -a

[...]

--- test1.out   2022-07-15 11:53:20.623099184 +
+++ nfdump.test.out 2020-11-21 11:59:46.0 +
@@ -4,8 +4,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541800 [2004-07-11 10:30:00]
-  last =1089541810 [2004-07-11 10:30:10]
+  first=1089534600 [2004-07-11 10:30:00]
+  last =1089534610 [2004-07-11 10:30:10]
   msec_first   =10
   msec_last=20
   src addr =   172.16.1.66
@@ -59,8 +59,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541810 [2004-07-11 10:30:10]
-  last =1089541830 [2004-07-11 10:30:30]
+  first=1089534610 [2004-07-11 10:30:10]
+  last =1089534630 [2004-07-11 10:30:30]
   msec_first   =   110
   msec_last=   120
   src addr =   172.16.2.66
@@ -114,8 +114,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541820 [2004-07-11 10:30:20]
-  last =1089541850 [2004-07-11 10:30:50]
+  first=1089534620 [2004-07-11 10:30:20]
+  last =1089534650 [2004-07-11 10:30:50]
   msec_first   =   210
   msec_last=   220
   src addr =   172.16.2.66
@@ -169,8 +169,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541830 [2004-07-11 10:30:30]
-  last =1089541870 [2004-07-11 10:31:10]
+  first=1089534630 [2004-07-11 10:30:30]
+  last =1089534670 [2004-07-11 10:31:10]
   msec_first   =   310
   msec_last=   320
   src addr =   172.16.3.66
@@ -224,8 +224,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541840 [2004-07-11 10:30:40]
-  last =1089541890 [2004-07-11 10:31:30]
+  first=1089534640 [2004-07-11 10:30:40]
+  last =1089534690 [2004-07-11 10:31:30]
   msec_first   =   410
   msec_last=   420
   src addr =   172.16.4.66
@@ -279,8 +279,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541850 [2004-07-11 10:30:50]
-  last =1089541910 [2004-07-11 10:31:50]
+  first=1089534650 [2004-07-11 10:30:50]
+  last =1089534710 [2004-07-11 10:31:50]
   msec_first   =   510
   msec_last=   520
   src addr =   172.16.5.66
@@ -334,8 +334,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541860 [2004-07-11 10:31:00]
-  last =1089541930 [2004-07-11 10:32:10]
+  first=1089534660 [2004-07-11 10:31:00]
+  last =1089534730 [2004-07-11 10:32:10]
   msec_first   =   610
   msec_last=   620
   src addr =   172.16.6.66
@@ -389,8 +389,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541870 [2004-07-11 10:31:10]
-  last =1089541950 [2004-07-11 10:32:30]
+  first=1089534670 [2004-07-11 10:31:10]
+  last =1089534750 [2004-07-11 10:32:30]
   msec_first   =   710
   msec_last=   720
   src addr =   172.16.7.66
@@ -444,8 +444,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541880 [2004-07-11 10:31:20]
-  last =1089541970 [2004-07-11 10:32:50]
+  first=1089534680 [2004-07-11 10:31:20]
+  last =1089534770 [2004-07-11 10:32:50]
   msec_first   =   810
   msec_last=   820
   src addr =   172.16.8.66
@@ -499,8 +499,8 @@
   label=
   export sysid = 1
   size =   172
-  first=1089541890 [2004-07-11 10:31:30]
-  last =1089541990 [2004-07-11 10:33:10]
+  first=1089534690 [2004-07-11 10:31:30]
+  last =1089534790 [2004-07-11 10:33:10]
   msec_first   =