Bug#1042747: dahdi-dkms: dkms.conf still lists removed pciradio.ko
On 31/07/2023 13.17, Tzafrir Cohen wrote: Trying to figure out the cause for the other error https://ci.debian.net/data/autopkgtest/testing/amd64/d/dahdi-linux/36220583/log.gz 177s MODPOST /usr/src/modules/dahdi/drivers/dahdi/Module.symvers 178s ERROR: modpost: "unregister_hdlc_device" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_unregister_channel" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! That happens during module-assistant-autopkgtest on the -cloud- kernel ... Try this in d/tests/control: Test-Command: env BUILD_EXCLUSIVE_CONFIG="CONFIG_PCI CONFIG_USB" /usr/share/modass/module-assistant-autopkgtest dahdi (The missing symbols probably depend on other config settings, e.g. CONFIG_HDLC and CONFIG_PPP (not checked), but we don't check for them in the -dkms package either, so just reuse the existing constraint.) Andreas
Bug#1042747: dahdi-dkms: dkms.conf still lists removed pciradio.ko
Hi, Thanks. Those modules were removed. I noticed that and fixed it locally (also added two extra modules zaphfc and icE1usb). Trying to figure out the cause for the other error https://ci.debian.net/data/autopkgtest/testing/amd64/d/dahdi-linux/36220583/log.gz 177s MODPOST /usr/src/modules/dahdi/drivers/dahdi/Module.symvers 178s ERROR: modpost: "unregister_hdlc_device" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_unregister_channel" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_unit_number" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "alloc_hdlcdev" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_channel_index" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_register_channel" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "hdlc_close" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "hdlc_start_xmit" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_input" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s ERROR: modpost: "ppp_input_error" [/usr/src/modules/dahdi/drivers/dahdi/dahdi.ko] undefined! 178s WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many) 178s make[4]: *** [/usr/src/linux-headers-6.4.0-1-common/scripts/Makefile.modpost:136: /usr/src/modules/dahdi/drivers/dahdi/Module.symvers] Error 1 178s make[3]: *** [/usr/src/linux-headers-6.4.0-1-common/Makefile:2003: modpost] Error 2 > While updating d/dkms.conf.in, you can probably drop CONFIG_PCI from > BUILD_EXCLUSIVE_CONFIG (and update the comment) CONFIG_PCI is a pre-condition to just about any DAHDI card there except the USB devices (see drivers/dahdi/Kbuild). Will update comment. > and > switch from BUILD_EXCLUSIVE_KERNEL=...(regex)... to the more readable > BUILD_EXCLUSIVE_KERNEL_MIN="5.6" (supported since dkms in trixie). I want to make the job for backporters easy, so I'll avoid this feature for now. -- Tzafrir -- mail / xmpp / matrix: tzaf...@cohens.org.il
Bug#1042747: dahdi-dkms: dkms.conf still lists removed pciradio.ko
Package: dahdi-dkms Version: 1:3.1.0+git20230717~dfsg-1 Severity: serious Buiding the modules fails because pciradio.ko is no longer built, but still required by dkms.conf: I: Trying to build dahdi/3.1.0+git20230717 for 6.3.0-2-amd64 Sign command: /usr/lib/linux-kbuild-6.3/scripts/sign-file Signing key: /var/lib/dkms/mok.key Public certificate (MOK): /var/lib/dkms/mok.pub Creating symlink /var/lib/dkms/dahdi/3.1.0+git20230717/source -> /usr/src/dahdi-3.1.0+git20230717 Building module: Cleaning build area... (make modules KVERS=6.3.0-2-amd64 MODULES_EXTRA='dahdi_dummy dahdi_echocan_oslec'; make KVERS=6.3.0-2-amd64) Error! Build of pciradio.ko failed for: 6.3.0-2-amd64 (x86_64) Make sure the name of the generated module is correct and at the root of the build directory, or consult make.log in the build directory /var/lib/dkms/dahdi/3.1.0+git20230717/build for more information. E: dahdi/3.1.0+git20230717 failed to build for 6.3.0-2-amd64 make.log has no mention of pciradio at all and does not report any failures, thus it is not attached. While updating d/dkms.conf.in, you can probably drop CONFIG_PCI from BUILD_EXCLUSIVE_CONFIG (and update the comment) and switch from BUILD_EXCLUSIVE_KERNEL=...(regex)... to the more readable BUILD_EXCLUSIVE_KERNEL_MIN="5.6" (supported since dkms in trixie). Andreas
