Bug#1062116: google-perftools: NMU diff for 64-bit time_t transition

2024-01-31 Thread Aliaksey Kandratsenka
Hi. Upstream maintainer here. Thanks for bringing this up. To my knowledge
only cpu profiler bits expose time_t. So libtcmalloc-minimal4 is worth
keeping as is.

On Wed, Jan 31, 2024 at 7:21 AM Graham Inggs  wrote:

> Source: google-perftools
> Version: 2.15-1
> Severity: serious
> Tags: patch pending
> Justification: library ABI skew on upgrade
> User: debian-...@lists.debian.org
> Usertags: time-t
>
> Dear maintainer,
>
> As part of the 64-bit time_t transition required to support 32-bit
> architectures in 2038 and beyond
> (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
> google-perftools as a source package shipping runtime libraries whose ABI
> either is affected by the change in size of time_t, or could not be
> analyzed via abi-compliance-checker (and therefore to be on the safe
> side we assume is affected).
>
> To ensure that inconsistent combinations of libraries with their
> reverse-dependencies are never installed together, it is necessary to
> have a library transition, which is most easily done by renaming the
> runtime library package.
>
> Since turning on 64-bit time_t is being handled centrally through a change
> to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
> important that libraries affected by this ABI change all be uploaded close
> together in time.  Therefore I have prepared a 0-day NMU for
> google-perftools
> which will initially be uploaded to experimental if possible, then to
> unstable after packages have cleared binary NEW.
>
> Please find the patch for this NMU attached.
>
> If you have any concerns about this patch, please reach out ASAP.  Although
> this package will be uploaded to experimental immediately, there will be a
> period of several days before we begin uploads to unstable; so if
> information
> becomes available that your package should not be included in the
> transition,
> there is time for us to amend the planned uploads.
>
>
>
> -- System Information:
> Debian Release: trixie/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 6.5.0-15-generic (SMP w/8 CPU threads; PREEMPT)
> Kernel taint flags: TAINT_OOT_MODULE
> Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: unable to detect
>


Bug#1062116: google-perftools: NMU diff for 64-bit time_t transition

2024-01-31 Thread Graham Inggs
Source: google-perftools
Version: 2.15-1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
google-perftools as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for google-perftools
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru google-perftools-2.15/debian/changelog 
google-perftools-2.15/debian/changelog
--- google-perftools-2.15/debian/changelog  2024-01-07 10:18:34.0 
+
+++ google-perftools-2.15/debian/changelog  2024-01-31 12:15:30.0 
+
@@ -1,3 +1,10 @@
+google-perftools (2.15-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Graham Inggs   Wed, 31 Jan 2024 12:15:30 +
+
 google-perftools (2.15-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru google-perftools-2.15/debian/control 
google-perftools-2.15/debian/control
--- google-perftools-2.15/debian/control2023-09-06 06:21:09.0 
+
+++ google-perftools-2.15/debian/control2024-01-31 12:15:29.0 
+
@@ -13,7 +13,7 @@
 Package: libgoogle-perftools-dev
 Section: libdevel
 Architecture: any
-Depends: ${misc:Depends}, libgoogle-perftools4 (= ${binary:Version}), 
libtcmalloc-minimal4 (= ${binary:Version}), libunwind-dev [amd64]
+Depends: ${misc:Depends}, libgoogle-perftools4t64 (= ${binary:Version}), 
libtcmalloc-minimal4t64 (= ${binary:Version}), libunwind-dev [amd64]
 Multi-Arch: same
 Description: libraries for CPU and heap analysis, plus an efficient 
thread-caching malloc
  The gperftools, previously called google-perftools, package contains some
@@ -22,7 +22,10 @@
  utilities.  The devel package contains static and debug libraries and header
  files for developing applications that use the google-perftools package.
 
-Package: libtcmalloc-minimal4
+Package: libtcmalloc-minimal4t64
+Provides: ${t64:Provides}
+Replaces: libtcmalloc-minimal4
+Breaks: libtcmalloc-minimal4 (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Multi-Arch: same
@@ -31,9 +34,12 @@
  utilities to improve and analyze the performance of C++ programs. This is a
  part of that package, and includes an optimized thread-caching malloc.
 
-Package: libgoogle-perftools4
+Package: libgoogle-perftools4t64
+Provides: ${t64:Provides}
+Replaces: libgoogle-perftools4
+Breaks: libgoogle-perftools4 (<< ${source:Version})
 Architecture: any
-Depends: libtcmalloc-minimal4 (= ${binary:Version}), ${shlibs:Depends}, 
${misc:Depends}
+Depends: libtcmalloc-minimal4t64 (= ${binary:Version}), ${shlibs:Depends}, 
${misc:Depends}
 Conflicts: libgoogle-perftools0
 Multi-Arch: same
 Description: libraries for CPU and heap analysis, plus an efficient 
thread-caching malloc
@@ -45,7 +51,7 @@
 Package: google-perftools
 Section: devel
 Architecture: all
-Depends: ${misc:Depends}, ${perl:Depends}, libgoogle-perftools4, curl
+Depends: ${misc:Depends}, ${perl:Depends}, libgoogle-perftools4t64, curl
 Suggests: libgoogle-perftools-dev
 Recommends: graphviz, gv
 Description: command line utilities to analyze the performance of C++ programs
diff -Nru google-perftools-2.15/debian/libgoogle-perftools4.install