Bug#1062400: liblnk: NMU diff for 64-bit time_t transition

2024-02-29 Thread Benjamin Drung
Source: liblnk
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru liblnk-20181227/debian/changelog liblnk-20181227/debian/changelog
--- liblnk-20181227/debian/changelog2020-01-18 23:23:58.0 +
+++ liblnk-20181227/debian/changelog2024-02-29 18:43:39.0 +
@@ -1,3 +1,10 @@
+liblnk (20181227-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062400
+
+ -- Benjamin Drung   Thu, 29 Feb 2024 18:43:39 +
+
 liblnk (20181227-1.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru liblnk-20181227/debian/control liblnk-20181227/debian/control
--- liblnk-20181227/debian/control  2020-01-18 23:23:58.0 +
+++ liblnk-20181227/debian/control  2024-02-29 18:43:39.0 +
@@ -2,7 +2,7 @@
 Priority: optional
 Maintainer: Debian Security Tools 
 Uploaders: Hilko Bengen 
-Build-Depends: debhelper (>= 11),
+Build-Depends: dpkg-dev (>= 1.22.5), debhelper (>= 11),
  pkg-config, dh-python, python3-dev, libbfio-dev,
 Standards-Version: 4.3.0
 Section: libs
@@ -15,13 +15,16 @@
 Architecture: any
 Multi-Arch: same
 Depends: ${shlibs:Depends}, ${misc:Depends},
- liblnk1 (= ${binary:Version})
+ liblnk1t64 (= ${binary:Version})
 Description: Windows Shortcut File format access library -- development files
  liblnk is a library to access the Windows Shortcut File (LNK) format.
  .
  This package includes the development support files.
 
-Package: liblnk1
+Package: liblnk1t64
+Provides: ${t64:Provides}
+Replaces: liblnk1
+Breaks: liblnk1 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -37,7 +40,7 @@
 Architecture: any
 Multi-Arch: foreign
 Depends: ${shlibs:Depends}, ${misc:Depends},
- liblnk1,
+ liblnk1t64,
 Description: Windows Shortcut File format access library -- Utilities
  liblnk is a library to access the Windows Shortcut File (LNK) format.
  .
@@ -47,7 +50,7 @@
 Package: python3-liblnk
 Section: python
 Architecture: any
-Depends: liblnk1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, 
${python3:Depends}
+Depends: liblnk1t64 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, 
${python3:Depends}
 Description: Windows Shortcut File format access library -- Python 3 bindings
  liblnk is a library to access the Windows Shortcut File (LNK) format.
  .
diff -Nru liblnk-20181227/debian/liblnk1.install 
liblnk-20181227/debian/liblnk1.install
--- liblnk-20181227/debian/liblnk1.install  2020-01-18 23:23:58.0 
+
+++ liblnk-20181227/debian/liblnk1.install  1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*-*/lib*.so.*
diff -Nru liblnk-20181227/debian/liblnk1.symbols 
liblnk-20181227/debian/liblnk1.symbols
--- liblnk-20181227/debian/liblnk1.symbols  2020-01-18 23:23:58.0 
+
+++ liblnk-20181227/debian/liblnk1.symbols  1970-01-01 00:00:00.0 
+
@@ -1,138 +0,0 @@
-liblnk.so.1 liblnk1 #MINVER#
- (optional|regex)^libcdata_.* 0
- (optional|regex)^libcerror_.* 0
- (optional|regex)^libcfile_.* 0
- (optional|regex)^libclocale_.* 0
- (optional|regex)^libcnotify_.* 0
- (optional|regex)^libcpath_.* 0
- (optional|regex)^libcsplit_.* 0
- (optional|regex)^libcthreads_.* 0
- (optional|regex)^libfdatetime_.* 0
- (optional|regex)^libfguid_.* 0
- (optional|regex)^libfole_.* 0
- (optional|regex)^libfwps_.* 0
- (optional|regex)^libfwsi_.* 0
- (optional|regex)^libuna_.* 0
- curi_class_identifier@Base 20150617
- libfwsp_format_class_identifier_named_properties@Base 20150617
- libfwsp_format_class_identifier_unknown1@Base 20150617
- liblnk_check_file_signature@Base 20150617
- liblnk_check_file_signature_file_io_handle@Base 20150617
- liblnk_data_block_free@Base 20150617
- liblnk_data_block_initialize@Base 20150617
- liblnk_data_block_read@Base 20150617
- liblnk_data_block_strings_read@Base 20150617
- liblnk_data_string_free@Base 20150617
- liblnk_data_string_get_utf16_string@Base 20150617
- liblnk_data_string_get_utf16_string_size@Base 20150617
- liblnk_data_string_get_utf8_string@Base 20150617
- liblnk_data_string_get_utf8_string_size@Base 20150617
- liblnk_data_string_initialize@Base 20150617
- liblnk_data_string_read@Base 20150617
- liblnk_distributed_link_tracker_properties_free@Base 20150617
- liblnk_distributed_link_tracker_properties_initialize@Base 20150617

Bug#1062400: liblnk: NMU diff for 64-bit time_t transition

2024-02-01 Thread Steve Langasek
Source: liblnk
Version: 20181227-1.1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
liblnk as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for liblnk
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru liblnk-20181227/debian/changelog liblnk-20181227/debian/changelog
--- liblnk-20181227/debian/changelog2020-01-18 23:23:58.0 +
+++ liblnk-20181227/debian/changelog2024-02-01 09:27:41.0 +
@@ -1,3 +1,10 @@
+liblnk (20181227-1.2) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Steve Langasek   Thu, 01 Feb 2024 09:27:41 +
+
 liblnk (20181227-1.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru liblnk-20181227/debian/control liblnk-20181227/debian/control
--- liblnk-20181227/debian/control  2020-01-18 23:23:58.0 +
+++ liblnk-20181227/debian/control  2024-02-01 09:27:40.0 +
@@ -15,13 +15,16 @@
 Architecture: any
 Multi-Arch: same
 Depends: ${shlibs:Depends}, ${misc:Depends},
- liblnk1 (= ${binary:Version})
+ liblnk1t64 (= ${binary:Version})
 Description: Windows Shortcut File format access library -- development files
  liblnk is a library to access the Windows Shortcut File (LNK) format.
  .
  This package includes the development support files.
 
-Package: liblnk1
+Package: liblnk1t64
+Provides: ${t64:Provides}
+Replaces: liblnk1
+Breaks: liblnk1 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -37,7 +40,7 @@
 Architecture: any
 Multi-Arch: foreign
 Depends: ${shlibs:Depends}, ${misc:Depends},
- liblnk1,
+ liblnk1t64,
 Description: Windows Shortcut File format access library -- Utilities
  liblnk is a library to access the Windows Shortcut File (LNK) format.
  .
@@ -47,7 +50,7 @@
 Package: python3-liblnk
 Section: python
 Architecture: any
-Depends: liblnk1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, 
${python3:Depends}
+Depends: liblnk1t64 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, 
${python3:Depends}
 Description: Windows Shortcut File format access library -- Python 3 bindings
  liblnk is a library to access the Windows Shortcut File (LNK) format.
  .
diff -Nru liblnk-20181227/debian/liblnk1.install 
liblnk-20181227/debian/liblnk1.install
--- liblnk-20181227/debian/liblnk1.install  2020-01-18 23:23:58.0 
+
+++ liblnk-20181227/debian/liblnk1.install  1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*-*/lib*.so.*
diff -Nru liblnk-20181227/debian/liblnk1.symbols 
liblnk-20181227/debian/liblnk1.symbols
--- liblnk-20181227/debian/liblnk1.symbols  2020-01-18 23:23:58.0 
+
+++ liblnk-20181227/debian/liblnk1.symbols  1970-01-01 00:00:00.0 
+
@@ -1,138 +0,0 @@
-liblnk.so.1 liblnk1 #MINVER#
- (optional|regex)^libcdata_.* 0
- (optional|regex)^libcerror_.* 0
- (optional|regex)^libcfile_.* 0
- (optional|regex)^libclocale_.* 0
- (optional|regex)^libcnotify_.* 0
- (optional|regex)^libcpath_.* 0
- (optional|regex)^libcsplit_.* 0
- (optional|regex)^libcthreads_.* 0
- (optional|regex)^libfdatetime_.* 0
-