Bug#1066392: gtk2-engines-murrine: FTBFS: ./src/murrine_style.c:133:30: error: implicit declaration of function ‘murrine_widget_is_ltr’; did you mean ‘murrine_widget_is_rgba’? [-Werror=implicit-functi
tags 1066392 +patch thanks I've whipped up a patch that adds the missing function declarations to the headers. Review and upload would be appreciated as this is needed for the time64 transition (and is a key package, so can't simply be autoremoved). diff -Nru gtk2-engines-murrine-0.98.2/debian/changelog gtk2-engines-murrine-0.98.2/debian/changelog --- gtk2-engines-murrine-0.98.2/debian/changelog2019-11-18 08:32:18.0 + +++ gtk2-engines-murrine-0.98.2/debian/changelog2024-04-02 02:51:30.0 + @@ -1,3 +1,11 @@ +gtk2-engines-murrine (0.98.2-3.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Add declarations for functions to fix implicit function declaration +errors. + + -- Peter Michael Green Tue, 02 Apr 2024 02:51:30 + + gtk2-engines-murrine (0.98.2-3) unstable; urgency=medium [ Mike Gabriel ] diff -Nru gtk2-engines-murrine-0.98.2/debian/patches/add-missing-function-declarations.patch gtk2-engines-murrine-0.98.2/debian/patches/add-missing-function-declarations.patch --- gtk2-engines-murrine-0.98.2/debian/patches/add-missing-function-declarations.patch 1970-01-01 00:00:00.0 + +++ gtk2-engines-murrine-0.98.2/debian/patches/add-missing-function-declarations.patch 2024-04-02 02:51:30.0 + @@ -0,0 +1,31 @@ +Description: Add declarations for functions to fix implicit function declaration errors. +Author: Peter Michael Green + +--- gtk2-engines-murrine-0.98.2.orig/src/murrine_rc_style.h gtk2-engines-murrine-0.98.2/src/murrine_rc_style.h +@@ -155,4 +155,6 @@ struct _MurrineRcStyleClass + + GType murrine_rc_style_get_type (void); + ++void murrine_rc_style_register_types (GTypeModule *module); ++ + #endif /* MURRINE_RC_STYLE_H */ +--- gtk2-engines-murrine-0.98.2.orig/src/murrine_style.h gtk2-engines-murrine-0.98.2/src/murrine_style.h +@@ -102,5 +102,6 @@ struct _MurrineStyleClass + }; + + GType murrine_style_get_type (void); ++void murrine_style_register_types (GTypeModule *module); + + #endif /* MURRINE_STYLE_H */ +--- gtk2-engines-murrine-0.98.2.orig/src/support.h gtk2-engines-murrine-0.98.2/src/support.h +@@ -149,4 +149,7 @@ G_GNUC_INTERNAL void murrine_get_noteboo + gboolean *start, + gboolean *end); + ++gboolean murrine_object_is_a (const GObject * object, const gchar * type_name); ++gboolean murrine_widget_is_ltr (GtkWidget *widget); ++ + #endif /* SUPPORT_H */ diff -Nru gtk2-engines-murrine-0.98.2/debian/patches/series gtk2-engines-murrine-0.98.2/debian/patches/series --- gtk2-engines-murrine-0.98.2/debian/patches/series 2019-11-12 09:31:57.0 + +++ gtk2-engines-murrine-0.98.2/debian/patches/series 2024-04-02 02:51:30.0 + @@ -1,2 +1,3 @@ 02_fix-linking-lm.patch pango_cairo_update_layout.patch +add-missing-function-declarations.patch
Bug#1066392: gtk2-engines-murrine: FTBFS: ./src/murrine_style.c:133:30: error: implicit declaration of function ‘murrine_widget_is_ltr’; did you mean ‘murrine_widget_is_rgba’? [-Werror=implicit-functi
Source: gtk2-engines-murrine Version: 0.98.2-3 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lu...@debian.org Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef Hi, During a rebuild of all packages in sid, your package failed to build on amd64. This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration Relevant part (hopefully): > /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > -I./src -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include > -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz > -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount > -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo > -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/atk-1.0 > -pthread -I/usr/include/pixman-1 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 > -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. > -fstack-protector-strong -fstack-clash-protection -Wformat > -Werror=format-security -fcf-protection -c -o murrine_draw_rgba.lo `test -f > './src/murrine_draw_rgba.c' || echo './'`./src/murrine_draw_rgba.c > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./src -I/usr/include/gtk-2.0 > -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 > -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi > -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/atk-1.0 > -pthread -I/usr/include/pixman-1 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 > -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. > -fstack-protector-strong -fstack-clash-protection -Wformat > -Werror=format-security -fcf-protection -c ./src/support.c -fPIC -DPIC -o > .libs/support.o > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./src -I/usr/include/gtk-2.0 > -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 > -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi > -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/atk-1.0 > -pthread -I/usr/include/pixman-1 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 > -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. > -fstack-protector-strong -fstack-clash-protection -Wformat > -Werror=format-security -fcf-protection -c ./src/murrine_rc_style.c -fPIC > -DPIC -o .libs/murrine_rc_style.o > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./src -I/usr/include/gtk-2.0 > -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 > -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi > -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/atk-1.0 > -pthread -I/usr/include/pixman-1 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 > -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. > -fstack-protector-strong -fstack-clash-protection -Wformat > -Werror=format-security -fcf-protection -c ./src/murrine_style.c -fPIC -DPIC > -o .libs/murrine_style.o > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./src -I/usr/include/gtk-2.0 > -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 > -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi > -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 > -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/atk-1.0 > -pthread -I/usr/include/pixman-1 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 > -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. > -fstack-protector-strong -fstack-clash-protection -Wformat > -Werror=format-security -fcf-protection -c ./src/murrine_draw_rgba.c -fPIC > -DPIC -o .libs/murrine_draw_rgba.o > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./src -I/usr/include/gtk-2.0 > -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include