Bug#1067303: trash-cli in Debian: test problems again

[Jonathan Dowland]

Hi Boyuan (and Andrea)

On Tue May 28, 2024 at 8:08 PM BST, Boyuan Yang wrote:
> On Sun, 26 May 2024 14:04:40 +0200 Andrea Francia  
> wrote:
> > Hi Jonathan and Lucas,
> >   I solved the problem in the new release (0.24.5.26).

That's great news! I' dli

> Can you take a look and prepare a new release into Sid recently? If not,
> would you mind a NMU into DELAYED/15 with the fix included?

I'll take a look Today. I'm otherwise happy for NMUs, I'm on the Low
Threshold NMU list.


Best wishes,

-- 

  Jonathan Dowland
✎j...@debian.org
   https://jmtd.net

Bug#1067303: trash-cli in Debian: test problems again

[Boyuan Yang]

X-Debbugs-CC: j...@debian.org stef...@karapetsas.com and...@andreafrancia.it

Hi Jonathan, Stefano,

On Sun, 26 May 2024 14:04:40 +0200 Andrea Francia  
wrote:
> Hi Jonathan and Lucas,
>   I solved the problem in the new release (0.24.5.26).
> 
> I tested it with these commands:
> git clone https://salsa.debian.org/debian/trash-cli.git
> cd trash-cli
> git remote add upstream https://github.com/andreafrancia/trash-cli
> git fetch upstream
> git merge 0.24.5.26
> debuild -b -uc -us


Can you take a look and prepare a new release into Sid recently? If not,
would you mind a NMU into DELAYED/15 with the fix included?

Thanks,
Boyuan Yang


signature.asc
Description: This is a digitally signed message part

Bug#1067303: trash-cli in Debian: test problems again

[Andrea Francia]

Hi Jonathan and Lucas,
  I solved the problem in the new release (0.24.5.26).

I tested it with these commands:
git clone https://salsa.debian.org/debian/trash-cli.git
cd trash-cli
git remote add upstream https://github.com/andreafrancia/trash-cli
git fetch upstream
git merge 0.24.5.26
debuild -b -uc -us

Here the results of the build:
andrea@lima-default:~/trash-cli$ debuild -b -uc -us
 dpkg-buildpackage -us -uc -ui -b
dpkg-buildpackage: info: source package trash-cli
dpkg-buildpackage: info: source version 0.23.11.10-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Jonathan Dowland 
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture arm64
 fakeroot debian/rules clean
dh clean --with python3 --buildsystem=pybuild
   dh_auto_clean -O--buildsystem=pybuild
   dh_autoreconf_clean -O--buildsystem=pybuild
   dh_clean -O--buildsystem=pybuild
 debian/rules build
dh build --with python3 --buildsystem=pybuild
   dh_update_autotools_config -O--buildsystem=pybuild
   dh_autoreconf -O--buildsystem=pybuild
   dh_auto_configure -O--buildsystem=pybuild
   dh_auto_build -O--buildsystem=pybuild
I: pybuild plugin_pyproject:107: Building wheel for python3.11 with "build"
module
I: pybuild base:240: python3.11 -m build --skip-dependency-check
--no-isolation --wheel --outdir
/home/andrea.linux/trash-cli/.pybuild/cpython3_3.11
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/trashcli
copying trashcli/trash.py -> build/lib/trashcli
copying trashcli/fs.py -> build/lib/trashcli
copying trashcli/file_system_reader.py -> build/lib/trashcli
copying trashcli/trash_dirs_scanner.py -> build/lib/trashcli
copying trashcli/shell_completion.py -> build/lib/trashcli
copying trashcli/__init__.py -> build/lib/trashcli
copying trashcli/compat.py -> build/lib/trashcli
creating build/lib/trashcli/empty
copying trashcli/empty/existing_file_remover.py -> build/lib/trashcli/empty
copying trashcli/empty/empty_action.py -> build/lib/trashcli/empty
copying trashcli/empty/errors.py -> build/lib/trashcli/empty
copying trashcli/empty/guard.py -> build/lib/trashcli/empty
copying trashcli/empty/parser.py -> build/lib/trashcli/empty
copying trashcli/empty/parse_reply.py -> build/lib/trashcli/empty
copying trashcli/empty/delete_according_date.py -> build/lib/trashcli/empty
copying trashcli/empty/prepare_output_message.py -> build/lib/trashcli/empty
copying trashcli/empty/main.py -> build/lib/trashcli/empty
copying trashcli/empty/console.py -> build/lib/trashcli/empty
copying trashcli/empty/empty_cmd.py -> build/lib/trashcli/empty
copying trashcli/empty/top_trash_dir_rules_file_system_reader.py ->
build/lib/trashcli/empty
copying trashcli/empty/is_input_interactive.py -> build/lib/trashcli/empty
copying trashcli/empty/description.py -> build/lib/trashcli/empty
copying trashcli/empty/clock.py -> build/lib/trashcli/empty
copying trashcli/empty/older_than.py -> build/lib/trashcli/empty
copying trashcli/empty/file_system_dir_reader.py -> build/lib/trashcli/empty
copying trashcli/empty/emptier.py -> build/lib/trashcli/empty
copying trashcli/empty/__init__.py -> build/lib/trashcli/empty
copying trashcli/empty/print_time_action.py -> build/lib/trashcli/empty
copying trashcli/empty/user.py -> build/lib/trashcli/empty
creating build/lib/trashcli/lib
copying trashcli/lib/my_input.py -> build/lib/trashcli/lib
copying trashcli/lib/my_permission_error.py -> build/lib/trashcli/lib
copying trashcli/lib/enum_repr.py -> build/lib/trashcli/lib
copying trashcli/lib/trash_dirs.py -> build/lib/trashcli/lib
copying trashcli/lib/logger.py -> build/lib/trashcli/lib
copying trashcli/lib/user_info.py -> build/lib/trashcli/lib
copying trashcli/lib/dir_checker.py -> build/lib/trashcli/lib
copying trashcli/lib/print_version.py -> build/lib/trashcli/lib
copying trashcli/lib/environ.py -> build/lib/trashcli/lib
copying trashcli/lib/exit_codes.py -> build/lib/trashcli/lib
copying trashcli/lib/__init__.py -> build/lib/trashcli/lib
copying trashcli/lib/trash_dir_reader.py -> build/lib/trashcli/lib
copying trashcli/lib/dir_reader.py -> build/lib/trashcli/lib
copying trashcli/lib/path_of_backup_copy.py -> build/lib/trashcli/lib
creating build/lib/trashcli/list
copying trashcli/list/fs.py -> build/lib/trashcli/list
copying trashcli/list/parser.py -> build/lib/trashcli/list
copying trashcli/list/main.py -> build/lib/trashcli/list
copying trashcli/list/list_trash_action.py -> build/lib/trashcli/list
copying trashcli/list/trash_dir_selector.py -> build/lib/trashcli/list
copying trashcli/list/extractors.py -> build/lib/trashcli/list
copying trashcli/list/__init__.py -> build/lib/trashcli/list
creating build/lib/trashcli/list/minor_actions
copying trashcli/list/minor_actions/debug_volumes.py ->
build/lib/trashcli/list/minor_actions
copying trashcli/list/minor_actions/list_trash_dirs.py ->
build/lib/trashcli/list/minor_actions
copying 

Bug#1067303: trash-cli in Debian: test problems again

[Andrea Francia]

Hi Jonathan,
  I think I could solve this problem if only I knew how to reproduce the
problem on my machine.

I am not an expert on how package builds work on Debian but I can get a
virtual machine with a Debian on it.
I would just need the steps to reproduce the error reported by Lucas.

I will also try to better document the use of tox in trash-cli, I am using
it but I am not familiar with it, it is likely that I need to improve the
use of tox in trash-cli.

If someone can send me the commands to reproduce your results I am sure I
can solve it in no time.

Regards and thanks for the report

Il giorno mer 8 mag 2024 alle ore 15:13 Jonathan Dowland 
ha scritto:

> Hi Andrea
>
> I'm afraid we've hit problems running the trash-cli test suite in Debian
> again. Our automated processes have removed the package from "testing"
> for the time being.
>
> A trace of the errors is available here:
> 
>
> It looks like the Debian packaging invokes pytest to run the test suite.
> Does that make sense today?
>
> The errors are all of the form
>
> > E   ModuleNotFoundError: No module named 'scripts'
>
> which implies an import path issue. Any clues?
>
> I've explored moving to your latest tag, and also trying to use tox for
> running the test suite, but I haven't got something that passes yet.
> (For tox the issue is that the test suite needs to run offline, so it
> behaves very differently to if I just ran "tox" on my developer machine,
> which worked after I adjusted Python 3.10 to 3.11 in tox.ini and changed
> one test.)
>
> If you've got any time or clues or suggestions about what to try next
> I'd really appreciate it. I don't do much Python packaging (trash-cli
> is currently my own Python package) and I have trouble keeping up with
> what the current Python test, build, project, configure fashions are, as
> well as the same for the Debian packaging layer (we've had several
> Debian/Python build integrations over the years too).
>
>
>
> Best wishes,
>
> --
> Jonathan Dowland
> ✎j...@debian.org
>   https://jmtd.net
>
>

-- 
Andrea Francia http://andreafrancia.it

Bug#1067303: trash-cli in Debian: test problems again

[Jonathan Dowland]

Hi Andrea

I'm afraid we've hit problems running the trash-cli test suite in Debian
again. Our automated processes have removed the package from "testing"
for the time being.

A trace of the errors is available here:


It looks like the Debian packaging invokes pytest to run the test suite.
Does that make sense today?

The errors are all of the form

> E   ModuleNotFoundError: No module named 'scripts'

which implies an import path issue. Any clues?

I've explored moving to your latest tag, and also trying to use tox for
running the test suite, but I haven't got something that passes yet.
(For tox the issue is that the test suite needs to run offline, so it
behaves very differently to if I just ran "tox" on my developer machine,
which worked after I adjusted Python 3.10 to 3.11 in tox.ini and changed
one test.)

If you've got any time or clues or suggestions about what to try next
I'd really appreciate it. I don't do much Python packaging (trash-cli
is currently my own Python package) and I have trouble keeping up with
what the current Python test, build, project, configure fashions are, as
well as the same for the Debian packaging layer (we've had several
Debian/Python build integrations over the years too).



Best wishes,

-- 
  Jonathan Dowland
✎j...@debian.org
   https://jmtd.net