Bug#318405: acknowledged by developer (Bug#318218: fixed in xorg-x11 6.8.2.dfsg.1-3)

2005-07-19 Thread Reinhard Karcher 
Debian Bug Tracking System schrieb:
> This is an automatic notification regarding your Bug report
> #318405: xserver-xorg sets wrong palete on switching to console.,
> which was filed against the xserver-xorg package.
> 
> It has been closed by one of the developers, namely
> David Nusinow <[EMAIL PROTECTED]>.
> 
> Their explanation is attached below.  If this explanation is
> unsatisfactory and you have not received a better one in a separate
> message then please contact the developer, by replying to this email.
> 
> A summary of the changes between this version and the previous one is
> attached.
> 
> Thank you for reporting the bug, which will now be closed.  If you
> have further comments please address them to [EMAIL PROTECTED],
> and the maintainer will reopen the bug report if appropriate.
> 
> Debian distribution maintenance software
> pp.
> David Nusinow <[EMAIL PROTECTED]> (supplier of updated xorg-x11 package)
> 
> (This message was generated automatically at their request; if you
> believe that there is a problem with it please contact the archive
> administrators by mailing [EMAIL PROTECTED])
> 
>Changes by David Nusinow:
>   - Add 030_libvgahw_gcc4_volatile_fix.diff to work around libvgahw.a gcc4
> breakages. Thanks David Marti­nez Moreno and Paul Hampson.
> Closes: #318218, #318231, #318271, #318405, #318430
> 
Sorry,
the bug is not fixed by 6.8.2.dfsg.1-3.
I have to use the same workaround as before.
Please reopen bug.

Reinhard

Bug#319003: xserver-xorg: Trident and -3: libvgahw is still broken, Bug#318405: acknowledged by developer (Bug#318218: fixed in xorg-x11 6.8.2.dfsg.1-3)

2005-07-20 Thread Eugene Konev 

Can you please test if the problem still exists with the following
libvgahw.a: http://www.imfi.kspu.ru/~ejka/libvgahw.a



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#318405: Bug#319003: xserver-xorg: Trident and -3: libvgahw is still broken, Bug#318405: acknowledged by developer (Bug#318218: fixed in xorg-x11 6.8.2.dfsg.1-3)

2005-07-20 Thread Reinhard Karcher 
On Wed, Jul 20, 2005 at 02:50:21PM +0800, Eugene Konev wrote
> 
> Can you please test if the problem still exists with the following
> libvgahw.a: http://www.imfi.kspu.ru/~ejka/libvgahw.a
> 

Problem doesn't exit anymore. Thank you!

Reinhard



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#318405: Bug#319003: xserver-xorg: Trident and -3: libvgahw is still broken, Bug#318405: acknowledged by developer (Bug#318218: fixed in xorg-x11 6.8.2.dfsg.1-3)

2005-07-20 Thread Eugene Konev 

Hello David.

On Wed, 20 Jul 2005 10:50:28 +0200
you wrote:

> What workaround have you tried to build that libvgahw.a? No
> optimization, or
> an enhanced version of the X.Org patch?

Enhanced version. Attached.

gcc4 has issues with libvgahw.a. This patch is a workaround stolen from
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=161242 (by Olivier
Baudron). See also Debian #318218 and bugs merged to it

Index: xorg-x11-6.8.2.dfsg.1/programs/Xserver/hw/xfree86/vgahw/vgaHW.c
===
--- xc-old/programs/Xserver/hw/xfree86/vgahw/vgaHW.c2005-07-20 
10:32:26.0 +0800
+++ xc/programs/Xserver/hw/xfree86/vgahw/vgaHW.c2005-07-20 
10:33:42.0 +0800
@@ -428,12 +428,16 @@
 static void
 mmioWriteAttr(vgaHWPtr hwp, CARD8 index, CARD8 value)
 {
+volatile CARD8 tmp;
+
 if (hwp->paletteEnabled)
index &= ~0x20;
 else
index |= 0x20;
 
-(void) minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+/* gcc-4.0 -O2 is broken : needs a volatile assignment */ 
+tmp = minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+
 moutb(VGA_ATTR_INDEX, index);
 moutb(VGA_ATTR_DATA_W, value);
 }
@@ -441,12 +445,16 @@
 static CARD8
 mmioReadAttr(vgaHWPtr hwp, CARD8 index)
 {
+volatile CARD8 tmp;
+  
 if (hwp->paletteEnabled)
index &= ~0x20;
 else
index |= 0x20;
 
-(void) minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+/* gcc-4.0 -O2 is broken : needs a volatile assignment */ 
+tmp = minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+
 moutb(VGA_ATTR_INDEX, index);
 return minb(VGA_ATTR_DATA_R);
 }
@@ -466,7 +474,11 @@
 static void
 mmioEnablePalette(vgaHWPtr hwp)
 {
-(void) minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+volatile CARD8 tmp;
+
+/* gcc-4.0 -O2 is broken : needs a volatile assignment */ 
+tmp = minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+
 moutb(VGA_ATTR_INDEX, 0x00);
 hwp->paletteEnabled = TRUE;
 }
@@ -474,7 +486,11 @@
 static void
 mmioDisablePalette(vgaHWPtr hwp)
 {
-(void) minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+volatile CARD8 tmp;
+
+/* gcc-4.0 -O2 is broken : needs a volatile assignment */ 
+tmp = minb(hwp->IOBase + VGA_IN_STAT_1_OFFSET);
+
 moutb(VGA_ATTR_INDEX, 0x20);
 hwp->paletteEnabled = FALSE;
 }