Bug#352210: websvn: Temporary files not compliant to FSH

[gregor herrmann]

tags 352210 + patch
thanks

On Fri, Feb 10, 2006 at 02:24:52PM +0100, Claudio Sacerdoti Coen wrote:

>  Temporary directories and files are created in /usr/share/websvn/temp.
>  IMHO this behaviour is not compliant with FSH.

This seems to be caused by the upstream source which makes heavy use
of
  tempnam("temp", "");

If I understand http://uk.php.net/tempnam correctly php should fall
back to the system's tempdir if it cannot create a tempfile in the
given directory; hence I assume that by _not_ providing
/usr/share/websvn/temp websvn should use the system default.

The attached patch implements this assumption.

HTH,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
 : :' :  infos zur usenet-hierarchie at.*: http://www.usenet.at/
 `. `'   member of https://www.vibe.at/ | how to reply: http://got.to/quote/
   `-NP: Element Of Crime: The Last Dance (Live)
diff -urN websvn-1.61/debian/dirs websvn-1.61.new/debian/dirs
--- websvn-1.61/debian/dirs 2006-03-19 23:19:46.0 +0100
+++ websvn-1.61.new/debian/dirs 2006-03-19 23:19:24.0 +0100
@@ -2,6 +2,5 @@
 usr/share/websvn
 usr/share/websvn/include
 usr/share/websvn/languages
-usr/share/websvn/temp
 usr/share/websvn/templates
 var/cache/websvn
diff -urN websvn-1.61/debian/rules websvn-1.61.new/debian/rules
--- websvn-1.61/debian/rules2006-03-19 23:19:46.0 +0100
+++ websvn-1.61.new/debian/rules2006-03-19 23:19:24.0 +0100
@@ -24,7 +24,7 @@
echo '}' >> $(CURDIR)/debian/websvn/etc/websvn/config.inc
echo '?>' >> $(CURDIR)/debian/websvn/etc/websvn/config.inc
# main install
-   for i in *.php languages templates include temp; do \
+   for i in *.php languages templates include; do \
  cp -pr $(CURDIR)/$$i $(CURDIR)/debian/websvn/usr/share/websvn; \
done
# fix permissions


signature.asc
Description: Digital signature

Bug#352210: websvn: Temporary files not compliant to FSH

[Claudio Sacerdoti Coen]

Package: websvn
Version: 1.61-16
Severity: critical
Justification: breaks the whole system


 Temporary directories and files are created in /usr/share/websvn/temp.
 IMHO this behaviour is not compliant with FSH.

 Moreover, it seems that the temporary files are never got rid of.
 In a few days 4.18GBytes of temporary data were generated in /usr/...,
 until the disk was full!

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.4.23-mowgli
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages websvn depends on:
ii  apache [httpd]  1.3.34-1 versatile, high-performance HTTP s
ii  apache2-mpm-prefork [httpd] 2.0.55-3 traditional model for Apache2
ii  debconf [debconf-2.0]   1.4.66   Debian configuration management sy
ii  libapache2-mod-php4 4:4.4.0-4server-side, HTML-embedded scripti
ii  php44:4.4.0-4server-side, HTML-embedded scripti
ii  po-debconf  0.9.2manage translated Debconf template
ii  subversion  1.2.3dfsg1-3 advanced version control system (a
ii  ucf 2.004Update Configuration File: preserv

Versions of packages websvn recommends:
ii  enscript  1.6.4-7Converts ASCII text to Postscript,

-- debconf information:
* websvn/configuration: true
* websvn/parentpath: /local/svn
* websvn/repositories: /local/svn/helm
* websvn/permissions:
* websvn/webservers: apache, apache-ssl, apache-perl, apache2


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]