Bug#395321: vaiostat-source: fails to build against 2.6.18
tags 395321 + patch thanks Hello, I fix this bug by using module_param instead of MODULE_PARM which is deprecated (in favor of module_param) and not type-safe. It builds fine but could you please try this patch and tell me if the module behaves correctly? If so, I will prepare a NMU. Regards, Arnaud Fontaine --- vaiostat.c.old 2006-12-06 23:06:23.0 +0100 +++ vaiostat.c 2006-12-06 23:13:12.0 +0100 @@ -42,6 +42,7 @@ #include #include #include +#include #include #include @@ -326,10 +327,10 @@ MODULE_DESCRIPTION("Support selected Sony Vaio features."); MODULE_LICENSE("GPL"); -MODULE_PARM(verbose,"i"); +module_param(verbose, int, 0); MODULE_PARM_DESC(verbose, "be verbose, default is 0 (no)"); -MODULE_PARM(umask,"i"); +module_param(umask, int, 0); MODULE_PARM_DESC(umask, "umask for /proc/vaio entries, default 0777"); #ifdef EXPORT_NO_SYMBOLS pgpC0UrOaPGUi.pgp Description: PGP signature
Bug#395321: vaiostat-source: fails to build against 2.6.18
* Arnaud Fontaine <[EMAIL PROTECTED]> [20061207 00:15]: > I fix this bug by using module_param instead of MODULE_PARM which is > deprecated (in favor of module_param) and not type-safe. It builds fine > but could you please try this patch and tell me if the module behaves > correctly? If so, I will prepare a NMU. The patch itself looks ok for me, but sorry - I do not own the appropriate hardware to test the module. regards, -mika- pgpRfaEridZa3.pgp Description: PGP signature
Bug#395321: vaiostat-source: fails to build against 2.6.18
severity 395964 grave merge 395964 395321 thanks Hello, I intend to NMU vaiostat-source in order to fix this bug in the following week if I don't get an answer from you. If you have planned a new release soon, please tell me... Regards, Arnaud Fontaine -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#395321: vaiostat-source: fails to build against 2.6.18
Package: vaiostat-source Version: 1.2-7 Severity: grave Justification: renders package unusable # KPKG_DEST_DIR=/raid/Grml/kernel/ module-assistant -f -l '2.6.18-grml' \ -k /raid/Grml/kernel/linux-2.6.18-grml build vaiostat-source [...] CC [M] /usr/src/modules/vaiostat/vaiostat.o /usr/src/modules/vaiostat/vaiostat.c:329: error: expected ')' before string constant /usr/src/modules/vaiostat/vaiostat.c:332: error: expected ')' before string constant make[4]: *** [/usr/src/modules/vaiostat/vaiostat.o] Error 1 As 2.6.18 is supposed to be shipped with etch I decided to chose severity grave. regards, -mika- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]