Bug#425891: ikiwiki: FTBFS: Test suite failures

[Pawel Tecza]

Hi Joey,

I confirm that Thomas Viehmann's patch fixes the bug.  Now I can
build ikiwiki 2.2 package for my Debian 'sarge' box :)

Thanks a lot to Thomas!

My best regards,

Pawel Tecza


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#425891: ikiwiki: FTBFS: Test suite failures

[Thomas Viehmann]

reopen 425891
found 425891 2.2
tag +patch
thanks

Hi Joey,

I'm afraid that the problem persists in 2.2.
The root cause seems to be that PERL5LIB set in 
t/basewiki_brokenlinks.t
is ignored by ikiwiki.out due to the #!/usr/bin/perl -T in 
ikiwiki.out.
Invoking the test as "perl -T -I. ./ikiwiki.out ..." helps for this, 
but the

other issues raised in
http://ikiwiki.info/bugs/tbasewiki__95__brokenlinks.t_broken/
also seem to still apply.

I have attached a patch which combines the invocation fix with the two
(sane-looking) fixes by the author of above bug report.

Thanks for developing ikiwiki!

Kind regards

T.
--
Thomas Viehmann, http://thomas.viehmann.net/
diff -urN orig/ikiwiki-2.2/IkiWiki.pm ikiwiki-2.2/IkiWiki.pm
--- orig/ikiwiki-2.2/IkiWiki.pm	2007-06-03 16:20:18.0 +
+++ ikiwiki-2.2/IkiWiki.pm	2007-06-26 12:28:09.0 +
@@ -842,7 +842,6 @@
 		return "";
 	}
 
-	require HTML::Template;
 	my @ret=(
 		filter => sub {
 			my $text_ref = shift;
@@ -857,6 +856,7 @@
 } #}}}
 
 sub template ($;@) { #{{{
+	require HTML::Template;
 	HTML::Template->new(template_params(@_));
 } #}}}
 
diff -urN orig/ikiwiki-2.2/t/basewiki_brokenlinks.t ikiwiki-2.2/t/basewiki_brokenlinks.t
--- orig/ikiwiki-2.2/t/basewiki_brokenlinks.t	2007-05-24 20:21:33.0 +
+++ ikiwiki-2.2/t/basewiki_brokenlinks.t	2007-06-26 12:31:06.0 +
@@ -4,6 +4,6 @@
 use Test::More tests => 3;
 
 ok(! system("make ikiwiki.out"));
-ok(! system("PERL5LIB=. ./ikiwiki.out -plugin brokenlinks -rebuild -underlaydir=basewiki t/basewiki_brokenlinks t/basewiki_brokenlinks/out"));
+ok(! system("perl -T -I. ./ikiwiki.out -plugin brokenlinks -rebuild -underlaydir=basewiki -templatedir=templates t/basewiki_brokenlinks t/basewiki_brokenlinks/out"));
 ok(`grep 'no broken links' t/basewiki_brokenlinks/out/index.html`);
 system("rm -rf t/basewiki_brokenlinks/out t/basewiki_brokenlinks/.ikiwiki");

Bug#425891: ikiwiki: FTBFS: Test suite failures

[Daniel Schepler]

Package: ikiwiki
Version: 2.1
Severity: serious

From my pbuilder build log:

...
/usr/bin/make test
make[1]: Entering directory `/tmp/buildd/ikiwiki-2.1'
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 
'blib/lib', 'blib/arch')" t/*.t
t/basename.ok
t/basewiki_brokenlinks.Can't locate IkiWiki.pm in @INC (@INC contains: 
/etc/perl /usr/local/lib/perl/5.8.8 /usr/local/share/perl/5.8.8 /usr/lib/perl5 
/usr/share/perl5 /usr/lib/perl/5.8 /usr/share/perl/5.8 
/usr/local/lib/site_perl) at ./ikiwiki.out line 9.
BEGIN failed--compilation aborted at ./ikiwiki.out line 9.

#   Failed test in t/basewiki_brokenlinks.t at line 7.
grep: t/basewiki_brokenlinks/out/index.html: No such file or directory

#   Failed test in t/basewiki_brokenlinks.t at line 8.
# Looks like you failed 2 tests of 3.
dubious
Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 2-3
Failed 2/3 tests, 33.33% okay
t/bestlink.ok
t/crazy-badass-perl-bugok
t/dirname..ok
t/git..skipped
all skipped: git not available or could not make test dirs
t/html.ok
t/htmlize..ok
t/linkify..ok
t/mercurialskipped
all skipped: hg not available or could not make test dir
t/pagename.ok
t/pagespec_match...ok
t/pagespec_merge...ok
t/pagetitleok
t/readfile.ok
t/svn..skipped
all skipped: svn not available or could not make test dir
t/syntax...ok
t/titlepageok
Failed Test  Stat Wstat Total Fail  Failed  List of Failed
---
t/basewiki_brokenlinks.t2   512 32  66.67%  2-3
3 tests skipped.
Failed 1/18 test scripts, 94.44% okay. 2/322 subtests failed, 99.38% okay.
make[1]: *** [test_dynamic] Error 255
make[1]: Leaving directory `/tmp/buildd/ikiwiki-2.1'
make: *** [build-stamp] Error 2
-- 
Daniel Schepler