Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-15 Thread Samuel Mimram

Hi,

Michael Ablassmeier wrote:

On Wed, Jun 06, 2007 at 09:47:26PM +1000, Erik de Castro Lopo wrote:

Why so that breakages in the FLAC API can break libsndfile again?


well, sometimes api changes are necessary.. wether this one was or not  - i
cant judge - ask the authors of libflac.


Ive been in the same situation with streamripper.

Thats streamripper this is libsndfile.

You are the maintainer of streamripper but not as far as I am
aware the maintainer of libsndfile. I think that is Anand 
Kumria and I do not believe that Anand has any problems with the

way I have been releasing libsndfile so far and I know him well
enough that he would say something if I screwed up.


well, its just that statically linked binaries in debian should be omitted by
policy (or, might be non policy compliant). Imagine a security bug in libflac,
debian's security team would have to care about the libflac packages AND
sndfile - duplicate work again.


I am now the maintainer of libsndfile (I adopted it from Anand some time 
ago) and I strongly second Michael's arguments. I have nothing against 
having the FLAC sources included in libsndfile but please provide an 
easy way to link against external FLAC sources. I will manage FLAC API 
transitions.


Cheers,

Samuel.


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Michael Ablassmeier
Package: libsndfile
Version: 1.0.17-1
Severity: serious
User: [EMAIL PROTECTED]
Usertags: qa-ftbfs

hi,

while doing an archive wide package rebuild your package failed to build from
source for the following reason:

  flac.c:818: error: 'FLAC_PRIVATE' has no member named 'encbuffer'
  flac.c:840: error: 'FLAC_PRIVATE' has no member named 'fse'
  flac.c: In function 'flac_write_f2flac':
  flac.c:860: error: 'FLAC_PRIVATE' has no member named 'encbuffer'
  flac.c:882: error: 'FLAC_PRIVATE' has no member named 'fse'
  flac.c: In function 'flac_write_d2flac':
  flac.c:992: error: 'FLAC_PRIVATE' has no member named 'encbuffer'
  flac.c:1014: error: 'FLAC_PRIVATE' has no member named 'fse'
  flac.c: In function 'flac_seek':
  flac.c:1130: error: 'FLAC_PRIVATE' has no member named 'frame'
  flac.c:1134: warning: implicit declaration of function 
  'FLAC__seekable_stream_decoder_seek_absolute'
  flac.c:1134: warning: nested extern declaration of 
  'FLAC__seekable_stream_decoder_seek_absolute'
  flac.c:1134: error: 'FLAC_PRIVATE' has no member named 'fsd'
  flac.c:1135: error: 'FLAC_PRIVATE' has no member named 'fsd'
  make[4]: *** [flac.lo] Error 1
  make[4]: Leaving directory `/build/user/libsndfile-1.0.17/src'
  make[3]: *** [all-recursive] Error 1
  make[3]: Leaving directory `/build/user/libsndfile-1.0.17/src'
  make[2]: *** [all] Error 2
  make[2]: Leaving directory `/build/user/libsndfile-1.0.17/src'
  make[1]: *** [all-recursive] Error 1
  make[1]: Leaving directory `/build/user/libsndfile-1.0.17'
  make: *** [build-stamp] Error 2

I think this is related to an API change and recent upload of a new FLAC 
Library, from libflac-dev's changelog:

  * New upstream release. closes: #405167, #411311
- libOggFLAC and libOggFLAC++ have been merged into libFLAC, so
  remove their corresponding packages.
- Because of the API changes required to effect the above, there has
  been yet another soname bump. libflac7 - libflac8 and
  libflac++5 - libflac++6. Emails have been dispatched to the
  maintainers of dependent packages.

The Full Build log is available and can be viewed at:

 http://people.debian.org/~lucas/logs/2007/06/04/
 
bye,
- michael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Erik de Castro Lopo
Michael Ablassmeier wrote:

 Package: libsndfile
 Version: 1.0.17-1
 Severity: serious
 User: [EMAIL PROTECTED]
 Usertags: qa-ftbfs
 
 hi,
 
 while doing an archive wide package rebuild your package failed to build from
 source for the following reason:

snip

 I think this is related to an API change and recent upload of a new FLAC 
 Library, from libflac-dev's changelog:

Yep, thats probably right.

The upcoming version of libsndfile contains its own subset of the
FLAC sources so this won't happen again. Unfortunately, that new
version is not quite ready for release yet.

Erik
-- 
-
Erik de Castro Lopo
-
There are two kinds of people in the world, those that have children
and those that ARE children. Children are selfish, or more accurately
ego-centric. Children have a very short-sighted view of the world.
Offer a child one lolly now or the whole bag later and before you can
say ''Don't chop the dinosaur Daddy!'', it's in the gob.
-- my friend Scott


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Michael Ablassmeier
hi,

On Wed, Jun 06, 2007 at 10:58:02AM +0200, Samuel Mimram wrote:
 Michael Ablassmeier wrote:
 while doing an archive wide package rebuild your package failed to build 
 from
 source for the following reason:
 
 snip
 
 I think this is related to an API change and recent upload of a new FLAC 
 Library, from libflac-dev's changelog:
 
 Yep, thats probably right.
 
 The upcoming version of libsndfile contains its own subset of the
 FLAC sources so this won't happen again. Unfortunately, that new
 version is not quite ready for release yet.
 
 Unfortunately, this is not the Debian way of handling things :/ The main 
 reason is that duplication of work should be avoided. If the FLAC 
 maintainer applies a patch, sndfile should be able to benefit of it 
 (that's the idea behind shared libs). Please, provide a way to build 
 against an external FLAC.

indeed, shipping your own flac source and linking against it is more error
prone and might lead to further bugs .. (and means also more work ..)

If, however, libsndfile needs a hacked FLAC source and thus ships its own
version, you should coordinate this with libflac's maintainer, maybe there is a
way to include those changes.

bye,
- michael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Erik de Castro Lopo
Michael Ablassmeier wrote:

 indeed, shipping your own flac source and linking against it is more error
 prone and might lead to further bugs .. (and means also more work ..)

Firstly, the main reason I am shipping a subset of the FLAC sources  
as part of libsndfile is to make building a FLAC enabled libsndfile
easier on MacOSX and windows.

Secondly, I intend to sync the FLAC sources in libsndfile against
FLAC CVS and test it thoroughly before each release.

Finally, the current bug in libsndfile (ie not building) was caused
by changes to the FLAC API, a problem which can never occur again
if I ship a verify subset of the FLAC sources with libsndfile.

Erik
-- 
-
Erik de Castro Lopo
-
...In the UNIX world, people tend to interpret `non-technical user'
as meaning someone who's only ever written one device driver.
-- Daniel Pead


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Michael Ablassmeier
hi,

On Wed, Jun 06, 2007 at 09:26:13PM +1000, Erik de Castro Lopo wrote:
 Michael Ablassmeier wrote:
 
  indeed, shipping your own flac source and linking against it is more error
  prone and might lead to further bugs .. (and means also more work ..)
 
 Firstly, the main reason I am shipping a subset of the FLAC sources  
 as part of libsndfile is to make building a FLAC enabled libsndfile
 easier on MacOSX and windows.
 
 Secondly, I intend to sync the FLAC sources in libsndfile against
 FLAC CVS and test it thoroughly before each release.
 
 Finally, the current bug in libsndfile (ie not building) was caused
 by changes to the FLAC API, a problem which can never occur again
 if I ship a verify subset of the FLAC sources with libsndfile.

as long as libsndfile can still be dynamically linked against the version in
debian this is no problem. But having a debian package which does need to
ship/build its own libflac and link against it, is IMHO opinion useless and
duplicates work (might also waste mirror space).

Ive been in the same situation with streamripper. Its author ships both libtre
and libmad with his source archive, but still allows me to remove it from the
tarball and link against the versions in debian - that doesnt waste mirror
space and saves build time + i dont have to mess with bugs in the libtre /
libmad versions from his tarball.

bye,
- michael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Erik de Castro Lopo
Michael Ablassmeier wrote:

 as long as libsndfile can still be dynamically linked against the version in
 debian this is no problem.

Why so that breakages in the FLAC API can break libsndfile again?

 Ive been in the same situation with streamripper.

Thats streamripper this is libsndfile.

You are the maintainer of streamripper but not as far as I am
aware the maintainer of libsndfile. I think that is Anand 
Kumria and I do not believe that Anand has any problems with the
way I have been releasing libsndfile so far and I know him well
enough that he would say something if I screwed up.

Erik
-- 
-
Erik de Castro Lopo
-
Only wimps use tape backup: *real* men just upload their
important stuff on FTP, and let the rest of the world
mirror it ;) -- Linus Torvalds


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#427749: libsndfile - FTBFS: error: 'FLAC_PRIVATE' has no member named 'encbuffer'

2007-06-06 Thread Michael Ablassmeier
hi,

On Wed, Jun 06, 2007 at 09:47:26PM +1000, Erik de Castro Lopo wrote:
 Why so that breakages in the FLAC API can break libsndfile again?

well, sometimes api changes are necessary.. wether this one was or not  - i
cant judge - ask the authors of libflac.

  Ive been in the same situation with streamripper.
 
 Thats streamripper this is libsndfile.
 
 You are the maintainer of streamripper but not as far as I am
 aware the maintainer of libsndfile. I think that is Anand 
 Kumria and I do not believe that Anand has any problems with the
 way I have been releasing libsndfile so far and I know him well
 enough that he would say something if I screwed up.

well, its just that statically linked binaries in debian should be omitted by
policy (or, might be non policy compliant). Imagine a security bug in libflac,
debian's security team would have to care about the libflac packages AND
sndfile - duplicate work again.

bye, 
- michael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]