Bug#463907: uncomplete patch of wml-2.0.11/wml_backend/p1_ipp/ipp.src

2008-02-21 Thread Jochen Sprickerhof
Hi,

Nicos patch of ipp.src is not complete. It doesn't delete the created
tempdir. The attached one corrects two minor things as well (adapted
from the sarge package). I haven't looked at the changes in eperl_sys.c
but I think there exists a similar problem.

regards,

Jochen

-- 
diesen tag / begehen / wie einen grund / oder wie ein fest
ohne grund zu einem fest / ohne festen grund
 -- Ernst Jandl
--- ipp.src.org	2008-02-21 20:14:54.0 +0100
+++ ipp.src	2008-02-21 20:15:50.0 +0100
@@ -565,7 +565,6 @@
 #
 #   process the pre-loaded include files
 #
-$tmpdir = $ENV{'TMPDIR'} || '/tmp';
 my $tmpldir = ($ENV{'TMPDIR'} || '/tmp') . '/ipp.XX';
 $tmpdir = mkdtemp($tmpldir) or die Unable to create temporary directory: $!\n;
 $tmpfile = $tmpdir . /ipp.$$.tmp;
@@ -633,11 +632,12 @@
 #   cleanup
 unlink($tmpfile);
 }
+rmdir($tmpdir);
 
 if ($opt_M ne '-'  $opt_o ne '-') {
 #   Write dependencies
 if ($opt_M =~ m|D|) {
-if ($opt_o =~ m|(.*?)\.|) {
+if ($opt_o =~ m|(.*)\.|) {
 $depfile = $1 . '.d';
 }
 else {


Bug#463907: uncomplete patch of wml-2.0.11/wml_backend/p1_ipp/ipp.src

2008-02-21 Thread Nico Golde
Hi Jochen,
* Jochen Sprickerhof [EMAIL PROTECTED] [2008-02-21 20:42]:
 Nicos patch of ipp.src is not complete. It doesn't delete the created
 tempdir.

True but calling this an incomplete patch goes a bit too far 
as the security issue itself is fixed. This is a minor bug 
not having any security impact.

 The attached one corrects two minor things as well (adapted
 from the sarge package). I haven't looked at the changes in eperl_sys.c
 but I think there exists a similar problem.

I politely disagree cause all I did was changing the name of 
the tmpfile, nothing more.
Kind regards
Nico
-- 
Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.


pgpwn5Bx4hGHB.pgp
Description: PGP signature