Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-28 Thread Luca Capello
Hi there!

On Fri, 28 Mar 2008 01:53:31 +0100, Nico Golde wrote:
 That's not the problem, openbox itself is fine, the openbox 
 package just includes an openbox-session binary which 
 doesn't fall in the window manager category but is used as 
 an alternative for such.

My fault, sorry for the noise.  It seems that reading the
apt-listchanges output after a tiring word day is not the best thing to
do...

Thx, bye,
Gismo / Luca


pgppjlX4X7CKv.pgp
Description: PGP signature


Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-27 Thread Luca Capello
found 472829 3.4.6.1-2
thanks

Hello!

On Wed, 26 Mar 2008 19:19:11 +0100, Andrew Lee wrote:
 This package installs openbox-session as x-window-manager which is
 violate debian policy 11.8.4. It's not a window manager, but a desktop
 session.

I'm a simple and rare Openbox user, but from the Openbox main site
(emphasis mine): Openbox is a highly configurable, next generation
bigwindow manager/big with extensive standards support.

At least this is how I see Openbox and why I installed it, am I missing
something?  In this case more than the simple alternative should be
changed, e.g. the package description.

Thx, bye,
Gismo / Luca


pgponrCzh4AWG.pgp
Description: PGP signature


Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-27 Thread Julien Cristau
On Fri, Mar 28, 2008 at 01:09:34 +0100, Luca Capello wrote:

 On Wed, 26 Mar 2008 19:19:11 +0100, Andrew Lee wrote:
  This package installs openbox-session as x-window-manager which is
  violate debian policy 11.8.4. It's not a window manager, but a desktop
  session.
 
 I'm a simple and rare Openbox user, but from the Openbox main site
 (emphasis mine): Openbox is a highly configurable, next generation
 bigwindow manager/big with extensive standards support.
 
 At least this is how I see Openbox and why I installed it, am I missing
 something?  In this case more than the simple alternative should be
 changed, e.g. the package description.
 
openbox-session and openbox are two different things.

Cheers,
Julien



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Re: Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-27 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 notfound 472829 3.4.6.1-2
Bug#472829: openbox-session is not a window manager, but a desktop session.
Bug no longer marked as found in version 3.4.6.1-2.

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-27 Thread Nico Golde
notfound 472829 3.4.6.1-2
thanks

Hi,
* Luca Capello [EMAIL PROTECTED] [2008-03-28 01:17]:
 On Wed, 26 Mar 2008 19:19:11 +0100, Andrew Lee wrote:
  This package installs openbox-session as x-window-manager which is
  violate debian policy 11.8.4. It's not a window manager, but a desktop
  session.
 
 I'm a simple and rare Openbox user, but from the Openbox main site
 (emphasis mine): Openbox is a highly configurable, next generation
 bigwindow manager/big with extensive standards support.
 
 At least this is how I see Openbox and why I installed it, am I missing
 something?  In this case more than the simple alternative should be
 changed, e.g. the package description.

That's not the problem, openbox itself is fine, the openbox 
package just includes an openbox-session binary which 
doesn't fall in the window manager category but is used as 
an alternative for such.
Kind regards
Nico
-- 
Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.


pgpEE73QnDzDj.pgp
Description: PGP signature


Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-26 Thread Andrew Lee
Package: openbox
Severity: serious
Justification: Policy 11.8.4.

This package installs openbox-session as x-window-manager which is
violate debian policy 11.8.4. It's not a window manager, but a desktop
session.

I have read #434497. If you wants to use openbox-session for autostart,
please install it as x-session-manager in debian/openbox.postinst.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-26 Thread Nico Golde
Hi Andrew,
* Andrew Lee [EMAIL PROTECTED] [2008-03-26 19:25]:
 This package installs openbox-session as x-window-manager which is
 violate debian policy 11.8.4. It's not a window manager, but a desktop
 session.
 
 I have read #434497. If you wants to use openbox-session for autostart,
 please install it as x-session-manager in debian/openbox.postinst.

Do I miss anything or is the only thing needed to fix this 
bug:
--- openbox.postinst2008-03-26 19:55:59.0 +0100
+++ openbox.postinst.new2008-03-26 19:56:05.0 +0100
@@ -4,9 +4,9 @@
 
 case $1 in
configure)
-   update-alternatives --install /usr/bin/x-window-manager \
-   x-window-manager /usr/bin/openbox-session 90 --slave \
-   /usr/share/man/man1/x-window-manager.1.gz \
+   update-alternatives --install /usr/bin/x-session-manager \
+   x-session-manager /usr/bin/openbox-session 90 --slave \
+   /usr/share/man/man1/x-ression-manager.1.gz \
x-window-manager.1.gz /usr/share/man/man1/openbox.1.gz
if [ -x /usr/bin/update-menus ]; then update-menus; fi
;;


Kind regards
Nico
-- 
Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.


pgpYMzxSjgAUC.pgp
Description: PGP signature


Processed: Re: Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-26 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 tags 472829 +patch
Bug#472829: openbox-session is not a window manager, but a desktop session.
There were no tags set.
Tags added: patch

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#472829: openbox-session is not a window manager, but a desktop session.

2008-03-26 Thread Andrew Lee
tags 472829 +patch
thanks

Nico Golde wrote:
 Do I miss anything or is the only thing needed to fix this 
 bug:
[skip]

Also need following changes:
- provides: x-session-manager
- create x-window-manager link for openbox
- create x-session-manager link for openbox-session
- remove the wrong openbox-session link from x-window-manager

Please see the attached patch.

-Andrew
diff -u openbox-3.4.6.1/debian/control openbox-3.4.6.1/debian/control
--- openbox-3.4.6.1/debian/control
+++ openbox-3.4.6.1/debian/control
@@ -11,7 +11,7 @@
 
 Package: openbox
 Architecture: any
-Provides: x-window-manager
+Provides: x-window-manager, x-session-manager
 Depends: ${shlibs:Depends}
 Recommends: openbox-themes
 Suggests: obconf, menu, ttf-dejavu, python, libxml2-dev
diff -u openbox-3.4.6.1/debian/openbox.postinst openbox-3.4.6.1/debian/openbox.postinst
--- openbox-3.4.6.1/debian/openbox.postinst
+++ openbox-3.4.6.1/debian/openbox.postinst
@@ -5,9 +5,14 @@
 case $1 in
 	configure)
 		update-alternatives --install /usr/bin/x-window-manager \
-			x-window-manager /usr/bin/openbox-session 90 --slave \
+			x-window-manager /usr/bin/openbox 90 --slave \
 			/usr/share/man/man1/x-window-manager.1.gz \
 			x-window-manager.1.gz /usr/share/man/man1/openbox.1.gz
+		update-alternatives --install /usr/bin/x-session-manager \
+x-session-manager /usr/bin/openbox-session 50 --slave \
+/usr/share/man/man1/x-session-manager.1.gz \
+x-session-manager.1.gz /usr/share/man/man1/openbox-session.1.gz
+
 			if [ -x /usr/bin/update-menus ]; then update-menus; fi
 		;;
 esac
diff -u openbox-3.4.6.1/debian/openbox.prerm openbox-3.4.6.1/debian/openbox.prerm
--- openbox-3.4.6.1/debian/openbox.prerm
+++ openbox-3.4.6.1/debian/openbox.prerm
@@ -3,10 +3,11 @@
 set -e
 
 case $1 in
-	remove)
-		update-alternatives --remove x-window-manager /usr/bin/openbox
-		rm -f /var/lib/openbox/debian-menu.xml
-		;;
+remove)
+	update-alternatives --remove x-window-manager /usr/bin/openbox
+	update-alternatives --remove x-session-manager /usr/bin/openbox-session
+	rm -f /var/lib/openbox/debian-menu.xml
+	;;
 esac
 
 #DEBHELPER#
--- openbox-3.4.6.1.orig/debian/openbox.preinst
+++ openbox-3.4.6.1/debian/openbox.preinst
@@ -0,0 +1,9 @@
+#!/bin/sh -e
+
+if [ $1 = upgrade ]; then
+update-alternatives --remove x-window-manager /usr/bin/openbox-session
+fi
+
+#DEBHELPER#
+
+exit 0