Bug#486985: libgraphicsmagick1-dev: does not depend on everything mentioned by GraphicsMagick-config --libs

2008-06-28 Thread Simon McVittie
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

reassign 486985 libgraphicsmagick1-dev
tags 486985 + patch
thanks

/usr/bin/GraphicsMagick-config --libs outputs:

- -lGraphicsMagick -llcms -ltiff -lfreetype -ljasper
- -ljpeg -lpng -lwmflite -lXext -lSM -lICE -lX11 -lbz2 -lxml2 -lz -lm
- -lpthread

but libgraphicsmagick1-dev does not depend on libxext-dev, causing #486985.
Neither does it depend on libsm-dev or libice-dev, although those seem to be
pulled in indirectly by other packages.

(The drawtiming package, on which this bug was filed, actually runs
GraphicsMagick++-config, but that's just a wrapper for GraphicsMagick-config,
so I'm filing this against the C library rather than the C++ one.)

Here's a trivial patch; I'll prepare a delayed NMU.

Regards,
Simon (at the Cambridge BSP)

- --- graphicsmagick-1.1.11/debian/control
+++ graphicsmagick-1.1.11/debian/control
@@ -57,7 +57,7 @@
 Package: libgraphicsmagick1-dev
 Architecture: any
 Section: libdevel
- -Depends: libgraphicsmagick1 (= ${binary:Version}), libjpeg62-dev, 
libjasper-dev, liblcms1-dev, libwmf-dev, libx11-dev, x11proto-core-dev | x-dev, 
libxml2-dev, libfreetype6-dev, libtiff4-dev, libc6-dev, zlib1g-dev | libz-dev, 
libpng12-dev, libexif-dev, libbz2-dev
+Depends: libgraphicsmagick1 (= ${binary:Version}), libjpeg62-dev, 
libjasper-dev, liblcms1-dev, libwmf-dev, libx11-dev, x11proto-core-dev | x-dev, 
libxml2-dev, libfreetype6-dev, libtiff4-dev, libc6-dev, zlib1g-dev | libz-dev, 
libpng12-dev, libexif-dev, libbz2-dev, libsm-dev, libice-dev, libxext-dev
 Suggests: graphicsmagick
 Provides: libgraphicsmagick-dev
 Conflicts: libgraphicsmagick-dev

- -- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (101, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
-BEGIN PGP SIGNATURE-

iD8DBQFIZl8QWSc8zVUw7HYRAlNsAJ9A+gYuJvMmGnA7u4PKTNLr+FOkHACgxOqd
Ojecn/U0nSY0gQc27zh4cso=
=v1fS
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#486985: libgraphicsmagick1-dev: does not depend on everything mentioned by GraphicsMagick-config --libs

2008-06-28 Thread Daniel Kobras
clone 486985 -1
severity -1 wishlist
retitle -1 drawtiming: Please use pkg-config instead of GraphicsMagick-config.
reassign -1 drawtiming
thanks

On Sat, Jun 28, 2008 at 04:56:09PM +0100, Simon McVittie wrote:
 /usr/bin/GraphicsMagick-config --libs outputs:
 
 -lGraphicsMagick -llcms -ltiff -lfreetype -ljasper
 -ljpeg -lpng -lwmflite -lXext -lSM -lICE -lX11 -lbz2 -lxml2 -lz -lm
 -lpthread
 
 but libgraphicsmagick1-dev does not depend on libxext-dev, causing #486985.
 Neither does it depend on libsm-dev or libice-dev, although those seem to be
 pulled in indirectly by other packages.

This is quite odd, as the libgraphicsmagick1-dev Depends line more or
less duplicates the source package's Build-Depends. Might be stray
dependencies that get picked up if the respective packages happen to be
installed at build time. The patch you sent in certainly isn't wrong,
but it's not the full story, either. The respective packages ought to be
added to Build-Depends as well, at least. I'll investigate.

 (The drawtiming package, on which this bug was filed, actually runs
 GraphicsMagick++-config, but that's just a wrapper for GraphicsMagick-config,
 so I'm filing this against the C library rather than the C++ one.)

GraphicsMagick-config (just like Magick-config) historically cannot
distinguish between shared and static linkage. Hence the overly long
--libs line, and consequently the many Depends (rather than Recommends
or Suggests) in the -dev package. Therefore, I'd advise against using
the legacy GraphicsMagick-config, and prefer pkg-config instead, which
has this problem fixed. Wesley, if possible, please switch from
GraphicsMagick-config to pkg-config in the drawtiming package. This will
not only avoid graphicsmagick bug #486985, but also give you a much
shorter Depends line.

Thanks,

Daniel.




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#486985: libgraphicsmagick1-dev: does not depend on everything mentioned by GraphicsMagick-config --libs

2008-06-28 Thread Simon McVittie
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Sat, 28 Jun 2008 at 22:21:09 +0200, Daniel Kobras wrote:
 The patch you sent in certainly isn't wrong,
 but it's not the full story, either. The respective packages ought to be
 added to Build-Depends as well, at least. I'll investigate.

Well, it worked for me... building my NMU with sbuild -As on a
mostly clean chroot (i.e. no X-related packages except the build
dependencies) seemed to work fine. Perhaps they're mentioned by the -config
script but not actually needed?

Let me know if you want me to cancel my NMU; otherwise, it'll land in 7 days,
unless you've uploaded a higher version by then. I'm in #debian-bugs on
OFTC (as smcv) if you want to discuss anything.

Simon
-BEGIN PGP SIGNATURE-

iD8DBQFIZqPIWSc8zVUw7HYRAvUjAJ458/DQB8BY5cUiewR28t3E/35+ngCg8Cb+
rVdPZ51Cg3CRO3ZDBMqarXU=
=WPZq
-END PGP SIGNATURE-



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]