Bug#493407: marked as done (lsb-base: bashism in init-functions + kills networking on reboot on systems where /bin/sh = /bin/bash)
Your message dated Mon, 04 Aug 2008 14:32:18 + with message-id [EMAIL PROTECTED] and subject line Bug#493505: fixed in lsb 3.2-18 has caused the Debian Bug report #493505, regarding lsb-base: bashism in init-functions + kills networking on reboot on systems where /bin/sh = /bin/bash to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 493505: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493505 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems ---BeginMessage--- Package: lsb-base Version: 3.2-16 Severity: grave There is a bashism in /usr/lib/init-functions that breaks some init scripts. For example checkroot.sh breaks when system is running on battery power in log_warning_msg, this causes root fs munted read-only, this also cases strange bugs after. So severity is grave. The problem is that log_warning_msg does the following call: log_end_msg -1 log_end_msg contains at the end of the function: return $1 this gives: return -1 That works in bash and zsh, for example. But it does not work with dash. IEEE Std 1003.1, 2004 Edition says this about return built-in: EXIT STATUS The value of the special parameter '?' shall be set to n, an _unsigned_ decimal integer, or to the exit status of the last command executed if n is not specified (see http://www.opengroup.org/onlinepubs/95399/utilities/return.html) So dash is posix-compliant. Problem can be solved by using 255 instead of -1. -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.27-rc1 (SMP w/2 CPU cores; PREEMPT) Locale: LANG=uk_UA.UTF-8, LC_CTYPE=uk_UA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lsb-base depends on: ii ncurses-bin 5.6+20080713-1 terminal-related programs and man ii sed 4.1.5-8The GNU sed stream editor lsb-base recommends no packages. lsb-base suggests no packages. -- debconf-show failed ---End Message--- ---BeginMessage--- Source: lsb Source-Version: 3.2-18 We believe that the bug you reported is fixed in the latest version of lsb, which is due to be installed in the Debian FTP archive: lsb-base_3.2-18_all.deb to pool/main/l/lsb/lsb-base_3.2-18_all.deb lsb-core_3.2-18_i386.deb to pool/main/l/lsb/lsb-core_3.2-18_i386.deb lsb-cxx_3.2-18_i386.deb to pool/main/l/lsb/lsb-cxx_3.2-18_i386.deb lsb-desktop_3.2-18_i386.deb to pool/main/l/lsb/lsb-desktop_3.2-18_i386.deb lsb-graphics_3.2-18_i386.deb to pool/main/l/lsb/lsb-graphics_3.2-18_i386.deb lsb-languages_3.2-18_i386.deb to pool/main/l/lsb/lsb-languages_3.2-18_i386.deb lsb-multimedia_3.2-18_i386.deb to pool/main/l/lsb/lsb-multimedia_3.2-18_i386.deb lsb-printing_3.2-18_i386.deb to pool/main/l/lsb/lsb-printing_3.2-18_i386.deb lsb-qt4_3.2-18_i386.deb to pool/main/l/lsb/lsb-qt4_3.2-18_i386.deb lsb-release_3.2-18_all.deb to pool/main/l/lsb/lsb-release_3.2-18_all.deb lsb_3.2-18.dsc to pool/main/l/lsb/lsb_3.2-18.dsc lsb_3.2-18.tar.gz to pool/main/l/lsb/lsb_3.2-18.tar.gz lsb_3.2-18_all.deb to pool/main/l/lsb/lsb_3.2-18_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Chris Lawrence [EMAIL PROTECTED] (supplier of updated lsb package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Mon, 04 Aug 2008 02:31:03 -0500 Source: lsb Binary: lsb-core lsb-graphics lsb-cxx lsb-desktop lsb-qt4 lsb-languages lsb-multimedia lsb-printing lsb lsb-base lsb-release Architecture: source all i386 Version: 3.2-18 Distribution: unstable Urgency: low Maintainer: Chris Lawrence [EMAIL PROTECTED] Changed-By: Chris Lawrence [EMAIL PROTECTED] Description: lsb- Linux Standard Base 3.2 support package lsb-base - Linux Standard Base 3.2 init script functionality lsb-core - Linux Standard Base 3.2 core support package lsb-cxx- Linux Standard Base 3.2 C++ support package lsb-desktop - Linux Standard Base 3.2 Desktop support package lsb-graphics - Linux Standard Base 3.2 graphics support package lsb-languages - Linux Standard Base 3.2 Runtime Languages package
Bug#493407: marked as done (lsb-base: bashism in init-functions + kills networking on reboot on systems where /bin/sh = /bin/bash)
Hi Chris, Sorry to be a pain but I'm still not entirely sure this is all fixed now. It fixes the case I saw in /etc/init.d/networking but log_failure_msg still returns a failure code. Is that by design? It didn't use to be the case in -15. If I extend the lsb-test.sh to add: log_success_msg Success log_failure_msg Failure then I get: [EMAIL PROTECTED] ~/lsb]$ ./lsb-test.sh lsb-3.2-18 Importing lsb-3.2-18/init-functions Only a warning (warning). Success. Failure failed! [EMAIL PROTECTED] ~/lsb]$ ./lsb-test.sh lsb-3.2-15 Importing lsb-3.2-15/init-functions Only a warning Success Failure OK! [EMAIL PROTECTED] ~/lsb]$ I think you probably want all three of them to return 0 no matter what was passed unless there was an error producing the message somehow (is that possible?). That way they'll be safe in any script with set -e. You might want to publicise to a wider audience your changelog about not using these functions though if they aren't meant to be used. I hadn't noticed that -17 was ok if the terminal was colour (I was testing under screen so something must have confused it into thinking it wasn't colour capable). Simon. -- Just another wannabie | Did someone say they wanted | Just another fool --+ toast? -- Talkie Toaster+--- This message was brought to you by the letter L and the number 3. htag.pl 0.0.24 -- http://www.earth.li/projectpurple/progs/htag.html signature.asc Description: Digital signature
Bug#493407: marked as done (lsb-base: bashism in init-functions + kills networking on reboot on systems where /bin/sh = /bin/bash)
Your message dated Mon, 04 Aug 2008 00:32:03 + with message-id [EMAIL PROTECTED] and subject line Bug#493505: fixed in lsb 3.2-17 has caused the Debian Bug report #493505, regarding lsb-base: bashism in init-functions + kills networking on reboot on systems where /bin/sh = /bin/bash to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 493505: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493505 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems ---BeginMessage--- Package: lsb-base Version: 3.2-16 Severity: grave There is a bashism in /usr/lib/init-functions that breaks some init scripts. For example checkroot.sh breaks when system is running on battery power in log_warning_msg, this causes root fs munted read-only, this also cases strange bugs after. So severity is grave. The problem is that log_warning_msg does the following call: log_end_msg -1 log_end_msg contains at the end of the function: return $1 this gives: return -1 That works in bash and zsh, for example. But it does not work with dash. IEEE Std 1003.1, 2004 Edition says this about return built-in: EXIT STATUS The value of the special parameter '?' shall be set to n, an _unsigned_ decimal integer, or to the exit status of the last command executed if n is not specified (see http://www.opengroup.org/onlinepubs/95399/utilities/return.html) So dash is posix-compliant. Problem can be solved by using 255 instead of -1. -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.27-rc1 (SMP w/2 CPU cores; PREEMPT) Locale: LANG=uk_UA.UTF-8, LC_CTYPE=uk_UA.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lsb-base depends on: ii ncurses-bin 5.6+20080713-1 terminal-related programs and man ii sed 4.1.5-8The GNU sed stream editor lsb-base recommends no packages. lsb-base suggests no packages. -- debconf-show failed ---End Message--- ---BeginMessage--- Source: lsb Source-Version: 3.2-17 We believe that the bug you reported is fixed in the latest version of lsb, which is due to be installed in the Debian FTP archive: lsb-base_3.2-17_all.deb to pool/main/l/lsb/lsb-base_3.2-17_all.deb lsb-core_3.2-17_i386.deb to pool/main/l/lsb/lsb-core_3.2-17_i386.deb lsb-cxx_3.2-17_i386.deb to pool/main/l/lsb/lsb-cxx_3.2-17_i386.deb lsb-desktop_3.2-17_i386.deb to pool/main/l/lsb/lsb-desktop_3.2-17_i386.deb lsb-graphics_3.2-17_i386.deb to pool/main/l/lsb/lsb-graphics_3.2-17_i386.deb lsb-languages_3.2-17_i386.deb to pool/main/l/lsb/lsb-languages_3.2-17_i386.deb lsb-multimedia_3.2-17_i386.deb to pool/main/l/lsb/lsb-multimedia_3.2-17_i386.deb lsb-printing_3.2-17_i386.deb to pool/main/l/lsb/lsb-printing_3.2-17_i386.deb lsb-qt4_3.2-17_i386.deb to pool/main/l/lsb/lsb-qt4_3.2-17_i386.deb lsb-release_3.2-17_all.deb to pool/main/l/lsb/lsb-release_3.2-17_all.deb lsb_3.2-17.dsc to pool/main/l/lsb/lsb_3.2-17.dsc lsb_3.2-17.tar.gz to pool/main/l/lsb/lsb_3.2-17.tar.gz lsb_3.2-17_all.deb to pool/main/l/lsb/lsb_3.2-17_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Chris Lawrence [EMAIL PROTECTED] (supplier of updated lsb package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Sun, 03 Aug 2008 10:15:45 -0500 Source: lsb Binary: lsb-core lsb-graphics lsb-cxx lsb-desktop lsb-qt4 lsb-languages lsb-multimedia lsb-printing lsb lsb-base lsb-release Architecture: source all i386 Version: 3.2-17 Distribution: unstable Urgency: low Maintainer: Chris Lawrence [EMAIL PROTECTED] Changed-By: Chris Lawrence [EMAIL PROTECTED] Description: lsb- Linux Standard Base 3.2 support package lsb-base - Linux Standard Base 3.2 init script functionality lsb-core - Linux Standard Base 3.2 core support package lsb-cxx- Linux Standard Base 3.2 C++ support package lsb-desktop - Linux Standard Base 3.2 Desktop support package lsb-graphics - Linux Standard Base 3.2 graphics support package lsb-languages - Linux Standard Base 3.2 Runtime Languages package
