Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
On Thu, Nov 20, 2008 at 08:59:14PM -0600, Kumar Appaiah wrote: I would like to have emacspeak-28.0-4 and emacspeak-ss-1.12-2 unblocked. Failing that, I'll try to backport the debconf changes to the 26.0 package. Thanks for the explanation, James. I guess it's up to the release team to decide the next course of action. 356 files changed, 46727 insertions(+), 12432 deletions(-) Sorry, this'll need a t-p-u upload. Neil -- I've just won one million euros! Now I can spend it on that viagra stock options. I'd better contact the Nigerian prince I've just made friends with first though. I wonder if he can send me a pdf invoice... -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
Quoting Neil McGovern ([EMAIL PROTECTED]): On Thu, Nov 20, 2008 at 08:59:14PM -0600, Kumar Appaiah wrote: I would like to have emacspeak-28.0-4 and emacspeak-ss-1.12-2 unblocked. Failing that, I'll try to backport the debconf changes to the 26.0 package. Thanks for the explanation, James. I guess it's up to the release team to decide the next course of action. 356 files changed, 46727 insertions(+), 12432 deletions(-) Sorry, this'll need a t-p-u upload. So, James, I think you're now back to the solution I was originally suggesting: drop the call to emacspeakconfig in the package postinst script. Maybe not optimal but much much less invasive than introducing debconf at this moment of the release process. signature.asc Description: Digital signature
Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
Kumar - Fixes for the symlink attacks (#496431) and the info file syntax problem (#500638) are fine. However, I do have a problem with this one: * Use Christian Perrier's patch for stopping the call to emacspeakconfig. (Closes: #502761) The purpose of the emacspeak package is to make emacs accessible to a blind user. I think configuration during installation is particularly important for this package. Without configuration, the user is left with a broken package. Ordinarily that would not be a serious problem - he only has to read the emacspeak.info documentation and edit /etc/emacspeak.conf, or else read the comments in README.Debian and run emacspeakconfig. However, in this case we may have broken the tool he would use for those tasks. With 26.0-3, he may be annoyed at answering configuration questions while packages are being unpacked, but he finishes with a working program. The emacspeak-28.0-4 package: - has all the above mentioned bugs fixed - is configured using debconf - has an extra year's worth of upstream development. I would like to have emacspeak-28.0-4 and emacspeak-ss-1.12-2 unblocked. Failing that, I'll try to backport the debconf changes to the 26.0 package. - Jim Van Zandt Date: Wed, 19 Nov 2008 21:33:28 -0600 From: Kumar Appaiah [EMAIL PROTECTED] Cc: Christian Perrier [EMAIL PROTECTED] On Wed, Nov 19, 2008 at 10:09:15PM -0500, James R. Van Zandt wrote: Yes, I realize that my first package of version 28.0 missed the deadline for Lenny by a few days. The functional difference from version 26.0 is not great. (Dr. Raman just increments the version number every six months.) However, that does make it a year newer than the version currently in testing. Thanks James. While you are at it, I hope you didn't mind my upload to testing to fix a few bugs: http://packages.qa.debian.org/e/emacspeak/news/20081112T004707Z.html Do voice your concerns if you have any, but I did check with some emacspeak users before actually going ahead with the uploads for the RC bug fixes. Thanks! Kumar --=20 Kumar Appaiah -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
On Thu, Nov 20, 2008 at 09:48:55PM -0500, James R. Van Zandt wrote: However, I do have a problem with this one: * Use Christian Perrier's patch for stopping the call to emacspeakconfig. (Closes: #502761) The purpose of the emacspeak package is to make emacs accessible to a blind user. I think configuration during installation is particularly important for this package. Without configuration, the user is left with a broken package. Ordinarily that would not be a serious problem - he only has to read the emacspeak.info documentation and edit /etc/emacspeak.conf, or else read the comments in README.Debian and run emacspeakconfig. However, in this case we may have broken the tool he would use for those tasks. With 26.0-3, he may be annoyed at answering configuration questions while packages are being unpacked, but he finishes with a working program. The emacspeak-28.0-4 package: - has all the above mentioned bugs fixed - is configured using debconf - has an extra year's worth of upstream development. I would like to have emacspeak-28.0-4 and emacspeak-ss-1.12-2 unblocked. Failing that, I'll try to backport the debconf changes to the 26.0 package. Thanks for the explanation, James. I guess it's up to the release team to decide the next course of action. Kumar -- Kumar Appaiah -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
I have uploaded a new package with debconf support: emacspeak_28.0-4_all.deb. I think it is working correctly. However this is the first time I've used debconf, and I may have set some kind of record for complexity. I'd appreciate someone checking it. Assuming it checks out okay, I'd like to see that package in Lenny. Yes, I realize that my first package of version 28.0 missed the deadline for Lenny by a few days. The functional difference from version 26.0 is not great. (Dr. Raman just increments the version number every six months.) However, that does make it a year newer than the version currently in testing. - Jim Van Zandt Date: Sat, 25 Oct 2008 13:35:44 +0200 From: Christian Perrier [EMAIL PROTECTED] MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol=application/pgp-signature; boundary=jsrFa/5v3cIbBmG8 Content-Disposition: inline Resent-Sender: Debian BTS [EMAIL PROTECTED] --jsrFa/5v3cIbBmG8 Content-Type: multipart/mixed; boundary=IihjUyvzd0n5Ehsu Content-Disposition: inline --IihjUyvzd0n5Ehsu Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable tags 502761 patch thanks Introducing debconf support in a package that doesn't use it already is IO too invasive and risking breakage. So, I recommend simply commenting the call to emacspeakconfig in postinst as of now so that this package can be released for lenny. A patch is attached. I plan to build an NMU unless the maintainer is OK to upload himself...or find another solution (but, again, hasty debconf introduction would seem too risky for me)=A0? --=20 --IihjUyvzd0n5Ehsu Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename=emacspeak.patch Content-Transfer-Encoding: quoted-printable diff -Nru emacspeak-26.0.old/debian/postinst emacspeak-26.0/debian/postinst --- emacspeak-26.0.old/debian/postinst 2008-10-25 13:29:00.194881985 +0200 +++ emacspeak-26.0/debian/postinst 2008-10-25 13:30:00.242729827 +0200 @@ -46,7 +46,9 @@ fi fi =20 -emacspeakconfig -i +# Commented as this implies prompting without using +# debconf. See #502761 +# emacspeakconfig -i =20 # dh_installdeb will replace this with shell code automatically # generated by other debhelper scripts. diff -Nru emacspeak-26.0.old/debian/README.Debian emacspeak-26.0/debian/REA= DME.Debian --- emacspeak-26.0.old/debian/README.Debian 2008-10-25 13:29:00.194881985 += 0200 +++ emacspeak-26.0/debian/README.Debian 2008-10-25 13:31:18.994729859 +0200 @@ -13,6 +13,9 @@ gets configuration parameters from /etc/emacspeak.conf and starts emacs with emacspeak support. =20 +Before it is used, Emacspeak must be configured by root, by running +'emacspeakconfig -i'. + Several flavors of emacs may be installed at the same time (emacs20, emacs21, xemacs21, etc.). In accordance with the Debian emacs policy, emacspeak is byte-compiled separately for each supported flavor - @@ -85,3 +88,5 @@ =20 James R. Van Zandt [EMAIL PROTECTED], Mon Jan 30 21:36:59 EST 2006 =20 + + -- Christian Perrier [EMAIL PROTECTED], Sat, 25 Oct 2008 13:31:18 z --IihjUyvzd0n5Ehsu-- --jsrFa/5v3cIbBmG8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: Digital signature Content-Disposition: inline -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkkDBIoACgkQ1OXtrMAUPS2VGQCeKX3EntQefSRg0eyyFt4IAsJr 2vcAoJlJ5pHWvO3ZtBdDbM0EcddZd69z =9p33 -END PGP SIGNATURE- --jsrFa/5v3cIbBmG8-- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
Quoting James R. Van Zandt ([EMAIL PROTECTED]): I have uploaded a new package with debconf support: emacspeak_28.0-4_all.deb. I think it is working correctly. However this is the first time I've used debconf, and I may have set some kind of record for complexity. I'd appreciate someone checking it. Issues: - introducing debconf templates without a prior review by debian-l10n-english is discouraged - doing this without any prior call for translations is discouraged as well. So, now, I think tha package, if you uploaded it to unstable, should enter the Smith review process (see the wiki.debian.org page about Smith reviews, that basically cover the above points). I would vote against the package entering lenny if that process hasn't been completed (which will require another upload once the review is done and translations are included). I can take care of the review but I really don't like doing this in a hurry signature.asc Description: Digital signature
Bug#502761: I suggest removing the call to emacspeakconfig and add a mention in README.Debian
tags 502761 patch thanks Introducing debconf support in a package that doesn't use it already is IO too invasive and risking breakage. So, I recommend simply commenting the call to emacspeakconfig in postinst as of now so that this package can be released for lenny. A patch is attached. I plan to build an NMU unless the maintainer is OK to upload himself...or find another solution (but, again, hasty debconf introduction would seem too risky for me) ? -- diff -Nru emacspeak-26.0.old/debian/postinst emacspeak-26.0/debian/postinst --- emacspeak-26.0.old/debian/postinst 2008-10-25 13:29:00.194881985 +0200 +++ emacspeak-26.0/debian/postinst 2008-10-25 13:30:00.242729827 +0200 @@ -46,7 +46,9 @@ fi fi -emacspeakconfig -i +# Commented as this implies prompting without using +# debconf. See #502761 +# emacspeakconfig -i # dh_installdeb will replace this with shell code automatically # generated by other debhelper scripts. diff -Nru emacspeak-26.0.old/debian/README.Debian emacspeak-26.0/debian/README.Debian --- emacspeak-26.0.old/debian/README.Debian 2008-10-25 13:29:00.194881985 +0200 +++ emacspeak-26.0/debian/README.Debian 2008-10-25 13:31:18.994729859 +0200 @@ -13,6 +13,9 @@ gets configuration parameters from /etc/emacspeak.conf and starts emacs with emacspeak support. +Before it is used, Emacspeak must be configured by root, by running +'emacspeakconfig -i'. + Several flavors of emacs may be installed at the same time (emacs20, emacs21, xemacs21, etc.). In accordance with the Debian emacs policy, emacspeak is byte-compiled separately for each supported flavor - @@ -85,3 +88,5 @@ James R. Van Zandt [EMAIL PROTECTED], Mon Jan 30 21:36:59 EST 2006 + + -- Christian Perrier [EMAIL PROTECTED], Sat, 25 Oct 2008 13:31:18 z signature.asc Description: Digital signature