Bug#520499: lsb-base upgrade breaks init scripts at least of gdm

2009-03-20 Thread Norbert Preining
Package: lsb-base
Version: 3.2-21
Severity: critical
Justification: breaks unrelated software

The update to lsb 3.2-21 did break gdm init scripts. I now get that
$ /etc/init.d/gdm start
Starting GNOME Display Manager: gdm /sbin/start-stop-daemon: Unable to 
chdir() to '/root' (No such file or directory)

And in fact the problem comes from /lib/lsb/init-functions.

Downgrading to -20 fixed that problem.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.29-rc8 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lsb-base depends on:
ii  ncurses-bin   5.7+20090314-1 terminal-related programs and man 
ii  sed   4.1.5-8The GNU sed stream editor

lsb-base recommends no packages.

lsb-base suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#520499: lsb-base upgrade breaks init scripts at least of gdm

2009-03-20 Thread Pablo López Martín
Package: lsb-core
Followup-For: Bug #520499

Its a bug in /lib/lsb/init-functions
start_daemon function in /lib/lsb/init-functions has a bug in 3.2-21.

I changed:

args=--start --chdir '$PWD' --nicelevel $nice --quiet --oknodo

to:

args=--start --chdir $PWD --nicelevel $nice --quiet --oknodo

and it works. Attaching the patch.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lsb-core depends on:
ii  alien  8.74  convert and install rpm and
other
ii  at 3.1.10.2  Delayed job execution and batch
pr
ii  bc 1.06.94-3 The GNU bc arbitrary precision
cal
ii  binutils   2.19.1-1  The GNU assembler, linker and
bina
ii  bsd-mailx [mailx]  8.1.2-0.20081101cvs-2 A simple mail user agent
ii  bsdmainutils   6.1.10collection of more utilities
from
ii  bsdutils   1:2.13.1.1-1  Basic utilities from
4.4BSD-Lite
ii  cpio   2.9.90-3  GNU cpio -- a program to manage
ar
ii  cron   3.0pl1-105management of regular
background p
ii  cups-bsd [lpr] 1.3.9-15  Common UNIX Printing System(tm)
-
ii  cups-client1.3.9-15  Common UNIX Printing System(tm)
-
ii  debconf [debconf-2 1.5.26Debian configuration management
sy
ii  ed 0.7-3 The classic unix line editor
ii  exim4  4.69-9metapackage to ease Exim MTA
(v4)
ii  exim4-daemon-light 4.69-9lightweight Exim MTA (v4)
daemon
ii  file   4.26-2Determines file type using
magic
ii  libc6  2.9-6 GNU C Library: Shared libraries
ii  libc6-dev [libc-de 2.9-6 GNU C Library: Development
Librari
ii  libncurses55.7+20090314-1shared libraries for terminal
hand
ii  libpam0g   1.0.1-7   Pluggable Authentication
Modules l
ii  locales2.9-6 GNU C Library: National
Language (
ii  lsb-base   3.2-21Linux Standard Base 3.2 init
scrip
ii  lsb-release3.2-21Linux Standard Base version
report
ii  m4 1.4.11-1  a macro processing language
ii  make   3.81-5The GNU version of the make
util
ii  man-db 2.5.5-1   on-line manual pager
ii  mawk   1.3.3-14  a pattern scanning and text
proces
ii  ncurses-term   5.7+20090314-1additional terminal type
definitio
ii  passwd 1:4.1.1-6 change and administer password
and
ii  patch  2.5.9-5   Apply a diff file to an
original
ii  pax1:1.5-16  Portable Archive Interchange
ii  procps 1:3.2.7-11/proc file system utilities
ii  psmisc 22.6-1Utilities that use the proc
filesy
ii  rsync  3.0.5-1   fast remote file copy program
(lik
ii  zlib1g [libz1] 1:1.2.3.3.dfsg-13 compression library - runtime

lsb-core recommends no packages.

lsb-core suggests no packages.

-- debconf information:
  lsb/shadowconfig: true
diff -crB notfixed/init-functions fixed/init-functions
*** notfixed/init-functions	2009-03-20 15:32:28.0 +0100
--- fixed/init-functions	2009-03-20 15:32:57.0 +0100
***
*** 49,55 
  
  exec=$1; shift
  
! args=--start --chdir '$PWD' --nicelevel $nice --quiet --oknodo
  if [ $force = 1 ]; then
  /sbin/start-stop-daemon $args --startas $exec --pidfile /dev/null -- $@
  elif [ $pidfile ]; then
--- 49,55 
  
  exec=$1; shift
  
! args=--start --chdir $PWD --nicelevel $nice --quiet --oknodo
  if [ $force = 1 ]; then
  /sbin/start-stop-daemon $args --startas $exec --pidfile /dev/null -- $@
  elif [ $pidfile ]; then


Bug#520499: lsb-base upgrade breaks init scripts at least of gdm

2009-03-20 Thread Sven Hartge
Pablo López Martín wrote:

 Its a bug in /lib/lsb/init-functions
 start_daemon function in /lib/lsb/init-functions has a bug in 3.2-21.

 I changed:

 args=--start --chdir '$PWD' --nicelevel $nice --quiet --oknodo

 to:

 args=--start --chdir $PWD --nicelevel $nice --quiet --oknodo

 and it works. Attaching the patch.

Yes, this works, but breaks horribly if there are any whitespace 
characters inside $PWD because you forgot to quote the  inside the 
already -enclosed string.

Untested:

args=--start --chdir \$PWD\ --nicelevel $nice --quiet --oknodo 

Grüße,
Sven.



--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#520499: lsb-base upgrade breaks init scripts at least of gdm

2009-03-20 Thread Chris Lawrence
Turns out that the only solution that seems to work with all cases
(including directories w/spaces) is to move the --chdir $PWD part
into each of the start-stop-daemon calls rather than embedding it in
$args.  3.2-22, uploading now, includes this fix.

Thanks to all those who took time to try to figure this one out.
Shell quoting rules are a black art to say the least...


Chris



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#520499: lsb-base upgrade breaks init scripts at least of gdm

2009-03-20 Thread Julien Cristau
On Fri, 2009-03-20 at 16:05 +0100, Pablo López Martín wrote:
 Package: lsb-core
 Followup-For: Bug #520499
 
 Its a bug in /lib/lsb/init-functions
 start_daemon function in /lib/lsb/init-functions has a bug in 3.2-21.
 
 I changed:
 
 args=--start --chdir '$PWD' --nicelevel $nice --quiet --oknodo
 
 to:
 
 args=--start --chdir $PWD --nicelevel $nice --quiet --oknodo
 
 and it works. Attaching the patch.

That patch is broken.

Cheers,
Julien



--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org