Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors
tags 521969 + confirmed
forwarded 521969 http://rt.cpan.org/Public/Bug/Display.html?id=44704
thanks
On Mon, 30 Mar 2009 17:53:43 -0700, Daniel Schepler wrote:
Package: libdbd-pg-perl
Version: 2.11.7-1
Severity: serious
From my pbuilder build log:
...
t/99_perlcritic.#
# File: Pg.pm (line 157)
# Vio: Package DBD::Pg::dr does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::dr;
Thanks, the tests still fail with 2.12.0.
I've forwarded the bug upstream and I'll turn off the Perl::Critic
tests in debian/rules for the time being.
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`-NP: Eagles
signature.asc
Description: Digital signature
Processed: Re: Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors
Processing commands for cont...@bugs.debian.org: tags 521969 + confirmed Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors Tags were: pending Tags added: confirmed forwarded 521969 http://rt.cpan.org/Public/Bug/Display.html?id=44704 Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors Noted your statement that Bug has been forwarded to http://rt.cpan.org/Public/Bug/Display.html?id=44704. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors
Perl::Critic is an author test. Sometimes authors may write tests that
are broken and not bother to fix them, because they're run only by
authors. Likely the author saw those failures while building and chose
to ignore them for one reason or another. A fix would be to provide a
perlcriticrc file which can explicitly exclude those tests, but that's
all we can do. the problem is, really, upstream.
If the test is disabled it should build fine, and not really harm
program functionality. I'm not sure of the specifics of writing DBD
drivers, so perhaps those class names are required by the particular
driver interface.
Still, I recommend just packaging the module and skipping that test.
It would be simple to add a plan skip all to the top...
On Tue, Mar 31, 2009 at 12:04 PM, gregor herrmann gre...@debian.org wrote:
tags 521969 + confirmed
forwarded 521969 http://rt.cpan.org/Public/Bug/Display.html?id=44704
thanks
On Mon, 30 Mar 2009 17:53:43 -0700, Daniel Schepler wrote:
Package: libdbd-pg-perl
Version: 2.11.7-1
Severity: serious
From my pbuilder build log:
...
t/99_perlcritic.#
# File: Pg.pm (line 157)
# Vio: Package DBD::Pg::dr does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::dr;
Thanks, the tests still fail with 2.12.0.
I've forwarded the bug upstream and I'll turn off the Perl::Critic
tests in debian/rules for the time being.
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`- NP: Eagles
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAknSPxcACgkQOzKYnQDzz䡵ည䯅ꮴ㴖Ṳ䢹慴ᦴ�
L48AoPVh0drvqkaVbGNhsj8HgxHoujGH
=FAni
-END PGP SIGNATURE-
___
pkg-perl-maintainers mailing list
pkg-perl-maintain...@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-perl-maintainers
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors
Package: libdbd-pg-perl
Version: 2.11.7-1
Severity: serious
From my pbuilder build log:
...
t/99_perlcritic.#
# File: Pg.pm (line 157)
# Vio: Package DBD::Pg::dr does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::dr;
#
#
# File: Pg.pm (line 235)
# Vio: Package DBD::Pg::db does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::db;
...
# File: t/dbdpg_test_setup.pl (line 528)
# Vio: Reused variable name in lexical scope: $SQL
# Policy: Variables::ProhibitReusedNames
# Source: my $SQL = q{
#
# Failed test 'Failed Perl::Critic tests for file t/dbdpg_test_setup.pl: 4'
# at t/99_perlcritic.t line 235.
# Looks like you failed 8 tests of 434.
dubious
Test returned status 8 (wstat 2048, 0x800)
DIED. FAILED tests 411-412, 418-419, 425, 428, 430, 433
Failed 8/434 tests, 98.16% okay
t/99_podok
t/99_spellcheck.skipped
all skipped: Set the environment variable TEST_SPELL to enable this test
t/99_yaml...ok
t/99cleanup.Removing test database directory
ok
1/1 skipped: various reasons
Failed Test Stat Wstat Total Fail List of Failed
---
t/99_perlcritic.t8 2048 4348 411-412 418-419 425 428 430 433
13 tests and 1 subtest skipped.
Failed 1/19 test scripts. 8/576 subtests failed.
Files=19, Tests=576, 33 wallclock secs (32.34 cusr + 0.46 csys = 32.80 CPU)
Failed 1/19 test programs. 8/576 subtests failed.
make[1]: *** [test_dynamic] Error 255
make[1]: Leaving directory `/tmp/buildd/libdbd-pg-perl-2.11.7'
dh_auto_test: make returned exit code 2
make: *** [build-stamp] Error 1
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
--
Daniel Schepler
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors
Hi:
These seem like changes which should be proposed on the RT upstream.
After being unmaintained for many months, it's now starting to get
some support and teams have been put together to take over the
project. So I encourage you to submit patches or bug reports upstream
so they can get fixed. It's nothing serious (just perlcritic
failures)... Shouldn't affect program operation but would be useful to
fix for future releases.
Cheers,
Jonathan
On Mon, Mar 30, 2009 at 8:53 PM, Daniel Schepler
schep...@math.berkeley.edu wrote:
Package: libdbd-pg-perl
Version: 2.11.7-1
Severity: serious
From my pbuilder build log:
...
t/99_perlcritic.#
# File: Pg.pm (line 157)
# Vio: Package DBD::Pg::dr does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::dr;
#
#
# File: Pg.pm (line 235)
# Vio: Package DBD::Pg::db does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::db;
...
# File: t/dbdpg_test_setup.pl (line 528)
# Vio: Reused variable name in lexical scope: $SQL
# Policy: Variables::ProhibitReusedNames
# Source: my $SQL = q{
#
# Failed test 'Failed Perl::Critic tests for file t/dbdpg_test_setup.pl:
4'
# at t/99_perlcritic.t line 235.
# Looks like you failed 8 tests of 434.
dubious
Test returned status 8 (wstat 2048, 0x800)
DIED. FAILED tests 411-412, 418-419, 425, 428, 430, 433
Failed 8/434 tests, 98.16% okay
t/99_podok
t/99_spellcheck.skipped
all skipped: Set the environment variable TEST_SPELL to enable this
test
t/99_yaml...ok
t/99cleanup.Removing test database directory
ok
1/1 skipped: various reasons
Failed Test Stat Wstat Total Fail List of Failed
---
t/99_perlcritic.t 8 2048 434 8 411-412 418-419 425 428 430 433
13 tests and 1 subtest skipped.
Failed 1/19 test scripts. 8/576 subtests failed.
Files=19, Tests=576, 33 wallclock secs (32.34 cusr + 0.46 csys = 32.80 CPU)
Failed 1/19 test programs. 8/576 subtests failed.
make[1]: *** [test_dynamic] Error 255
make[1]: Leaving directory `/tmp/buildd/libdbd-pg-perl-2.11.7'
dh_auto_test: make returned exit code 2
make: *** [build-stamp] Error 1
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
--
Daniel Schepler
___
pkg-perl-maintainers mailing list
pkg-perl-maintain...@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-perl-maintainers
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521969: libdbd-pg-perl: FTBFS: Perl::Critic errors
My apologies, for some reason I confused this with DBD::SQLite. But
the fact remains that these changes should be proposed upstream,
UNLESS they are either caused by debian patches, or if they are Debian
specific, or if the maintainer just sucks at updating the module.
I'm not sure about the specifics of these, but I'd encourage you to
post something to the RT and get back to us if there is no activity
On Mon, Mar 30, 2009 at 9:30 PM, Jonathan Yu jonathan.i...@gmail.com wrote:
Hi:
These seem like changes which should be proposed on the RT upstream.
After being unmaintained for many months, it's now starting to get
some support and teams have been put together to take over the
project. So I encourage you to submit patches or bug reports upstream
so they can get fixed. It's nothing serious (just perlcritic
failures)... Shouldn't affect program operation but would be useful to
fix for future releases.
Cheers,
Jonathan
On Mon, Mar 30, 2009 at 8:53 PM, Daniel Schepler
schep...@math.berkeley.edu wrote:
Package: libdbd-pg-perl
Version: 2.11.7-1
Severity: serious
From my pbuilder build log:
...
t/99_perlcritic.#
# File: Pg.pm (line 157)
# Vio: Package DBD::Pg::dr does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::dr;
#
#
# File: Pg.pm (line 235)
# Vio: Package DBD::Pg::db does not start with a upper case letter
# Policy: NamingConventions::Capitalization
# Source: package DBD::Pg::db;
...
# File: t/dbdpg_test_setup.pl (line 528)
# Vio: Reused variable name in lexical scope: $SQL
# Policy: Variables::ProhibitReusedNames
# Source: my $SQL = q{
#
# Failed test 'Failed Perl::Critic tests for file t/dbdpg_test_setup.pl:
4'
# at t/99_perlcritic.t line 235.
# Looks like you failed 8 tests of 434.
dubious
Test returned status 8 (wstat 2048, 0x800)
DIED. FAILED tests 411-412, 418-419, 425, 428, 430, 433
Failed 8/434 tests, 98.16% okay
t/99_podok
t/99_spellcheck.skipped
all skipped: Set the environment variable TEST_SPELL to enable this
test
t/99_yaml...ok
t/99cleanup.Removing test database directory
ok
1/1 skipped: various reasons
Failed Test Stat Wstat Total Fail List of Failed
---
t/99_perlcritic.t 8 2048 434 8 411-412 418-419 425 428 430 433
13 tests and 1 subtest skipped.
Failed 1/19 test scripts. 8/576 subtests failed.
Files=19, Tests=576, 33 wallclock secs (32.34 cusr + 0.46 csys = 32.80 CPU)
Failed 1/19 test programs. 8/576 subtests failed.
make[1]: *** [test_dynamic] Error 255
make[1]: Leaving directory `/tmp/buildd/libdbd-pg-perl-2.11.7'
dh_auto_test: make returned exit code 2
make: *** [build-stamp] Error 1
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
--
Daniel Schepler
___
pkg-perl-maintainers mailing list
pkg-perl-maintain...@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-perl-maintainers
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
