Bug#542102: mpd: audio skips once per second
On Wed, Sep 02, 2009 at 08:27:26AM -0400, Decklin Foster wrote: > Excerpts from Peter Colberg's message of Tue Aug 18 13:45:00 -0400 2009: > > On Tue, Aug 18, 2009 at 06:43:56AM +0200, Max Kellermann wrote: > > > On 2009/08/18 01:51, Peter Colberg wrote: > > > > Reverting commit 7133f56 fixes the audio skips :-). > > Can you confirm if this is fixed in 0.15.3-1? Thanks. At the moment, I do not have access to the amd64+alsa+sblive box on which mpd 0.15.2-1 exhibits the bug. I will be able to test 0.15.3-1 on that system next week. Regards, Peter -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
Excerpts from Peter Colberg's message of Tue Aug 18 13:45:00 -0400 2009: > On Tue, Aug 18, 2009 at 06:43:56AM +0200, Max Kellermann wrote: > > On 2009/08/18 01:51, Peter Colberg wrote: > > > Reverting commit 7133f56 fixes the audio skips :-). Can you confirm if this is fixed in 0.15.3-1? Thanks. -- things change. deck...@red-bean.com -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On 2009/08/18 19:45, Peter Colberg wrote: > Both the workaround and the patch resolve the skipping playback. > > (Btw, the release-0.15.2 tag is missing in the git repository.) Thanks again for the feedback. I must have forgot to merge the release tag from our release manager's repository... Max -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On Tue, Aug 18, 2009 at 06:43:56AM +0200, Max Kellermann wrote: > On 2009/08/18 01:51, Peter Colberg wrote: > > Reverting commit 7133f56 fixes the audio skips :-). > > Thanks for the bisect! > > I suspect this is an uninitialized variable. Please try two > approaches at working around it: > > 1. "mpc toggle" twice (enter pause, leave pause) - this should >initialize the "pause" flag retroactively > > 2. try the attached patch Both the workaround and the patch resolve the skipping playback. (Btw, the release-0.15.2 tag is missing in the git repository.) Regards, Peter -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On 2009/08/18 01:51, Peter Colberg wrote: > Reverting commit 7133f56 fixes the audio skips :-). Thanks for the bisect! I suspect this is an uninitialized variable. Please try two approaches at working around it: 1. "mpc toggle" twice (enter pause, leave pause) - this should initialize the "pause" flag retroactively 2. try the attached patch If the patch fixes the problem, we'll release 0.15.3 soon. Max diff --git a/src/output_init.c b/src/output_init.c index 04609bb..9274243 100644 --- a/src/output_init.c +++ b/src/output_init.c @@ -109,6 +109,7 @@ audio_output_init(struct audio_output *ao, const struct config_param *param, ao->plugin = plugin; ao->enabled = config_get_block_bool(param, "enabled", true); ao->open = false; + ao->pause = false; ao->fail_timer = NULL; pcm_convert_init(&ao->convert_state);
Bug#542102: mpd: audio skips once per second
On Mon, Aug 17, 2009 at 11:20:22PM +0200, Max Kellermann wrote: > Can you make a "git bisect" from release-0.15.1 to release-0.15.2 to > isolate the commit which broke playback for you? It's very difficult > for me to find the cause, because I don't hear that problem over here. This took longer than expected… git bisect start # bad: [5715534b530cfed0d6650b0fb34cfcb17da4088b] mpd version 0.15.2 git bisect bad 5715534b530cfed0d6650b0fb34cfcb17da4088b # good: [d7bad6ae020ffabfd5d2ae9d2ce723e67e999077] mpd version 0.15.1 git bisect good d7bad6ae020ffabfd5d2ae9d2ce723e67e999077 # good: [cf1fd2b0da4be4675ddb16c5421d949a0e923b20] decoder/flac: return early from flac_find_float_comment() git bisect good cf1fd2b0da4be4675ddb16c5421d949a0e923b20 # good: [1c4f407a6db4c4795bbbc354f5cf311762fb8e33] decoder/flac: don't allocate cuesheet twice (memleak) git bisect good 1c4f407a6db4c4795bbbc354f5cf311762fb8e33 # good: [79beda2bb0505758bb6a32cae6feb3215733] directory: free empty directories after removing them (memleak) git bisect good 79beda2bb0505758bb6a32cae6feb3215733 # bad: [f38ce5408b5d0126b8cfe730c91d5203ee59a987] output/shout: minimize the unpause latency git bisect bad f38ce5408b5d0126b8cfe730c91d5203ee59a987 # bad: [7133f560ec24c90671a40c9f9bc9cea6eb31cc17] output: fixed shout stuck pause bug git bisect bad 7133f560ec24c90671a40c9f9bc9cea6eb31cc17 The commit which causes skipping audio is: commit 7133f560ec24c90671a40c9f9bc9cea6eb31cc17 Author: Max Kellermann Date: Fri Aug 14 11:52:12 2009 +0200 output: fixed shout stuck pause bug Explicitly make the output thread leave the ao_pause() loop. This patch is a workaround, and the "pause" flag is not managed in a thread-safe way, but that's good enough for now. I had to do two complete bisects as the bug turned out to randomly appear and disappear on each execution of mpd. The second round of git bisect, however, revealed that all versions < 7133f56 were definitly good, and all versions >= 7133f56 produced skipping playback on some executions of mpd and smooth playback on others. Reverting commit 7133f56 fixes the audio skips :-). Čau, Peter -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On Mon, Aug 17, 2009 at 11:20:22PM +0200, Max Kellermann wrote: > On 2009/08/17 22:53, Peter Colberg wrote: > > Aug 17 22:41 : playlist: queue song 1:"Miles Davis/Kind of Blue > > (1997)/Miles Davis - Kind of Blue - 02 - Freddie Freeloader.flac" > > Nothing to see here, no underruns.. :( > > > > Then try switching to an OSS output, and see if the same > > > problem occurs. > > > > A restart of mpd results in the following messages: > > So does the problem occur with OSS? Sorry, forgot to mention: yes, it also occurs with OSS. > Can you make a "git bisect" from release-0.15.1 to release-0.15.2 to > isolate the commit which broke playback for you? It's very difficult > for me to find the cause, because I don't hear that problem over here. Ok, I will hopefully report back with the faulty commit. Peter -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On 2009/08/17 22:53, Peter Colberg wrote: > Aug 17 22:41 : playlist: queue song 1:"Miles Davis/Kind of Blue > (1997)/Miles Davis - Kind of Blue - 02 - Freddie Freeloader.flac" Nothing to see here, no underruns.. :( > > Then try switching to an OSS output, and see if the same > > problem occurs. > > A restart of mpd results in the following messages: So does the problem occur with OSS? Can you make a "git bisect" from release-0.15.1 to release-0.15.2 to isolate the commit which broke playback for you? It's very difficult for me to find the cause, because I don't hear that problem over here. Max -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On Mon, Aug 17, 2009 at 10:36:41PM +0200, Max Kellermann wrote: > On 2009/08/17 22:15, Peter Colberg wrote: > > with the new version of mpd, I experience skipping audio about once per > > second, where a skip could be described as a crackling noise followed by > > a fast forward of a fraction of a second. I verified this behaviour for > > FLAC, Ogg and MP3 files. > > Please enable verbose mode and watch the log file for related > messages. With log_level = verbose, restarting mpd and thereby resuming playback: Aug 17 22:41 : state_file: Saving state file Aug 17 22:41 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 01 - So What.flac Aug 17 22:41 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 02 - Freddie Freeloader.flac Aug 17 22:41 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 03 - Blue In Green.flac Aug 17 22:41 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 04 - All Blues.flac Aug 17 22:41 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 05 - Flamenco Sketches.flac Aug 17 22:41 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 06 - Flamenco Sketches (Alternate Take).flac Aug 17 22:41 : playlist: play 0:"Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 01 - So What.flac" Aug 17 22:41 : decoder: audio_format=44100:16:2, seekable=true Aug 17 22:41 : alsa: default period_time = buffer_time/4 = 371519/4 = 92879 Aug 17 22:41 : alsa: buffer_size=16384 period_size=4096 Aug 17 22:41 : output: opened plugin=alsa name="My ALSA Device" audio_format=44100:16:2 Aug 17 22:41 : playlist: queue song 1:"Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 02 - Freddie Freeloader.flac" (error.log remains empty.) > Then try switching to an OSS output, and see if the same > problem occurs. A restart of mpd results in the following messages: Aug 17 22:46 : output: closed plugin=alsa name="My ALSA Device" Aug 17 22:46 : listen: listen_global_finish called Aug 17 22:46 : db_finish took 0.00 seconds Aug 17 22:46 : state_file: Saving state file Aug 17 22:46 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 01 - So What.flac Aug 17 22:46 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 02 - Freddie Freeloader.flac Aug 17 22:46 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 03 - Blue In Green.flac Aug 17 22:46 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 04 - All Blues.flac Aug 17 22:46 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 05 - Flamenco Sketches.flac Aug 17 22:46 : database: get song: Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 06 - Flamenco Sketches (Alternate Take).flac Aug 17 22:46 : playlist: play 0:"Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 01 - So What.flac" Aug 17 22:46 : decoder: audio_format=44100:16:2, seekable=true Aug 17 22:46 : output: opened plugin=oss name="My OSS Device" audio_format=44100:16:2 Aug 17 22:46 : playlist: queue song 1:"Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 02 - Freddie Freeloader.flac" Aug 17 22:46 : decoder: audio_format=44100:16:2, seekable=true Aug 17 22:46 : playlist: queue song 2:"Miles Davis/Kind of Blue (1997)/Miles Davis - Kind of Blue - 03 - Blue In Green.flac" During playback no messages are printed. Peter -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
On 2009/08/17 22:15, Peter Colberg wrote: > with the new version of mpd, I experience skipping audio about once per > second, where a skip could be described as a crackling noise followed by > a fast forward of a fraction of a second. I verified this behaviour for > FLAC, Ogg and MP3 files. Please enable verbose mode and watch the log file for related messages. Then try switching to an OSS output, and see if the same problem occurs. Max -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#542102: mpd: audio skips once per second
Package: mpd
Version: 0.15.2-1
Severity: grave
Justification: renders package unusable
Hi,
with the new version of mpd, I experience skipping audio about once per
second, where a skip could be described as a crackling noise followed by
a fast forward of a fraction of a second. I verified this behaviour for
FLAC, Ogg and MP3 files.
A downgrade to the previous version 0.15.1-1 restores smooth playback.
My audio output section of the mpd config reads as follows:
audio_output {
type"alsa"
name"My ALSA Device"
device "hw:0,0"# optional
format "44100:16:2"# optional
mixer_device"default" # optional
mixer_control "Master"# optional
mixer_index "0" # optional
}
ALSA uses the following card as shown by lspci:
00:0c.0 Multimedia audio controller: Creative Labs SB Live! EMU10k1 (rev 07)
Regards,
Peter
-- System Information:
Debian Release: squeeze/sid
APT prefers oldstable
APT policy: (500, 'oldstable'), (500, 'unstable'), (400, 'testing'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.30-maia (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages mpd depends on:
ii adduser 3.110 add and remove users and groups
ii libao2 0.8.8-5 Cross Platform Audio Output Librar
ii libasound2 1.0.20-3shared library for ALSA applicatio
ii libaudiofile00.2.6-7 Open-source version of SGI's audio
ii libavcodec52 4:0.5+svn20090609-2 ffmpeg codec library
ii libavformat524:0.5+svn20090609-2 ffmpeg file format library
ii libavutil49 4:0.5+svn20090609-2 ffmpeg utility library
ii libc62.9-25 GNU C Library: Shared libraries
ii libcue1 1.3.0-1 CUE Sheet Parser Library
ii libcurl3-gnutls 7.19.5-1Multi-protocol file transfer libra
ii libfaad0 2.6.1-3.1 freeware Advanced Audio Decoder -
ii libflac8 1.2.1-2+b1 Free Lossless Audio Codec - runtim
ii libgcc1 1:4.4.1-2 GCC support library
ii libglib2.0-0 2.20.4-1The GLib library of C routines
ii libid3tag0 0.15.1b-10 ID3 tag reading library from the M
ii libjack0 0.116.2+svn3592-2 JACK Audio Connection Kit (librari
ii libmad0 0.15.1b-4 MPEG audio decoder library
ii libmms0 0.4-2 MMS stream protocol library - shar
ii libmpcdec3 1:1.2.2-2.1 Musepack (MPC) format library
ii libogg0 1.1.4~dfsg-1Ogg bitstream library
ii libpulse00.9.15-4.1 PulseAudio client libraries
ii libresid-builder0c2a 2.1.1-7 SID chip emulation class based on
ii libsamplerate0 0.1.7-2 audio rate conversion library
ii libshout32.2.2-5+b1 MP3/Ogg Vorbis broadcast streaming
ii libsidplay2 2.1.1-7 SID (MOS 6581) emulation library
ii libsqlite3-0 3.6.17-2SQLite 3 shared library
ii libstdc++6 4.4.1-2 The GNU Standard C++ Library v3
ii libvorbis0a 1.2.0.dfsg-6The Vorbis General Audio Compressi
ii libvorbisenc21.2.0.dfsg-6The Vorbis General Audio Compressi
ii libvorbisfile3 1.2.0.dfsg-6The Vorbis General Audio Compressi
ii libwavpack1 4.50.1-1an audio codec (lossy and lossless
mpd recommends no packages.
Versions of packages mpd suggests:
pn avahi-daemon (no description available)
ii glurp [mpd-client]0.11.6-4 gtk2.4+ frontend to the Music Play
ii gmpc [mpd-client] 0.18.98-1 Gnome Music Player Client (graphic
pn icecast2 (no description available)
ii mpc [mpd-client] 0.16-1 A command-line tool to interface M
ii ncmpc [mpd-client]0.14-1 ncurses-based audio player
pn pulseaudio (no description available)
ii sonata [mpd-client] 1.6.2-1GTK+ client for the Music Player D
-- debconf information:
mpd/playlist_directory: /var/lib/mpd/playlists
* mpd/systemwide: false
mpd/music_directory: /usr/share/mpd/music
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
