Bug#556635: udev: blanks inserted RW media

2009-11-23 Thread Colin Watson
This appears to be fixed in git now:

  
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=160b069c25690bfb0c785994c7c3710289179107

-- 
Colin Watson   [cjwat...@debian.org]



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#556635: udev: blanks inserted RW media

2009-11-19 Thread Michael Biebl
Marco d'Itri wrote:
 On Nov 17, Ji??í Pale??ek jpale...@web.de wrote:
 
 Try to reproduce the issue in single user mode for a start.
 I did, and it is reproducible.
 Try to reproduce the issue after booting with init=/bin/bash and running
 ata_id from the command line with no udevd process running.

Hi,

so git diff 146..147 -- extras/ata_id/ata_id.c lists quite a lot of changes and
the log reads

$ git log 146..147 -- extras/ata_id/ata_id.c
commit 66094a4a7fc1d303e80785d586800eae9841502b
Author: David Zeuthen zeut...@gmail.com
Date:   Wed Nov 4 16:34:22 2009 +0100

ata_id: export more advanced ATA features


I'm only guessing here, but maybe it is related to ide-cd. David Zeuthen is a
Redhat/Fedora guy, and they switched to libata only quite some time ago, so I
assume he didn't test this code with the (legacy) ide-cd subsystem.

Can everyone who encouters this bug confirm, that this only happens with ide-cd
(i.e. is your cdrom device named /dev/hd*)?

Cheers,
Michael



signature.asc
Description: OpenPGP digital signature


Bug#556635: udev: blanks inserted RW media

2009-11-19 Thread Jiří Paleček

On Thu, 19 Nov 2009 17:37:39 +0100, Michael Biebl bi...@debian.org wrote:


Marco d'Itri wrote:

On Nov 17, Ji??í Pale??ek jpale...@web.de wrote:


Try to reproduce the issue in single user mode for a start.

I did, and it is reproducible.

Try to reproduce the issue after booting with init=/bin/bash and running
ata_id from the command line with no udevd process running.


Hi,

so git diff 146..147 -- extras/ata_id/ata_id.c lists quite a lot of  
changes and

the log reads

$ git log 146..147 -- extras/ata_id/ata_id.c
commit 66094a4a7fc1d303e80785d586800eae9841502b
Author: David Zeuthen zeut...@gmail.com
Date:   Wed Nov 4 16:34:22 2009 +0100

ata_id: export more advanced ATA features


I'm only guessing here, but maybe it is related to ide-cd. David Zeuthen  
is a
Redhat/Fedora guy, and they switched to libata only quite some time ago,  
so I

assume he didn't test this code with the (legacy) ide-cd subsystem.

Can everyone who encouters this bug confirm, that this only happens with  
ide-cd

(i.e. is your cdrom device named /dev/hd*)?


For me at least, it works that way. I tried reproducing with Asus EEE's  
external DVD writer (USB, /dev/sg0), and it didn't blank the media. It  
didn't work though, because it didn't write any info about the drive (just  
sad something about call not supported).


An interresting info, quoting from the manpage  
http://linux.die.net/man/8/sg_sat_identify:


The SCSI ATA PASS-THROUGH (12) command's opcode is 0xa1 and it clashes  
with the MMC set's BLANK command used by cd/dvd writers. So a SATL in  
front of an ATAPI device that uses MMC (i.e. has peripheral device type 5)  
probably should treat opcode 0xa1 as a BLANK command and send it through  
to the cd/dvd drive. The ATA PASS-THROUGH (16) command's opcode (0x85)  
does not clash with anything so it is a better choice.


Note that ata_id uses the 0xA1 command. However, this is what I get when  
running sg_sat_identify:


debian:/usr/share/man# sg_sat_identify -v /dev/cdrom
ATA pass through (16) cdb: 85 08 0e 00 00 00 01 00 00 00 00 00 00 00  
ec 00

ATA PASS-THROUGH (16) not supported

Regards
Jiri Palecek



--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#556635: udev: blanks inserted RW media

2009-11-19 Thread Jiří Paleček

On Wed, 18 Nov 2009 16:36:21 +0100, Marco d'Itri m...@linux.it wrote:


On Nov 17, Ji??í Pale??ek jpale...@web.de wrote:


Try to reproduce the issue in single user mode for a start.

I did, and it is reproducible.

Try to reproduce the issue after booting with init=/bin/bash and running
ata_id from the command line with no udevd process running.


I just did that, with a Lenny live USB from the Debian Live project. It  
did blank the DVD.


  Jiri Palecek



--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#556635: udev: blanks inserted RW media

2009-11-18 Thread Christoph Stritt
I can confirm this bug, udev 147 erases/blanks my RW media completely aswell.
Tested with 147-2 and 147-4.

146-5 does not erase.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#556635: udev: blanks inserted RW media

2009-11-18 Thread Marco d'Itri
On Nov 18, Christoph Stritt phoe...@jobob.com wrote:

 I can confirm this bug, udev 147 erases/blanks my RW media completely aswell.
 Tested with 147-2 and 147-4.
I do not even own a CDRW so I cannot test this, but it's weird that the
media is blanked when the device is opened *read only*.
I have no idea about how this API works so I do not know if udev or the
kernel should be blamed.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#556635: udev: blanks inserted RW media

2009-11-18 Thread Marco d'Itri
On Nov 17, Ji??í Pale??ek jpale...@web.de wrote:

 Try to reproduce the issue in single user mode for a start.
 I did, and it is reproducible.
Try to reproduce the issue after booting with init=/bin/bash and running
ata_id from the command line with no udevd process running.

 Note that bugs causing data loss are grave per  
 http://www.debian.org/Bugs/Developer#severities, and you haven't asked 
 for any more info - so why have you tagged it as moreinfo? I hope you 
 don't close your eyes when opposing to bugs regularly.
Only weird unreproducible ones.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#556635: udev: blanks inserted RW media

2009-11-17 Thread Jiří Paleček

Package: udev
Version: 147-4
Severity: grave
Justification: data loss

Hello,

I've found that udev erases my live images burned on CD-RW media, making  
them unbootable. When I investigated further, I've found that, after  
unpacking udev 147 to a temporary directory, running


ata_id --export /dev/hdc

indeed erases the disc in the drive. (see the attachment for a strace of  
this execution)


This has been verified on two kernels (customized 2.6.27 and distribution  
2.6.30) and two drives.


I'm not sure where is the problem, though. It might be a problem in the  
kernel as well.


Regards
   Jiri Palecek

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

trace
Description: Binary data


Bug#556635: udev: blanks inserted RW media

2009-11-17 Thread Marco d'Itri
severity 556635 important
tag 556635 unreproducible moreinfo
thanks

On Nov 17, Ji??í Pale??ek jpale...@web.de wrote:

 I've found that udev erases my live images burned on CD-RW media, making  
 them unbootable. When I investigated further, I've found that, after  
 unpacking udev 147 to a temporary directory, running

 ata_id --export /dev/hdc

 indeed erases the disc in the drive. (see the attachment for a strace of  
 this execution)
I just do not believe this.
Look for other processes which may do this.
Try to reproduce the issue in single user mode for a start.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Processed: Re: Bug#556635: udev: blanks inserted RW media

2009-11-17 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 severity 556635 important
Bug #556635 [udev] udev: blanks inserted RW media
Severity set to 'important' from 'grave'

 tag 556635 unreproducible moreinfo
Bug #556635 [udev] udev: blanks inserted RW media
Added tag(s) unreproducible and moreinfo.
 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Processed: Re: Bug#556635: udev: blanks inserted RW media

2009-11-17 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 severity 556635 grave
Bug #556635 [udev] udev: blanks inserted RW media
Severity set to 'grave' from 'important'

 tags 556635 -moreinfo
Bug #556635 [udev] udev: blanks inserted RW media
Removed tag(s) moreinfo.
 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org