Bug#562190: mac-fdisk: udebs should depend on libc6-udeb instead of libc6

2010-01-02 Thread Frans Pop
On Saturday 02 January 2010, Michael Schmitz wrote:
> > I've build tested the attached patch on a porter box and to me the
> > result looks good.
>
> I can build it on my powerbook but testing it (short of installing it on

I have considered doing an NMU, but was scared off by the huge amount of 
compilation warnings.

> that system, which will hardly test whether it works with libc6-udeb) is
> another matter.

That's not a problem. The only thing to check is that the dependency is 
correct.

> What _is_ mac-fdisk udeb still being used for these days?? Maybe time to
> retire it?

I have no idea. powerpc is an architecture I know very little about as I've 
never had the hardware.

If it's still useful for anything, it probably is manual troubleshooting 
and rescue. I've no idea if it offers any advantages over regular fdisk 
and/or parted.

A decision to retire the udebs should be made by the powerpc and m68k [1] 
porters.

Cheers,
FJP

[1] Note that even though m68k is no longer a release arch, it is still 
being maintained to some degree, including D-I support for it.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#562190: mac-fdisk: udebs should depend on libc6-udeb instead of libc6

2010-01-02 Thread Michael Schmitz
> Package: mac-fdisk
> Version: 0.1-15
> Severity: serious
> Tags: patch d-i
> 
> The udebs do not get a correct dependency on libc6-udeb, but instead 
> depend on the regular libc6 package. We've ignored this for previous 
> releases, but for Squeeze it's RC because of britney support for udebs.

Thanks for alerting me - I'll prepare a new upload based on your patch shortly. 
Sorry to drag my feet a bit - been away at the beach since Christmas ...
 
> I originally thought this could be solved with a binNMU, but that turned 
> out not to be enough.
> The basic reason is that the control file does not set the correct package 
> type for the udeb. Doing that also allows to simplify debian/rules a bit as 
> the package type triggers all the necessary magic for udebs in debhelper.
> 
> I've build tested the attached patch on a porter box and to me the result 
> looks good.

I can build it on my powerbook but testing it (short of installing it on that 
system, which will hardly test whether it works with libc6-udeb) is another 
matter. 

What _is_ mac-fdisk udeb still being used for these days?? Maybe time to retire 
it?  

Cheers,

Michael




-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#562190: mac-fdisk: udebs should depend on libc6-udeb instead of libc6

2009-12-23 Thread Frans Pop
Package: mac-fdisk
Version: 0.1-15
Severity: serious
Tags: patch d-i

The udebs do not get a correct dependency on libc6-udeb, but instead 
depend on the regular libc6 package. We've ignored this for previous 
releases, but for Squeeze it's RC because of britney support for udebs.

I originally thought this could be solved with a binNMU, but that turned 
out not to be enough.
The basic reason is that the control file does not set the correct package 
type for the udeb. Doing that also allows to simplify debian/rules a bit as 
the package type triggers all the necessary magic for udebs in debhelper.

I've build tested the attached patch on a porter box and to me the result 
looks good.

diff -u mac-fdisk-0.1/debian/rules mac-fdisk-0.1/debian/rules
--- mac-fdisk-0.1/debian/rules
+++ mac-fdisk-0.1/debian/rules
@@ -164,9 +164,8 @@
 		dh_strip -p$(packudeb); \
 		dh_installdeb -p$(packudeb); \
 		dh_shlibdeps -p$(packudeb); \
-		dh_gencontrol -p$(packudeb) -- -isp "-DSubarchitecture=$(mac_subarches)" -fdebian/files~; \
-		dpkg-distaddfile $(packudeb)_$(shell dpkg-parsechangelog | grep ^Version: | cut -d ' ' -f 2)_$(BUILDARCH).udeb debian-installer standard; \
-		dh_builddeb -p$(packudeb) --filename=$(packudeb)_$(shell dpkg-parsechangelog | grep ^Version: | cut -d ' ' -f 2)_$(BUILDARCH).udeb; \
+		dh_gencontrol -p$(packudeb); \
+		dh_builddeb -p$(packudeb); \
 	fi
 
 	# build pmac-fdisk-udeb on powerpc
@@ -174,9 +173,8 @@
 		dh_strip -p$(packpudeb); \
 		dh_installdeb -p$(packpudeb); \
 		dh_shlibdeps -p$(packpudeb); \
-		dh_gencontrol -p$(packpudeb) -- -isp "-DSubarchitecture=$(pmac_subarches)" -fdebian/files~; \
-		dpkg-distaddfile $(packpudeb)_$(shell dpkg-parsechangelog | grep ^Version: | cut -d ' ' -f 2)_$(BUILDARCH).udeb debian-installer standard; \
-		dh_builddeb -p$(packpudeb) --filename=$(packpudeb)_$(shell dpkg-parsechangelog | grep ^Version: | cut -d ' ' -f 2)_$(BUILDARCH).udeb; \
+		dh_gencontrol -p$(packpudeb); \
+		dh_builddeb -p$(packpudeb); \
 	fi
 
 define checkdir
diff -u mac-fdisk-0.1/debian/control mac-fdisk-0.1/debian/control
--- mac-fdisk-0.1/debian/control
+++ mac-fdisk-0.1/debian/control
@@ -38,6 +38,7 @@
  interactive tool similar to PC fdisk. 
 
 Package: mac-fdisk-udeb
+XC-Package-Type: udeb
 Architecture: powerpc ppc64 m68k
 Priority: standard
 Section: debian-installer
@@ -54,6 +55,7 @@
  This is a minimal mac-fdisk package used by the debian-installer.
 
 Package: pmac-fdisk-udeb
+XC-Package-Type: udeb
 Architecture: powerpc ppc64
 Priority: standard
 Section: debian-installer