Bug#592720: patch suggestion

2010-08-17 Thread Agustin Martin
2010/8/12 Luk Bettale luk.bett...@lip6.fr:
 I exprienced the bug too and this is the same bug as bug #591925.

 Here is my diagnostic

 This comes from the 'called-interactively-p' function line 644 of the
 file /usr/share/emacs/site-lisp/dictionaries-common/flyspell.el
 (provided by the package dictionaries-common).
 I am not an elisp expert but I think this is due to an update of the
 called- interactively-p function which does not take optional argument
 anymore. This can be fixed by replacing in line 644 :
 (called-interactively-p 'interactive))
 by
 (called-interactively-p))
 It works for me.

Thanks for looking at this,

I thought I tested it for emacs 23.1, but I am not at a sid box, so I
cannot recheck now if things changed during 23.1 lifetime. The problem
is that `called- interactively-p' takes no argument for backported
Emacs 23.1 I am using now for testing, but will take a mandatory
argument for Emacs 23.2 (where `interactive-p' will be declared
obsolete), where original code was added, and does not exists neither
for XEmacs nor for some older Emacs.

I am more for the 'one size fits all' approach of something like

 (condition-case nil
(called-interactively-p 'interactive)
(error (interactive-p

that seems to also work and be more portable.

Let me think about this a bit more and test changes in a real sid box
first when possible.

Cheers,

-- 
Agustin



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#592720: patch suggestion

2010-08-12 Thread Luk Bettale
I exprienced the bug too and this is the same bug as bug #591925.

Here is my diagnostic

This comes from the 'called-interactively-p' function line 644 of the
file /usr/share/emacs/site-lisp/dictionaries-common/flyspell.el
(provided by the package dictionaries-common).
I am not an elisp expert but I think this is due to an update of the
called- interactively-p function which does not take optional argument
anymore. This can be fixed by replacing in line 644 :
(called-interactively-p 'interactive))
by
(called-interactively-p))
It works for me.
-- 
Luk Bettale



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org