Bug#643362: cellwriter: FTBFS: src/statusicon.c:215:17: error: format not a string literal and no format arguments [-Werror=format-security]

2011-11-12 Thread Eric Alexander 
tags 643362 +patch
thanks
Index: cellwriter-1.3.4/src/statusicon.c
===
--- cellwriter-1.3.4.orig/src/statusicon.c	2007-11-10 00:13:02.0 -0500
+++ cellwriter-1.3.4/src/statusicon.c	2011-11-11 10:59:14.641565609 -0500
@@ -212,7 +212,7 @@
 icon_path = g_build_filename(DATADIR, ICON_PATH PACKAGE ".svg", NULL);
 if (!(pixbuf = gdk_pixbuf_new_from_file(icon_path, &error))) {
 status_icon = NULL;
-g_warning(error->message);
+g_warning("%s", error->message);
 g_warning("Failed to load status icon '%s'", icon_path);
 return;
 }

Bug#643362: cellwriter: FTBFS: src/statusicon.c:215:17: error: format not a string literal and no format arguments [-Werror=format-security]

2011-09-27 Thread Didier Raboud 
Source: cellwriter
Version: 1.3.4-1
Severity: serious
Tags: wheezy sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> gcc -DHAVE_CONFIG_H -I. -pthread -I/usr/include/gtk-2.0 
> -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 
> -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 
> -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 
> -I/usr/lib/glib-2.0/include   -DORBIT2=1 -D_REENTRANT -pthread 
> -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 
> -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include 
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
> -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 
> -DDATADIR=\"/usr/share\" -DPKGDATADIR=\"/usr/share/cellwriter\" -g -O2 
> -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat 
> -Wformat-security -Werror=format-security -Wall -c -o statusicon.o `test -f 
> 'src/statusicon.c' || echo './'`src/statusicon.c
> src/statusicon.c: In function 'status_icon_create':
> src/statusicon.c:215:17: error: format not a string literal and no format 
> arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
> 
> make[2]: *** [statusicon.o] Error 1

The full build log is available from:
   
http://people.debian.org/~lucas/logs/2011/09/23/cellwriter_1.3.4-1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg1.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org