Bug#643370: d52: FTBFS: d52pass2.c:935:3: error: format not a string literal and, no format arguments [-Werror=format-security]

[peter green]

tags 643370 +patch
thanks

Patch is attatched, just drop it in debian/patches (the package uses
simple-patchsys so no series file is needed)

diff -Nur -x '*.orig' -x '*~' d52-3.4.1/d52pass2.c d52-3.4.1.new/d52pass2.c
--- d52-3.4.1/d52pass2.c	2007-09-02 15:31:16.0 +
+++ d52-3.4.1.new/d52pass2.c	2011-11-08 02:22:21.0 +
@@ -932,7 +932,7 @@
 	}
 	else if (dir  0x80)
 	{
-		kcnt += fprintf(fp, rbname[dir].dent);
+		kcnt += fprintf(fp, %s,rbname[dir].dent);
 		dirregs[dir] |= 1;
 	}
 	else

Bug#643370: d52: FTBFS: d52pass2.c:935:3: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: d52
Version: 3.4.1-1
Severity: serious
Tags: wheezy sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
 gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 
 -Wformat -Wformat-security -Werror=format-security -Wall -c d52pass2.c -o 
 obj/d52pass2.o
 d52pass2.c: In function 'pass2':
 d52pass2.c:299:7: warning: suggest parentheses around operand of '!' or 
 change '' to '' or '!' to '~' [-Wparentheses]
 d52pass2.c: In function 'dodir':
 d52pass2.c:935:3: error: format not a string literal and no format arguments 
 [-Werror=format-security]
 cc1: some warnings being treated as errors
 
 make[1]: *** [obj/d52pass2.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/d52_3.4.1-1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg1.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org