Bug#643384: gfccore: FTBFS: error.cc:116:52: error: format not a string literal and no format arguments [-Werror=format-security]

[Eric Alexander]

tags 643384 +patch
thanks
Index: 643384/gfccore-2.3.1/gfc/glib/error.cc
===
--- 643384.orig/gfccore-2.3.1/gfc/glib/error.cc	2004-08-18 02:05:24.0 -0400
+++ 643384/gfccore-2.3.1/gfc/glib/error.cc	2011-11-11 18:48:30.126444867 -0500
@@ -113,7 +113,7 @@
 {
 	if (error_)
 		clear();
-	g_set_error(error_, domain, code, message.c_str());
+	g_set_error(error_, domain, code, %s, message.c_str());
 }
 
 void
Index: 643384/gfccore-2.3.1/gfc/glib/markup.cc
===
--- 643384.orig/gfccore-2.3.1/gfc/glib/markup.cc	2004-08-18 02:05:16.0 -0400
+++ 643384/gfccore-2.3.1/gfc/glib/markup.cc	2011-11-11 18:50:25.602448477 -0500
@@ -79,7 +79,7 @@
 	G::Error tmp_error;
 	parser-on_start_element(tmp_context, tmp_element_name, attributes, tmp_error);
 	if (tmp_error.get())
-		g_set_error(error, tmp_error.domain(), tmp_error.code(), tmp_error.message());
+		g_set_error(error, tmp_error.domain(), tmp_error.code(), %s, tmp_error.message());
 }
 
 void
@@ -92,7 +92,7 @@
 	G::Error tmp_error;
 	parser-on_end_element(tmp_context, tmp_element_name, tmp_error);
 	if (tmp_error.get())
-		g_set_error(error, tmp_error.domain(), tmp_error.code(), tmp_error.message());
+		g_set_error(error, tmp_error.domain(), tmp_error.code(), %s, tmp_error.message());
 }
 
 void
@@ -105,7 +105,7 @@
 	G::Error tmp_error;
 	parser-on_text(tmp_context, tmp_text, tmp_error);
 	if (tmp_error.get())
-		g_set_error(error, tmp_error.domain(), tmp_error.code(), tmp_error.message());
+		g_set_error(error, tmp_error.domain(), tmp_error.code(), %s, tmp_error.message());
 }
 
 void
@@ -118,7 +118,7 @@
 	G::Error tmp_error;
 	parser-on_passthrough(tmp_context, text, tmp_error);
 	if (tmp_error.get())
-		g_set_error(error, tmp_error.domain(), tmp_error.code(), tmp_error.message());
+		g_set_error(error, tmp_error.domain(), tmp_error.code(), %s, tmp_error.message());
 }
 
 void

Bug#643384: gfccore: FTBFS: error.cc:116:52: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: gfccore
Version: 2.3.1-7
Severity: serious
Tags: wheezy sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
  g++ -DHAVE_CONFIG_H -I. -I. -I../.. -g -O2 -fstack-protector 
 --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security 
 -Werror=format-security -Wall -pthread -I/usr/include/glib-2.0 
 -I/usr/lib/glib-2.0/include -I/usr/include/sigc++-2.0 
 -I/usr/lib/sigc++-2.0/include -g -O2 -fstack-protector 
 --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security 
 -Werror=format-security -Wall -c error.cc  -fPIC -DPIC -o .libs/error.o
 error.cc: In member function 'void GFC::G::Error::set(GQuark, int, const 
 GFC::String)':
 error.cc:116:52: error: format not a string literal and no format arguments 
 [-Werror=format-security]
 cc1plus: some warnings being treated as errors
 
 make[5]: *** [error.lo] Error 1

The full build log is available from:
   
http://people.debian.org/~lucas/logs/2011/09/23/gfccore_2.3.1-7_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg1.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org