Bug#645868: fails to upgrade

[Olly Betts]

On Sat, Oct 29, 2011 at 11:36:41AM -0400, Daniel T Chen wrote:
 In Debian sid, the attached patch can be applied to achieve the following:
 
   * xpilot-ng-server.{init,postinst}: Create appropriate run directory
 before invoking the server. (Closes: #645868)

This patch doesn't really seem to be addressing the right problem to me,
though it probably does indeed solve the breakage.

Packages are meant to be migrating to use /run instead of /var/run, so
fixing it to still work in /var/run isn't what we want to do:

http://wiki.debian.org/ReleaseGoals/RunDirectory#A.2BAC8-run

Cheers,
Olly



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#645868: fails to upgrade

[Daniel T Chen]

Package: xpilot-ng
Version: 1:4.7.3-1.3
Followup-For: Bug #645868
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu precise ubuntu-patch

In Debian sid, the attached patch can be applied to achieve the following:

  * xpilot-ng-server.{init,postinst}: Create appropriate run directory
before invoking the server. (Closes: #645868)


Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric-proposed'), (500, 'oneiric')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-12-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru xpilot-ng-4.7.3/debian/xpilot-ng-server.init xpilot-ng-4.7.3/debian/xpilot-ng-server.init
--- xpilot-ng-4.7.3/debian/xpilot-ng-server.init	2010-06-02 14:03:29.0 -0400
+++ xpilot-ng-4.7.3/debian/xpilot-ng-server.init	2011-10-29 11:14:17.0 -0400
@@ -31,6 +31,7 @@
 	echo $AUTOSTART |grep -iq yes || exit 0
 	test -f $DEFAULTMAP || exit 0
 
+	mkdir -p $(dirname $PIDFILE)
 	echo -n Starting XPilot NG server: 
 	start-stop-daemon --start --quiet --chuid $USER --background \
 		--oknodo --exec /usr/games/start-xpilot-ng-server
diff -Nru xpilot-ng-4.7.3/debian/xpilot-ng-server.postinst xpilot-ng-4.7.3/debian/xpilot-ng-server.postinst
--- xpilot-ng-4.7.3/debian/xpilot-ng-server.postinst	2010-06-02 14:03:29.0 -0400
+++ xpilot-ng-4.7.3/debian/xpilot-ng-server.postinst	2011-10-29 11:15:55.0 -0400
@@ -9,6 +9,7 @@
--shell /bin/sh --disabled-password xpilotng || true
 fi
 
+mkdir -p /var/run/xpilot-ng-server
 chmod 700 /var/run/xpilot-ng-server
 chown -R xpilotng:xpilotng /etc/xpilot-ng
 chmod -f 600 /etc/xpilot-ng/password.txt