Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
* Ryan Tandy r...@nardis.ca [2012-03-29 22:50]: I will have to patch out the remaining bashisms in the scripts. I won't be able to work on that before this weekend. Did you have a chance to look into this, Ryan? -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
On Fri, Apr 13, 2012 at 2:43 AM, Martin Michlmayr t...@cyrius.com wrote: Did you have a chance to look into this, Ryan? I did; however life is being life (as it tends to) and I'm only about half-way done preparing the fixed upload. If you'd like to upload an NMU containing your patch that masks the error on non-Buffalo machines, that would be fine. Either way I'll complete the next package as soon as I can. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
* Ryan Tandy r...@nardis.ca [2012-03-29 22:50]: Your patch is correct but insufficient. Apparently in the 3.4 release upstream worked around the bashisms in /usr/sbin/micro-evtd.event and /usr/sbin/microapl by changing the shebang to /bin/bash; it was /bin/sh in both in 3.3.3. I feel pretty stupid for missing all of this; I was sure I tested installing from the 3.4-1 udeb before uploading but I don't see how that could have worked, unless d-i included a /bin/bash at some point. I will have to patch out the remaining bashisms in the scripts. I won't be able to work on that before this weekend. Thanks again for bringing this to my attention. My patch fixed the problem I saw - the error message from micro-evtd.command when starting d-i on a non-Buffalo machine. Thanks for checking the code and finding more problems. I'm happy to sponsor your upload when you have a complete fix. -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
Package: micro-evtd-udeb
Version: 3.4-1
Severity: serious
Tags: patch
I get the following error when starting Debian installer:
| /usr/sbin/micro-evtd.command: line 10: syntax error: bad function name
The following patch works for me.
--- debian/udeb/micro-evtd.command~ 2012-03-29 20:14:49.0 +0100
+++ debian/udeb/micro-evtd.command 2012-03-29 20:14:58.0 +0100
@@ -7,7 +7,7 @@
MICROAPL=/usr/sbin/microapl -a
PIDFILE=/var/run/micro-evtd.pid
-micro-evtd_start() {
+micro_evtd_start() {
$DAEMON /dev/null # daemon forks on its own
# Allow time to startup
sleep 1
@@ -44,7 +44,7 @@
start)
# Start micro-evtd if not already running, exit with failure
# if start failed
- [ -n $(pidof micro-evtd) ] || micro-evtd_start || exit 1
+ [ -n $(pidof micro-evtd) ] || micro_evtd_start || exit 1
;;
startup)
$MICROAPL led_set_blink power
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
Thanks for the report and patch. I wasn't aware of this particular bashism. I'm surprised it ever worked as dash in squeeze rejects that function name too. Would you have the time and inclination to sponsor a package including just this fix? -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
* Ryan Tandy r...@nardis.ca [2012-03-29 13:24]: Thanks for the report and patch. I wasn't aware of this particular bashism. I'm surprised it ever worked as dash in squeeze rejects that function name too. Would you have the time and inclination to sponsor a package including just this fix? Yes. -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#666218: udeb broken: micro-evtd.command: line 10: syntax error: bad function name
Your patch is correct but insufficient. Apparently in the 3.4 release upstream worked around the bashisms in /usr/sbin/micro-evtd.event and /usr/sbin/microapl by changing the shebang to /bin/bash; it was /bin/sh in both in 3.3.3. I feel pretty stupid for missing all of this; I was sure I tested installing from the 3.4-1 udeb before uploading but I don't see how that could have worked, unless d-i included a /bin/bash at some point. I will have to patch out the remaining bashisms in the scripts. I won't be able to work on that before this weekend. Thanks again for bringing this to my attention. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
