Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
control: tag -1 patch Hi, I don't think its worth spending too much time on this issue since its a small game, so I've applied the simplest solution (the oss-compat dependency, even though it requires a reboot). I've uploaded an nmu to delayed/5 to give enough time for others to put together a better fix if they want. Best wishes, Mike lletters.patch Description: Binary data
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Hi Adam,
On Tue, 19 Mar 2013 10:14:35 +0100, Adam Borowski wrote:
> On Mon, Mar 18, 2013 at 09:15:16PM +0100, Stephen Kitt wrote:
> > Alternatively, oss-compat is supposed to be used by packages such as
> > this one with a requirement for OSS. Adam, could you try installing it
> > to see if the modules it sets up allow lletters to work? It may not
> > play all that nicely with pulseaudio...
>
> Works, but only after a reboot (I tested on a Debian-provided kernel in a
> fresh wheezy install as well, to be sure). Having to reboot just to check
> out a simple child game is not nice.
OK, thanks for checking; having to reboot is a bug, I'll look into it...
> > For Jessie we'll have osspd, but oss-compat or disabling audio as
> > Steven suggested seem to me to be the only options for Wheezy.
>
> Here's another solution:
>
> Depends: sox
>
> if (!fork())
> {
> const char* arg[4];
> arg[0] = "/usr/bin/play";
> arg[1] = "-q";
> arg[2] = the_file_to_play;
> arg[3] = 0;
> execve(arg[0], arg, environ);
> exit(127);
> }
>
> Works on all sound systems, doesn't crash if no sound is available, doesn't
> hang on 64 bit architectures (and I guess big-endian too), supports formats
> other than .wav (in case someone localizes sounds). And doesn't use that
> ridiculous code with more leaks than ${SOME_MICROSOFT_SLUR}.
>
> One could use, say, SDL_sound to avoid the fork(), but come on, let's be
> serious.
Indeed, that seems better all around!
Regards,
Stephen
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
On Mon, Mar 18, 2013 at 09:15:16PM +0100, Stephen Kitt wrote:
> Hi,
>
> On Mon, Mar 18, 2013 at 02:47:47PM +, Steven Chamberlain wrote:
> > On 17/03/13 19:35, Adam Borowski wrote:
> > > On systems that don't have OSS installed and configured, pressing any
> > > button that has an attached sound, causes a crash.
> >
> > Another option might be to disable sound on Linux, then at least we'd
> > keep something that works.
>
> Alternatively, oss-compat is supposed to be used by packages such as
> this one with a requirement for OSS. Adam, could you try installing it
> to see if the modules it sets up allow lletters to work? It may not
> play all that nicely with pulseaudio...
Works, but only after a reboot (I tested on a Debian-provided kernel in a
fresh wheezy install as well, to be sure). Having to reboot just to check
out a simple child game is not nice.
> For Jessie we'll have osspd, but oss-compat or disabling audio as
> Steven suggested seem to me to be the only options for Wheezy.
Here's another solution:
Depends: sox
if (!fork())
{
const char* arg[4];
arg[0] = "/usr/bin/play";
arg[1] = "-q";
arg[2] = the_file_to_play;
arg[3] = 0;
execve(arg[0], arg, environ);
exit(127);
}
Works on all sound systems, doesn't crash if no sound is available, doesn't
hang on 64 bit architectures (and I guess big-endian too), supports formats
other than .wav (in case someone localizes sounds). And doesn't use that
ridiculous code with more leaks than ${SOME_MICROSOFT_SLUR}.
One could use, say, SDL_sound to avoid the fork(), but come on, let's be
serious.
--
ᛊᚨᚾᛁᛏᚣ᛫ᛁᛊ᛫ᚠᛟᚱ᛫ᚦᛖ᛫ᚹᛖᚨᚲ
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Hi, On Mon, Mar 18, 2013 at 02:47:47PM +, Steven Chamberlain wrote: > On 17/03/13 19:35, Adam Borowski wrote: > > On systems that don't have OSS installed and configured, pressing any > > button that has an attached sound, causes a crash. > > Another option might be to disable sound on Linux, then at least we'd > keep something that works. Alternatively, oss-compat is supposed to be used by packages such as this one with a requirement for OSS. Adam, could you try installing it to see if the modules it sets up allow lletters to work? It may not play all that nicely with pulseaudio... For Jessie we'll have osspd, but oss-compat or disabling audio as Steven suggested seem to me to be the only options for Wheezy. Regards, Stephen -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Control: tags -1 + patch Hi, On 18/03/13 14:47, Steven Chamberlain wrote: > On Linux we could override it with --enable-sound=no (assuming it is too > difficult to get it working with OSS4 or aoss in the Wheezy timeframe). > I've attached a patch for this but am still trying to test it. I've tested this now, it does build an work (without sound) as long as the attached patch is also applied. This fixes a Makefile.in bug that would forget to link with GTK libs if you configure without OSS sound enabled. Regards, -- Steven Chamberlain ste...@pyro.eu.org --- lletters-0.1.95+gtk2.orig/Makefile.in 2013-03-18 14:42:35.0 + +++ lletters-0.1.95+gtk2/Makefile.in 2013-03-18 16:17:33.0 + @@ -263,8 +263,9 @@ timer.h \ version.h -@SOUND_FALSE@lletters_SOURCES = $(lln_CORE) +@SOUND_FALSE@lletters_SOURCES = $(lln_CORE) @SOUND_TRUE@lletters_SOURCES = $(lln_CORE) wav_play.c $(sound_CORE) +@SOUND_FALSE@lletters_LDADD = -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 -lgtk-x11-2.0 @SOUND_TRUE@lletters_LDADD = libqdwav/libqdwav.a -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 -lgtk-x11-2.0 #lletters_LDADD = #@GTK_LIBS@
Processed: Re: Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Processing control commands: > tags -1 + patch Bug #703265 [lletters] lletters: crashes on most buttons on non-OSS3 systems Added tag(s) patch. -- 703265: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703265 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Hi! On 17/03/13 19:35, Adam Borowski wrote: > On systems that don't have OSS installed and configured, pressing any > button that has an attached sound, causes a crash. Another option might be to disable sound on Linux, then at least we'd keep something that works. There is a configure test which checks for presence of sys/soundcard.h or soundcard.h and it will automatically enable-sound due to that. On Linux we could override it with --enable-sound=no (assuming it is too difficult to get it working with OSS4 or aoss in the Wheezy timeframe). I've attached a patch for this but am still trying to test it. > [...] the package still works on kfreebsd, but these are > quite fringe cases. (Hey, you can ask for RM on linux-any hurd-any :) ). That also sounds good. We could market this on the "why kFreeBSD?" Wiki page! Regards, -- Steven Chamberlain ste...@pyro.eu.org --- lletters-0.1.95+gtk2.orig/debian/rules 2013-03-18 14:42:35.0 + +++ lletters-0.1.95+gtk2/debian/rules 2013-03-18 14:45:24.0 + @@ -7,6 +7,7 @@ #export DH_VERBOSE=1 package=lletters +export DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS) export DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE) @@ -17,6 +18,10 @@ confflags += --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE) endif +ifeq ($(DEB_HOST_ARCH_OS),linux) + confflags += --enable-sound=no +endif + config.status: # libtoolize --automake --force --copy # aclocal-1.9
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
On Sun, Mar 17, 2013 at 05:20:13PM -0400, Michael Gilbert wrote: > I'm also seeing this. Can you install oss4 and see if that fixes it? With oss4, no sound is produced, and it hangs, but this appears to be #701852. > If so, the easiest solution is to just add a dependency on that. It'd be quite silly to replace the whole sound system to something nowhere as complete as ALSA that requires extra manual steps just for a simple game. Depending on aoss, and running it from a wrapper if oss4 is not installed would be an option, though. I'm quite certain that a rewrite of the whole package from scratch would be simpler than trying to fix it, though. -- ᛊᚨᚾᛁᛏᚣ᛫ᛁᛊ᛫ᚠᛟᚱ᛫ᚦᛖ᛫ᚹᛖᚨᚲ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Hi, why do you say it crashes? It only complains "cannot open DSP" and exits, is it a crash? If you disable sound (use -d), it works. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
control: tag -1 confirmed I'm also seeing this. Can you install oss4 and see if that fixes it? If so, the easiest solution is to just add a dependency on that. Best wishes, Mike -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#703265: lletters: crashes on most buttons on non-OSS3 systems
Package: lletters Version: 0.1.95+gtk2-3.1 Severity: grave Justification: renders package unusable On systems that don't have OSS installed and configured, pressing any button that has an attached sound, causes a crash. Since no linux kernel shipped in wheezy has OSS built, this makes the package useless for nearly all users. Technically, you can manually use aoss emulation, and the package still works on kfreebsd, but these are quite fringe cases. (Hey, you can ask for RM on linux-any hurd-any :) ). Meow! -- System Information: Debian Release: 7.0 APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (150, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.8.2-x32 (SMP w/6 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lletters depends on: ii libc6 2.17-0experimental2 ii libgdk-pixbuf2.0-0 2.26.1-1 ii libglib2.0-02.33.12+really2.32.4-5 ii libgtk2.0-0 2.24.10-2 ii lletters-media 0.1.9a-4 lletters recommends no packages. lletters suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
