Bug#712797: libtorrent-rasterbar: FTBFS on kfreebsd
tag 712797 + fixed-upstream thanks Alle mercoledì 19 giugno 2013, Cristian Greco ha scritto: Although the patch seems more than reasonable, I'd prefer to wait for a bit of feedback from Arvid before introducing it. Arvid fixed the issue already (!), although I did not check the actual patch he checked in. Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Processed: Re: Bug#712797: libtorrent-rasterbar: FTBFS on kfreebsd
Processing commands for cont...@bugs.debian.org: tag 712797 + fixed-upstream Bug #712797 [src:libtorrent-rasterbar] libtorrent-rasterbar: FTBFS on kfreebsd Added tag(s) fixed-upstream. thanks Stopping processing here. Please contact me if you need assistance. -- 712797: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=712797 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#712797: libtorrent-rasterbar: FTBFS on kfreebsd
On Thu, 20 Jun 2013 18:21:31 +0200 Pino Toscano p...@debian.org wrote: tag 712797 + fixed-upstream thanks Alle mercoledì 19 giugno 2013, Cristian Greco ha scritto: Although the patch seems more than reasonable, I'd prefer to wait for a bit of feedback from Arvid before introducing it. Arvid fixed the issue already (!), although I did not check the actual patch he checked in. This is the change committed by upstream [0]. I'll apply your patch and upload in a few. [0] http://sourceforge.net/p/libtorrent/code/8527/ Thanks, -- Cristian Greco GPG key ID: 0xCF4D32E4 signature.asc Description: PGP signature
Bug#712797: libtorrent-rasterbar: FTBFS on kfreebsd
Source: libtorrent-rasterbar Version: 0.16.10-2 Severity: serious Tags: patch Justification: fails to build from source (but built successfully in the past) User: debian-...@lists.debian.org Usertags: kfreebsd Control: found -1 libtorrent-rasterbar/0.16.9-1 Hi, libtorrent-rasterbar 0.16.9/10 does not compile on kFreeBSD[1][2]. The issue, which I reported upstream[3], is due to a wrong configuration (in config.hpp) of the iconv arguments used. Attached there is a copy of the patch I sent upstream. [1] https://buildd.debian.org/status/fetch.php?pkg=libtorrent-rasterbararch=kfreebsd-i386ver=0.16.10-2stamp=1371536378 [2] https://buildd.debian.org/status/fetch.php?pkg=libtorrent-rasterbararch=kfreebsd-amd64ver=0.16.10-2stamp=1371536452 [3] https://code.google.com/p/libtorrent/issues/detail?id=487 Thanks, -- Pino --- a/include/libtorrent/config.hpp +++ b/include/libtorrent/config.hpp @@ -183,9 +183,11 @@ #define TORRENT_CLOSE_MAY_BLOCK 1 #endif #else +#ifndef __GLIBC__ // FreeBSD has a reasonable iconv signature #define TORRENT_ICONV_ARG (const char**) #endif +#endif #define TORRENT_HAS_FALLOCATE 0 #define TORRENT_USE_IFADDRS 1 #define TORRENT_USE_SYSCTL 1
Bug#712797: libtorrent-rasterbar: FTBFS on kfreebsd
On Wed, 19 Jun 2013 18:12:57 +0200 Pino Toscano p...@debian.org wrote: Hi, libtorrent-rasterbar 0.16.9/10 does not compile on kFreeBSD[1][2]. The issue, which I reported upstream[3], is due to a wrong configuration (in config.hpp) of the iconv arguments used. Attached there is a copy of the patch I sent upstream. [1] https://buildd.debian.org/status/fetch.php?pkg=libtorrent-rasterbararch=kfreebsd-i386ver=0.16.10-2stamp=1371536378 [2] https://buildd.debian.org/status/fetch.php?pkg=libtorrent-rasterbararch=kfreebsd-amd64ver=0.16.10-2stamp=1371536452 [3] https://code.google.com/p/libtorrent/issues/detail?id=487 Thanks, Ciao Pino! Thank you for your prompt help with this patch, I really appreciate it! Although the patch seems more than reasonable, I'd prefer to wait for a bit of feedback from Arvid before introducing it. Thanks, -- Cristian Greco GPG key ID: 0xCF4D32E4 signature.asc Description: PGP signature
Bug#712797: libtorrent-rasterbar: FTBFS on kfreebsd
Ciao! Alle mercoledì 19 giugno 2013, Cristian Greco ha scritto: Thank you for your prompt help with this patch, I really appreciate it! Although the patch seems more than reasonable, I'd prefer to wait for a bit of feedback from Arvid before introducing it. That's ok for me -- I opened the upstream bug first (I prefer to do it when possible), and then later this Debian one as kind of pointer-to- upstream for the issue (someone would have opened one anyway, methinks). -- Pino Toscano signature.asc Description: This is a digitally signed message part.
