Bug#718129: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-07 Thread Manuel A. Fernandez Montecelo
Hi,

For reference, I think that bug-715461-soundfont_paths.patch created
the recent problem in #718129.

Instead of adding another patch (the one fixing #718129, included in
revision -7 of the package), perhaps the pach to include soundfonts
can be modified to avoid having the second one.

I think that, as Dominique mentioned, the problem is that the
SDL_free() frees memory which has not been malloc()ed (SDL_malloc()
perhaps?).

For example, one fix that comes to mind is to change the line in the
first patch:

char* soundfont_paths =
/usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2;

to this:

char* soundfont_paths =
SDL_strdup(/usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2);

What do you think?  Feels less intrusive than having a second patch.


Cheers.
--
Manuel


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#718129: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-07 Thread Fabian Greffrath
Am Mittwoch, den 07.08.2013, 22:13 +0100 schrieb Manuel A. Fernandez
Montecelo: 
 char* soundfont_paths =
 SDL_strdup(/usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2);
 
 What do you think?  Feels less intrusive than having a second patch.

Good idea! Feels much cleaner than having a second patch remove
unrelated code.

- Fabian


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org