Bug#724226: [Pkg-ime-devel] Bug#724226: input-pad = 1.0.2-1 breaks ibus-input-pad

2013-10-06 Thread Osamu Aoki
Hi,

On Sat, Oct 05, 2013 at 07:35:42PM +0200, Pino Toscano wrote:
...
 ... because both input-pad and ibus-input-pad must use the *same* gtk 
 version, be it gtk2 or gtk3, to avoid this clash.

Thanks for kind explanation.

With the recent upload of ibus-input-pad, I hope I fixed this bug.

diff --git a/debian/control b/debian/control
index 8d1f110..7bcbbf0 100644
--- a/debian/control
+++ b/debian/control
@@ -8,9 +8,9 @@ Build-Depends:
  automake,
  autotools-dev,
  intltool (= 0.40.0),
- libgtk2.0-dev,
+ libgtk-3-dev,
  libibus-1.0-dev,
- libinput-pad-dev (= 1.0.0),
+ libinput-pad-dev (= 1.0.2-2~),
  libxkbfile-dev,
  libxklavier-dev (= 4.0),
  libxml2-dev (= 2.0),
diff --git a/debian/rules b/debian/rules
index 53c072c..5ba69eb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,4 +3,4 @@
dh  $@
 
 override_dh_auto_configure:
-   dh_auto_configure -- --libexecdir=/usr/lib/ibus
+   dh_auto_configure -- --libexecdir=/usr/lib/ibus --with-gtk=3.0 

Now cleanly with-gtk=3.0. I can input :-)  ↛↜↝↡↢↣‰‱⁑℉㍱㎑㎒㎓

Osamu


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#724226: [Pkg-ime-devel] Bug#724226: input-pad = 1.0.2-1 breaks ibus-input-pad

2013-10-05 Thread Osamu Aoki
control: reassign 724226 libinput-pad-dev 
control: retitle  724226 libinput-pad-dev: Should depend on libgtk-3-dev (not 
libgtk2.0-dev)

Hi,

On Sat, Oct 05, 2013 at 03:03:19PM +0200, Pino Toscano wrote:
 tag 724226 - unreproducible
 severity 724226 serious
 retitle 724226 FTBFS: input-pad = 1.0.2-1 breaks ibus-input-pad
 thanks
 
 Hi,
 
 the problem is due to input-pad 1.0.2-1 switching to gtk3 instead of 
 gtk2: 

Yes, I switched input-pad to use gtk3.

 while pkg-config succeeds in doing the existence check of
 input-pad.pc, querying it for cflags and libraries fails in a clean 
 chroot:
 
 | $ pkg-config --cflags input-pad
 | Package gtk+-3.0 was not found in the pkg-config search path.
 | Perhaps you should add the directory containing `gtk+-3.0.pc'
 | to the PKG_CONFIG_PATH environment variable
 | Package 'gtk+-3.0', required by 'input-pad', not found

libinput-pad-dev is depending on 
 * libinput-pad1 and
 * libgtk2.0-dev (Hmmm... this is strange.)

libinput-pad1 is depending on 
 * libgtk-3-0(So you should have this in chroot)

So in clean chroot with all the dependency installed, you have
libgtk-3-0 but no gtk+-3.0.pc file from libgtk-3-dev.

 this happens as input-pad is built against gtk3, while ibus-input-pad is 
 currently built against gtk2, and a clean buildd chroot has no gtk3 
 installed.

I thought I can keep ibus-input-pad in gtk2 while input-pad as gtk3.  That
is what I did. 

 This means there are two possible solutions
 a) switch also ibus-input-pad to gtk3  ** I do not mind doing this **
** as next step **
 b) switch back input-pad to gtk2 (and reassign this bug to it)

I think what is needed is:
  * Change dependency of libinput-pad-dev to libgtk-3-dev

This is a bug to be fixed.

(I do not know how I got away with build using cowbuilder)

Osamu


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#724226: [Pkg-ime-devel] Bug#724226: input-pad = 1.0.2-1 breaks ibus-input-pad

2013-10-05 Thread Pino Toscano
Hi,

In data domenica 6 ottobre 2013 02:16:46, Osamu Aoki ha scritto:
 control: reassign 724226 libinput-pad-dev
 control: retitle  724226 libinput-pad-dev: Should depend on
 libgtk-3-dev (not libgtk2.0-dev)

I think this is not enough (and might be harmful), see below.

 On Sat, Oct 05, 2013 at 03:03:19PM +0200, Pino Toscano wrote:
  the problem is due to input-pad 1.0.2-1 switching to gtk3 instead of
 
  gtk2:
 Yes, I switched input-pad to use gtk3.

... without taking into account what possible gtk version is used by 
users of libinput-pad.

  this happens as input-pad is built against gtk3, while
  ibus-input-pad is currently built against gtk2, and a clean buildd
  chroot has no gtk3 installed.
 
 I thought I can keep ibus-input-pad in gtk2 while input-pad as gtk3. 
 That is what I did.

So there is the ibus-setup-input-pad binary (built as part of
src:ibus-input-pad) which is directly linked to gtk2 (as specified by 
its build dependencies) and libinput-pad, which is linked to gtk3.

This poses two major issues:
1) gtk2 and gtk3 are not loadable in the same process, meaning
   ibus-setup-input-pad won't ever run (crash due to symbols conflict)
2) the build CFLAGS include both gtk2 (direct dependency) and gtk3
   (part of the libinput-pad CFLAGS), so there's a build clash

So...

 I think what is needed is:
   * Change dependency of libinput-pad-dev to libgtk-3-dev

... this is indeed the wrong fix, if it is the only change you are 
planning to do right now. Again,

  This means there are two possible solutions
  a) switch also ibus-input-pad to gtk3 
  b) switch back input-pad to gtk2 (and reassign this bug to it)

... because both input-pad and ibus-input-pad must use the *same* gtk 
version, be it gtk2 or gtk3, to avoid this clash.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.