Bug#735237: [python-weberror] non sourced minified javascript

[Paul Wise]

Some more information about this from IRC:

 p1otr: could you fix #735237? it is blocking other packages from
migrating and there is a patch in the BTS
 pabs: a) removing file via patch doesn't change the fact that
file is still in the tarball (so it's not a fix) b) I don't consider it
a bug c) Sphinx authors made us a favor and will not generate minified
versions anymore so we simply have to wait for new upstream release of
sphinx and other upstreams to catch up
 in other words: I will "fix" "sphix generated minified
javascript files"  bugs only by uploading new upstream releases
 if you have time, feel free to provide get-orig-source and
upload
 I see

https://bitbucket.org/birkenfeld/sphinx/issue/1434/provide-non-minified-options-for-jqueryjs

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

Bug#735237: [python-weberror] non sourced minified javascript

[Federico Ceratto]

Package: src:python-weberror
Followup-For: Bug #735237

Hello,

Here is a simple patch that should fix the bug.
>From the changelog:

  * Add patch to remove embedded minified JS (Closes: #735237)
  * Bump Standards-Version to 3.9.5 (no changes needed)
  * Add Pybuild dependencies
  * Install evaldemo.py example


Bye,
Federico

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (600, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 5926d995133d15fcf6606f7cd0cdca54c002c6d1 Mon Sep 17 00:00:00 2001
From: Federico Ceratto 
Date: Mon, 21 Apr 2014 19:37:36 +0100
Subject: [PATCH 1/1] Patch

---
 debian/changelog   |  6 ++
 debian/control |  8 +---
 ...001-Remove-embedded-and-minified-JS-files.patch | 22 ++
 debian/patches/series  |  1 +
 debian/python-weberror.examples|  1 +
 debian/python-weberror.links   |  1 +
 debian/rules   | 11 +--
 7 files changed, 41 insertions(+), 9 deletions(-)
 create mode 100644 debian/patches/0001-Remove-embedded-and-minified-JS-files.patch
 create mode 100644 debian/patches/series
 create mode 100644 debian/python-weberror.examples
 create mode 100644 debian/python-weberror.links

diff --git a/debian/changelog b/debian/changelog
index 9026481..d08a8f7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,12 @@ python-weberror (0.10.3-2) UNRELEASED; urgency=low
   * Bump debhelper version to 9
   * debian/rules: Use dh
 
+  [ Federico Ceratto ]
+  * Add patch to remove embedded minified JS (Closes: #735237)
+  * Bump Standards-Version to 3.9.5 (no changes needed)
+  * Add Pybuild dependencies
+  * Install evaldemo.py example
+
  -- Jackson Doak   Fri, 28 Feb 2014 19:34:24 +1100
 
 python-weberror (0.10.3-1) unstable; urgency=low
diff --git a/debian/control b/debian/control
index 8129841..6c665f3 100644
--- a/debian/control
+++ b/debian/control
@@ -3,11 +3,12 @@ Section: python
 Priority: optional
 Maintainer: Debian Python Modules Team 
 Uploaders: Christoph Haas , Piotr Ożarowski 
-Build-Depends: debhelper (>= 9)
+Build-Depends: debhelper (>= 9~)
 Build-Depends-Indep: python (>= 2.3.3), python-setuptools (>= 0.6b3-1~),
+ dh-python, python-all,
  python-paste (>= 1.7.1), python-webob, python-tempita,
  python-pygments, python-nose, python-webtest
-Standards-Version: 3.9.2
+Standards-Version: 3.9.5
 X-Python-Version: >= 2.4
 Homepage: http://pypi.python.org/pypi/WebError
 Vcs-Svn: svn://anonscm.debian.org/python-modules/packages/python-weberror/trunk/
@@ -17,7 +18,8 @@ Package: python-weberror
 Architecture: all
 Depends: ${python:Depends}, ${misc:Depends},
  python-paste (>= 1.7.1), python-pastedeploy, python-pkg-resources,
- python (>= 2.6) | python-simplejson
+ python (>= 2.6) | python-simplejson,
+ libjs-jquery
 Description: Python web error handling and exception catching module
  This Python module provides error handling and exception catching
  functionality for WSGI web applications. It is primarily used by Pylons
diff --git a/debian/patches/0001-Remove-embedded-and-minified-JS-files.patch b/debian/patches/0001-Remove-embedded-and-minified-JS-files.patch
new file mode 100644
index 000..ada5454
--- /dev/null
+++ b/debian/patches/0001-Remove-embedded-and-minified-JS-files.patch
@@ -0,0 +1,22 @@
+From: Federico Ceratto 
+Date: Sun, 16 Mar 2014 12:47:38 +
+Subject: Remove embedded and minified JS files.
+
+---
+ weberror/eval_template.html | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/weberror/eval_template.html b/weberror/eval_template.html
+index cdb772a..47e2d1d 100644
+--- a/weberror/eval_template.html
 b/weberror/eval_template.html
+@@ -96,7 +96,8 @@
+ 
+ 
+ 
+-
++
++
+ 
+ {{footer_html|html}}
+ 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000..31ac228
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-Remove-embedded-and-minified-JS-files.patch
diff --git a/debian/python-weberror.examples b/debian/python-weberror.examples
new file mode 100644
index 000..9204d39
--- /dev/null
+++ b/debian/python-weberror.examples
@@ -0,0 +1 @@
+tests/evaldemo.py
diff --git a/debian/python-weberror.links b/debian/python-weberror.links
new file mode 100644
index 000..5d7a136
--- /dev/null
+++ b/debian/python-weberror.links
@@ -0,0 +1 @@
+usr/share/javascript/jquery/jquery.min.js usr/share/pyshared/weberror/eval-media/jquery.js
diff --git a/debian/rules b/debian/rules
index 7dd0870..6915d11 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,15 +1,12 @@
 #!/usr/bin/make -f
-#export DH_VERBOSE=1
+export DH_VERBOSE=1
+package=python-weberror
 
 override_dh_clean:
 	rm

Bug#735237: [python-weberror] non sourced minified javascript

[Ben Finney]

On 13-Jan-2014, bastien ROUCARIES wrote:
> I could not find the source for:
> weberror/eval-media/jquery-1.2.1.min.js

Yes, that's a serious bug.

Even if this file had source, it is (I assume) a bundled third-party
library. That violates Debian Policy §4.13.

The package should not install that library at all, and instead should
“Depends: libjs-jquery” (at an appropriate version, if necessary).

If the package doesn't work with a latest jQuery (or at least the latest in
Debian), that is a separate bug that should be reported upstream and fixed.

-- 
 \ “I went to a fancy French restaurant called ‘Déjà Vu’. The head |
  `\  waiter said, ‘Don't I know you?’” —Steven Wright |
_o__)  |
Ben Finney 


signature.asc
Description: Digital signature

Bug#735237: [python-weberror] non sourced minified javascript

[bastien ROUCARIES]

Package: python-weberror
Severity: serious
x-cc-debug: ftpmas...@debian.org

I could not find the source for:
weberror/eval-media/jquery-1.2.1.min.js

Bastien


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org