Bug#758155: freerdp: FTFBFS allmost everywhere
tags 758257 + patch Hi, the attached debdiff contains two patches. The first one fixes the symbol errors reported in #758155. The optimized variants of the primitives are only used in the test suite and via function pointers in libfreerdp-primitives. So there is no need export the symbols. The patch hides these symbols. An updates symbols file for libfreerdp1 is also included. The second patch fixes #758257 by adding -lfreerdp-client to the pkg-config file. It would be nice if these patches could be applied soon so we can continue with our work preparing vlc 2.2 for Debian. Cheers -- Sebastian Ramacher signature.asc Description: Digital signature
Processed (with 5 errors): Re: Bug#758155: freerdp: FTFBFS allmost everywhere
Processing commands for cont...@bugs.debian.org: tags 758257 + patch Bug #758257 [libfreerdp-dev] libfreerdp-dev: missing -lfreerdp-client in pkg-config file Added tag(s) patch. Hi, Unknown command or malformed arguments to command. the attached debdiff contains two patches. The first one fixes the Unknown command or malformed arguments to command. symbol errors reported in #758155. The optimized variants of the Unknown command or malformed arguments to command. primitives are only used in the test suite and via function pointers in Unknown command or malformed arguments to command. libfreerdp-primitives. So there is no need export the symbols. The patch Unknown command or malformed arguments to command. Too many unknown commands, stopping here. Please contact me if you need assistance. -- 758257: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758257 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758155: freerdp: FTFBFS allmost everywhere
On 2014-08-17 16:10:23, Sebastian Ramacher wrote:
the attached debdiff contains two patches.
And here is the patch.
Cheers
--
Sebastian Ramacher
diff -Nru freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog
freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog
--- freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog 2014-08-12
00:34:33.0 +0200
+++ freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog 2014-08-17
16:03:32.0 +0200
@@ -1,3 +1,14 @@
+freerdp (1.1.0~git20140809.1.b07a5c1+dfsg-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches/1001-hide-sse-symbols.patch: Do not export optimized
+primitives. They do not need to be part of the public ABI. (Closes:
+#758155)
+ * debian/patches/1002-update-pkg-config-file.patch: Add missing
+-lfreerdp-client to pkg-config file. (Closes: #758257)
+
+ -- Sebastian Ramacher sramac...@debian.org Sun, 17 Aug 2014 13:04:04 +0200
+
freerdp (1.1.0~git20140809.1.b07a5c1+dfsg-2) unstable; urgency=medium
* debian/libfreerdp1.symbols:
diff -Nru freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols
freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols
--- freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols
2014-08-11 23:46:37.0 +0200
+++ freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols
2014-08-17 13:04:33.0 +0200
@@ -1777,21 +1777,6 @@
primitives_init_shift_opt@Base 1.1.0~beta1+git20130629
primitives_init_sign@Base 1.1.0~beta1+git20130629
primitives_init_sign_opt@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_RGBToRGB_16s8u_P3AC4R@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_RGBToYCbCr_16s16s_P3P3@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_alphaComp_argb@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_lShiftC_16s@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_lShiftC_16u@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_rShiftC_16s@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_rShiftC_16u@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_set_32s@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_set_32u@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_set_8u@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse2_yCbCrToRGB_16s16s_P3P3@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse3_add_16s@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse3_andC_32u@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)sse3_orC_32u@Base 1.1.0~beta1+git20130629
- (arch=!ppc64el)ssse3_sign_16s@Base 1.1.0~beta1+git20130629
libfreerdp-rail.so.1.1 libfreerdp1 #MINVER#
icon_cache_free@Base 1.1.0~beta1+git20130629
icon_cache_get@Base 1.1.0~beta1+git20130629
diff -Nru
freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-sse-symbols.patch
freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-sse-symbols.patch
---
freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-sse-symbols.patch
1970-01-01 01:00:00.0 +0100
+++
freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-sse-symbols.patch
2014-08-17 15:58:22.0 +0200
@@ -0,0 +1,178 @@
+Description: Do not export optimized implementations of the primitives
+ They are only used in the test suite and via function pointers. There is no
+ need to expose them via the public ABI of libfreerdp-primitives.
+Author: Sebastian Ramacher sramac...@debian.org
+Last-Update: 2014-08-17
+
+--- a/libfreerdp/primitives/prim_templates.h
b/libfreerdp/primitives/prim_templates.h
+@@ -20,6 +20,13 @@
+ #ifndef __PRIM_TEMPLATES_H_INCLUDED__
+ #define __PRIM_TEMPLATES_H_INCLUDED__
+
++
++#if __GNUC__ = 4
++ #define PRIMITIVES_HIDDEN __attribute__ ((visibility(hidden)))
++#else
++ #define PRIMITIVES_HIDDEN
++#endif
++
+ /* These are prototypes for SSE (potentially NEON) routines that do a
+ * simple SSE operation over an array of data. Since so much of this
+ * code is shared except for the operation itself, these prototypes are
+@@ -44,7 +51,7 @@
+ * SCD = Source, Constant, Destination
+ */
+ #define SSE3_SCD_ROUTINE(_name_, _type_, _fallback_, _op_, _slowWay_) \
+-pstatus_t _name_(const _type_ *pSrc, INT32 val, _type_ *pDst, INT32 len) \
++PRIMITIVES_HIDDEN pstatus_t _name_(const _type_ *pSrc, INT32 val, _type_
*pDst, INT32 len) \
+ { \
+ int shifts; \
+ UINT32 offBeatMask; \
+@@ -188,7 +195,7 @@
+ * PRE = preload xmm0 with the constant.
+ */
+ #define SSE3_SCD_PRE_ROUTINE(_name_, _type_, _fallback_, _op_, _slowWay_) \
+-pstatus_t _name_(const _type_ *pSrc, _type_ val, _type_ *pDst, INT32 len) \
++PRIMITIVES_HIDDEN pstatus_t _name_(const _type_ *pSrc, _type_ val, _type_
*pDst, INT32 len) \
+ { \
+ int shifts; \
+ UINT32 offBeatMask; \
+@@ -293,7 +300,7 @@
+ * SSD = Source1, Source2, Destination
+ */
+ #define SSE3_SSD_ROUTINE(_name_, _type_, _fallback_, _op_, _slowWay_) \
+-pstatus_t _name_(const _type_ *pSrc1, const _type_ *pSrc2, _type_ *pDst,
Processed: Re: Bug#758155: freerdp: FTFBFS allmost everywhere
Processing commands for cont...@bugs.debian.org: tags 758155 + patch Bug #758155 [src:freerdp] freerdp: FTFBFS allmost everywhere Added tag(s) patch. thanks Stopping processing here. Please contact me if you need assistance. -- 758155: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758155 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#758155: freerdp: FTFBFS allmost everywhere
tags 758155 + patch thanks On 2014-08-17 16:11:16, Sebastian Ramacher wrote: On 2014-08-17 16:10:23, Sebastian Ramacher wrote: the attached debdiff contains two patches. And here is the patch. Attached is a new patch that also deals with the build issue on armhf. Cheers -- Sebastian Ramacher diff -Nru freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog --- freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog 2014-08-12 00:34:33.0 +0200 +++ freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/changelog 2014-08-17 20:12:12.0 +0200 @@ -1,3 +1,15 @@ +freerdp (1.1.0~git20140809.1.b07a5c1+dfsg-2.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * debian/patches/1001-hide-internal-symbols.patch: Hide internal symbols. +They do not need to be part of the public ABI. (Closes: #758155) + * debian/patches/1002-update-pkg-config-file.patch: Add missing +-lfreerdp-client to pkg-config file. (Closes: #758257) + * debian/rules: Build with -DARM_FP_ABI=hard on armhf. + * debian/libfreerdp1.symbols: Remove internal symbols. + + -- Sebastian Ramacher sramac...@debian.org Sun, 17 Aug 2014 13:04:04 +0200 + freerdp (1.1.0~git20140809.1.b07a5c1+dfsg-2) unstable; urgency=medium * debian/libfreerdp1.symbols: diff -Nru freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols --- freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols 2014-08-11 23:46:37.0 +0200 +++ freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/libfreerdp1.symbols 2014-08-17 17:35:25.0 +0200 @@ -328,7 +328,6 @@ nsc_context_new@Base 1.1.0~beta1+git20130629 nsc_context_set_pixel_format@Base 1.1.0~beta1+git20130629 nsc_encode@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)nsc_init_sse2@Base 1.1.0~beta1+git20130629 nsc_process_message@Base 1.1.0~beta1+git20130629 rdpsnd_compute_audio_time_length@Base 1.1.0~beta1+git20130629 rdpsnd_free_audio_formats@Base 1.1.0~beta1+git20130629 @@ -349,7 +348,6 @@ rfx_dwt_2d_decode@Base 1.1.0~beta1+git20130629 rfx_dwt_2d_encode@Base 1.1.0~beta1+git20130629 rfx_encode_rgb@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)rfx_init_sse2@Base 1.1.0~beta1+git20130629 rfx_message_free@Base 1.1.0~beta1+git20130629 rfx_message_get_rect@Base 1.1.0~beta1+git20130629 rfx_message_get_rect_count@Base 1.1.0~beta1+git20130629 @@ -1777,21 +1775,6 @@ primitives_init_shift_opt@Base 1.1.0~beta1+git20130629 primitives_init_sign@Base 1.1.0~beta1+git20130629 primitives_init_sign_opt@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_RGBToRGB_16s8u_P3AC4R@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_RGBToYCbCr_16s16s_P3P3@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_alphaComp_argb@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_lShiftC_16s@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_lShiftC_16u@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_rShiftC_16s@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_rShiftC_16u@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_set_32s@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_set_32u@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_set_8u@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse2_yCbCrToRGB_16s16s_P3P3@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse3_add_16s@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse3_andC_32u@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)sse3_orC_32u@Base 1.1.0~beta1+git20130629 - (arch=!ppc64el)ssse3_sign_16s@Base 1.1.0~beta1+git20130629 libfreerdp-rail.so.1.1 libfreerdp1 #MINVER# icon_cache_free@Base 1.1.0~beta1+git20130629 icon_cache_get@Base 1.1.0~beta1+git20130629 diff -Nru freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-internal-symbols.patch freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-internal-symbols.patch --- freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-internal-symbols.patch 1970-01-01 01:00:00.0 +0100 +++ freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/debian/patches/1001-hide-internal-symbols.patch 2014-08-17 20:06:18.0 +0200 @@ -0,0 +1,242 @@ +Description: Hide internal functions + They are only used in the test suite and via function pointers. There is no + need to expose them via the public ABI of libfreerdp-primitives and + libfreerdp-codec. +Author: Sebastian Ramacher sramac...@debian.org +Last-Update: 2014-08-17 + +--- /dev/null b/libfreerdp/codec/codec_internal.h +@@ -0,0 +1,14 @@ ++#ifdef __GNUC__ ++# pragma once ++#endif ++ ++#ifndef __CODEC_INTERNAL_H_INCLUDED__ ++#define __CODEC_INTERNAL_H_INCLUDED__ ++ ++#if __GNUC__ = 4 ++ #define CODEC_HIDDEN __attribute__ ((visibility(hidden))) ++#else ++ #define CODEC_HIDDEN ++#endif ++ ++#endif /* !__CODEC_INTERNAL_H_INCLUDED__ */ +--- a/libfreerdp/codec/nsc_sse2.h b/libfreerdp/codec/nsc_sse2.h +@@ -21,8 +21,9 @@ +
Bug#758155: Bug#758257: Bug#758155: freerdp: FTFBFS allmost everywhere
Hi Sebastian, On So 17 Aug 2014 20:13:09 CEST, Sebastian Ramacher wrote: tags 758155 + patch thanks On 2014-08-17 16:11:16, Sebastian Ramacher wrote: On 2014-08-17 16:10:23, Sebastian Ramacher wrote: the attached debdiff contains two patches. And here is the patch. Attached is a new patch that also deals with the build issue on armhf. Cheers Thanks for this piece of work. I just uploaded -3 revision of current freerdp upstream Git snapshot. THANKS! Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb pgpf4AX0dnhNs.pgp Description: Digitale PGP-Signatur
Bug#758155: freerdp: FTFBFS allmost everywhere
Source: freerdp Version: 1.1.0~git20140809.1.b07a5c1+dfsg-2 Severity: serious Justification: fails to build from source (but built successfully in the past) freerdp failed to build everwhere except for amd64, i386 and kfreebsd-i386. On armhf it failed with | cd /«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/obj-arm-linux-gnueabihf/libfreerdp/primitives /usr/bin/cc -DCMAKE_BUILD_TYPE=None -DHAVE_CONFIG_H -Dfreerdp_primitives_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -g -DWINPR_EXPORTS -DFREERDP_EXPORTS -fPIC -I/«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/obj-arm-linux-gnueabihf -I/«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/obj-arm-linux-gnueabihf/include -I/«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/include -I/«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/winpr/include -I/«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/obj-arm-linux-gnueabihf/winpr/include -mfpu=neon -mfloat-abi=softfp -o CMakeFiles/freerdp-primitives.dir/prim_add_opt.c.o -c /«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/libfreerdp/primitives/prim_add_opt.c | In file included from /usr/include/features.h:398:0, | from /usr/include/wchar.h:27, | from /«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/winpr/include/winpr/wtypes.h:26, | from /«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/include/freerdp/types.h:24, | from /«BUILDDIR»/freerdp-1.1.0~git20140809.1.b07a5c1+dfsg/libfreerdp/primitives/prim_add_opt.c:21: | /usr/include/arm-linux-gnueabihf/gnu/stubs.h:7:29: fatal error: gnu/stubs-soft.h: No such file or directory | # include gnu/stubs-soft.h | ^ | compilation terminated. | make[3]: *** [libfreerdp/primitives/CMakeFiles/freerdp-primitives.dir/prim_add_opt.c.o] Error 1 On other architectures it failed with symbol errors. armel: | --- debian/libfreerdp1.symbols (libfreerdp1_1.1.0~git20140809.1.b07a5c1+dfsg-2_armel) | +++ dpkg-gensymbolsMX0zDO 2014-08-11 23:30:57.059574519 + | @@ -328,7 +328,7 @@ | nsc_context_new@Base 1.1.0~beta1+git20130629 | nsc_context_set_pixel_format@Base 1.1.0~beta1+git20130629 | nsc_encode@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)nsc_init_sse2@Base 1.1.0~beta1+git20130629 | +#MISSING: 1.1.0~git20140809.1.b07a5c1+dfsg-2# (arch=!ppc64el)nsc_init_sse2@Base 1.1.0~beta1+git20130629 | nsc_process_message@Base 1.1.0~beta1+git20130629 | rdpsnd_compute_audio_time_length@Base 1.1.0~beta1+git20130629 | rdpsnd_free_audio_formats@Base 1.1.0~beta1+git20130629 | @@ -347,9 +347,11 @@ | rfx_differential_decode@Base 1.1.0~beta1+git20130629 | rfx_differential_encode@Base 1.1.0~beta1+git20130629 | rfx_dwt_2d_decode@Base 1.1.0~beta1+git20130629 | + rfx_dwt_2d_decode_NEON@Base 1.1.0~git20140809.1.b07a5c1+dfsg-2 | rfx_dwt_2d_encode@Base 1.1.0~beta1+git20130629 | rfx_encode_rgb@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)rfx_init_sse2@Base 1.1.0~beta1+git20130629 | + rfx_init_neon@Base 1.1.0~git20140809.1.b07a5c1+dfsg-2 | +#MISSING: 1.1.0~git20140809.1.b07a5c1+dfsg-2# (arch=!ppc64el)rfx_init_sse2@Base 1.1.0~beta1+git20130629 | rfx_message_free@Base 1.1.0~beta1+git20130629 | rfx_message_get_rect@Base 1.1.0~beta1+git20130629 | rfx_message_get_rect_count@Base 1.1.0~beta1+git20130629 | @@ -358,6 +360,7 @@ | rfx_process_message@Base 1.1.0~beta1+git20130629 | rfx_process_message_tile_work_callback@Base 1.1.0~beta1+git20130629 | rfx_quantization_decode@Base 1.1.0~beta1+git20130629 | + rfx_quantization_decode_NEON@Base 1.1.0~git20140809.1.b07a5c1+dfsg-2 | rfx_quantization_encode@Base 1.1.0~beta1+git20130629 | rfx_rlgr_decode@Base 1.1.0~beta1+git20130629 | rfx_rlgr_encode@Base 1.1.0~beta1+git20130629 | @@ -1751,6 +1754,7 @@ | general_sign_16s@Base 1.1.0~beta1+git20130629 | general_yCbCrToRGB_16s16s_P3P3@Base 1.1.0~beta1+git20130629 | general_zero@Base 1.1.0~beta1+git20130629 | + neon_yCbCrToRGB_16s16s_P3P3@Base 1.1.0~git20140809.1.b07a5c1+dfsg-2 | primitives_deinit@Base 1.1.0~beta1+git20130629 | primitives_deinit_add@Base 1.1.0~beta1+git20130629 | primitives_deinit_alphaComp@Base 1.1.0~beta1+git20130629 | @@ -1777,21 +1781,21 @@ | primitives_init_shift_opt@Base 1.1.0~beta1+git20130629 | primitives_init_sign@Base 1.1.0~beta1+git20130629 | primitives_init_sign_opt@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)sse2_RGBToRGB_16s8u_P3AC4R@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)sse2_RGBToYCbCr_16s16s_P3P3@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)sse2_alphaComp_argb@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)sse2_lShiftC_16s@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)sse2_lShiftC_16u@Base 1.1.0~beta1+git20130629 | - (arch=!ppc64el)sse2_rShiftC_16s@Base 1.1.0~beta1+git20130629 | -
