Bug#770941: nova-common - Overrides database config in nova.conf

2014-12-02 Thread Bastian Blank 
Control: tags -1 patch
Control: reopen 770944

On Tue, Nov 25, 2014 at 12:37:56PM +0100, Bastian Blank wrote:
 This violates §10.7.3 of the Debian policy: local changes must be
 preserved.

Patch that never resets the connection setting on upgrade.

Bastian

-- 
Bastian Blank
Berater
Telefon: +49 2161 / 4643-194
E-Mail: bastian.bl...@credativ.de
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
diff -Nru nova-2014.1.3/debian/changelog nova-2014.1.3/debian/changelog
--- nova-2014.1.3/debian/changelog  2014-11-11 20:52:52.0 +
+++ nova-2014.1.3/debian/changelog  2014-12-02 12:20:03.0 +
@@ -1,3 +1,9 @@
+nova (2014.1.3-6dbc1) UNRELEASED; urgency=medium
+
+  * Don't reset database config.
+
+ -- Bastian Blank wa...@debian.org  Tue, 02 Dec 2014 12:19:45 +
+
 nova (2014.1.3-6) unstable; urgency=high
 
   [ Mehdi Abaakouk ]
diff -Nru nova-2014.1.3/debian/nova-common.postinst.in 
nova-2014.1.3/debian/nova-common.postinst.in
--- nova-2014.1.3/debian/nova-common.postinst.in2014-11-11 
20:52:52.0 +
+++ nova-2014.1.3/debian/nova-common.postinst.in2014-12-02 
12:27:36.0 +
@@ -76,7 +76,9 @@
pkgos_write_new_conf nova logging.conf
 
# Tweak config files depending on debconf answers
-   pkgos_dbc_postinst /etc/nova/nova.conf database connection nova $@
+   if [ -z $2 ] || [ $1 = reconfigure ]; then
+   pkgos_dbc_postinst /etc/nova/nova.conf database connection nova 
$@
+   fi
pkgos_rabbit_write_conf /etc/nova/nova.conf DEFAULT nova
manage_nova_api_field
manage_nova_my_ip_field

Bug#770941: nova-common - Overrides database config in nova.conf

2014-11-25 Thread Bastian Blank 
Package: nova-common
Version: 2014.1.3-6
Severity: serious

A simple upgrade or re-install of nova-common overrides the database
settings in nova.conf:

| diff -ur nova/nova.conf /etc/nova/nova.conf
| --- nova/nova.conf  2014-10-02 15:09:04.672855761 +0200
| +++ /etc/nova/nova.conf 2014-11-25 12:02:37.194997496 +0100
| @@ -349,7 +349,7 @@
|  # DATABASE #
|  
|  [database]
| -connection = postgresql:///nova
| +connection = postgresql://novacommon:X@localhost/novadb
|  
|  
|  #

This violates §10.7.3 of the Debian policy: local changes must be
preserved.

Bastian

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-updates'), (500, 'unstable'), 
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770941: closed by Thomas Goirand z...@debian.org (Re: [PKG-Openstack-devel] Bug#770941: nova-common - Overrides database config in nova.conf)

2014-11-25 Thread Bastian Blank 
Control: reopen -1

On Tue, Nov 25, 2014 at 02:03:06PM +, Debian Bug Tracking System wrote:
 However, unless I'm mistaking, the above connection =
 postgresql:///nova is *not* a valide DSN, so it's not surprising that
 it got replaced. I don't consider this a bug, especially that there's
 all the logic in place to read an actual valid configuration.

It is a valid DSN.  And even if not, it must not change it.

Bastian

-- 
Bastian Blank
Berater
Telefon: +49 2161 / 4643-194
E-Mail: bastian.bl...@credativ.de
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Processed: Re: Bug#770941 closed by Thomas Goirand z...@debian.org (Re: [PKG-Openstack-devel] Bug#770941: nova-common - Overrides database config in nova.conf)

2014-11-25 Thread Debian Bug Tracking System 
Processing control commands:

 reopen -1
Bug #770941 {Done: Thomas Goirand z...@debian.org} [nova-common] nova-common 
- Overrides database config in nova.conf
Bug reopened
Ignoring request to alter fixed versions of bug #770941 to the same values 
previously set

-- 
770941: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770941
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org