Bug#784479: [kde4libs] Qt4's WebKit removal

[Paul Gevers]

Hi Scott,

On Tue, 15 Jan 2019 11:03:33 + Scott Kitterman
 wrote:

> I think rebuilding the rdepends is a reasonable next step.  I'll try
> that and see if anything is affected.

Did you get around to do this?

Paul



signature.asc
Description: OpenPGP digital signature

Bug#784479: [kde4libs] Qt4's WebKit removal

[Scott Kitterman]

On January 15, 2019 7:17:36 AM UTC, Pino Toscano  wrote:
>In data lunedì 14 gennaio 2019 12:22:52 CET, Scott Kitterman ha
>scritto:
>> On Thu, 01 Nov 2018 14:04:12 -0300 Lisandro 
>> =?ISO-8859-1?Q?Dami=E1n_Nicanor_P=E9rez?= Meyer
> wrote:
>> > On Wed, 17 Oct 2018 15:57:25 +0200 Ivo De Decker 
>wrote:
>> > > Hi,
>> > > 
>> > > On Fri, Nov 24, 2017 at 04:59:58PM -0300, Lisandro Damián Nicanor
>Pérez 
>> > Meyer wrote:
>> > > > Control: tag -1 patch
>> > > > 
>> > > > There is patch available for this at 
>> > > > >
>packages.git/tree/trunk/kdelibs-no-kdewebkit.patch?h=packages/kdelibs>
>> > > > 
>> > > > We might want to wait for the last tandem of KF5 apps though.
>> > > 
>> > > Is there anything still blocking this?
>> > 
>> > Yes, at least one co maintainer believes the kde-runtime patch is
>not 
>> > appropriate.
>> 
>> That patch no longer seems to be available, so I made my own. 
>Patches for 
>> kde4libs and kde-runtime attached.  I looked at the KDE4 packages
>still in 
>> Buster and I don't believe this interferes with anything.  This also
>fixes the 
>> FTBFS with Samba 4.9 by dropping the KDE4 kio_smb.
>
>The samba compatibility issue is a different story, and it can be fixed
>by just disabling kio_smb (in case it requires non-trivial work to make
>it work again).
>
>> I think we should move forward on these (or some improved version if
>someone 
>> has suggestions).
>> 
>> Even though there are separate bugs for kde-runtime, since the patch
>for it 
>> was already discussed in this bug, I thought we might as well keep
>them 
>> together.
>
>Did you check that all the packages using kde4libs still build fine?
>
>The removal of kio_thumbnail from kde-runtime is definitely not
>appropriate, since it will break the thunbnail support for any
>kdelibs 4.x application.
>
>Again: something worth to mention, since apparently it is not clear:
>removing bits from either kde4libs or kde-runtime has consequences,
>either build time or runtime ones. Randomly chopping pieces without
>checking what changes, and potentially what breaks, is generally a
>big no-no from me. I do not see how "remove qtwebkit" is an excuse to
>start messing up with packages, just for the sake of package removal.

I didn't do rebuild tests, but I did search using codesearch to see if any of 
the dropped headers or functions are used.  I didn't find anything.

I think rebuilding the rdepends is a reasonable next step.  I'll try that and 
see if anything is affected.

I understand your concern, but I don't think realeasing with a known pile of 
security vulnerabilities such as Qt4's WebKit is doing anyone any favors if it 
can be avoided.

Scott K

Bug#784479: [kde4libs] Qt4's WebKit removal

[Pino Toscano]

In data lunedì 14 gennaio 2019 22:28:46 CET, Adrian Bunk ha scritto:
> What is actually the overall plan for KDE4 in buster now?

kdelibs 4.x will stay in buster. Period.

Dropping stuff just for the sake of removal is a no-go, especially
when done from people who have NO IDEA about Qt/KDE
libraries/applications.

As I already asked you: Adrian Bunk, please stay away from Qt/KDE
stuff.

Thanks,
-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.

Bug#784479: [kde4libs] Qt4's WebKit removal

[Pino Toscano]

In data lunedì 14 gennaio 2019 12:22:52 CET, Scott Kitterman ha scritto:
> On Thu, 01 Nov 2018 14:04:12 -0300 Lisandro 
> =?ISO-8859-1?Q?Dami=E1n_Nicanor_P=E9rez?= Meyer  wrote:
> > On Wed, 17 Oct 2018 15:57:25 +0200 Ivo De Decker  wrote:
> > > Hi,
> > > 
> > > On Fri, Nov 24, 2017 at 04:59:58PM -0300, Lisandro Damián Nicanor Pérez 
> > Meyer wrote:
> > > > Control: tag -1 patch
> > > > 
> > > > There is patch available for this at 
>  > > > packages.git/tree/trunk/kdelibs-no-kdewebkit.patch?h=packages/kdelibs>
> > > > 
> > > > We might want to wait for the last tandem of KF5 apps though.
> > > 
> > > Is there anything still blocking this?
> > 
> > Yes, at least one co maintainer believes the kde-runtime patch is not 
> > appropriate.
> 
> That patch no longer seems to be available, so I made my own.  Patches for 
> kde4libs and kde-runtime attached.  I looked at the KDE4 packages still in 
> Buster and I don't believe this interferes with anything.  This also fixes 
> the 
> FTBFS with Samba 4.9 by dropping the KDE4 kio_smb.

The samba compatibility issue is a different story, and it can be fixed
by just disabling kio_smb (in case it requires non-trivial work to make
it work again).

> I think we should move forward on these (or some improved version if someone 
> has suggestions).
> 
> Even though there are separate bugs for kde-runtime, since the patch for it 
> was already discussed in this bug, I thought we might as well keep them 
> together.

Did you check that all the packages using kde4libs still build fine?

The removal of kio_thumbnail from kde-runtime is definitely not
appropriate, since it will break the thunbnail support for any
kdelibs 4.x application.

Again: something worth to mention, since apparently it is not clear:
removing bits from either kde4libs or kde-runtime has consequences,
either build time or runtime ones. Randomly chopping pieces without
checking what changes, and potentially what breaks, is generally a
big no-no from me. I do not see how "remove qtwebkit" is an excuse to
start messing up with packages, just for the sake of package removal.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.

Bug#784479: [kde4libs] Qt4's WebKit removal

[Adrian Bunk]

On Mon, Jan 14, 2019 at 06:22:52AM -0500, Scott Kitterman wrote:
> 
> That patch no longer seems to be available, so I made my own.  Patches for 
> kde4libs and kde-runtime attached.  I looked at the KDE4 packages still in 
> Buster and I don't believe this interferes with anything.  This also fixes 
> the 
> FTBFS with Samba 4.9 by dropping the KDE4 kio_smb.
> 
> I think we should move forward on these (or some improved version if someone 
> has suggestions).
> 
> Even though there are separate bugs for kde-runtime, since the patch for it 
> was already discussed in this bug, I thought we might as well keep them 
> together.

What is actually the overall plan for KDE4 in buster now?

A year ago I was told that only qtwebkit should be removed at that 
point, and the rest of KDE4 later for buster.

Someone else told me they were planning to do it after updating
all KDE packages to the latest release.

No matter what advice I followed someone was yelling at me,
so I gave up working on that.

Looking at kde-runtime in buster:

# Broken Depends:
basket: basket
kaccessible: kaccessible
kamerka: kamerka
kcollectd: kcollectd
kdbg: kdbg
kdiff3: kdiff3
keurocalc: keurocalc
kmetronome: kmetronome
kmidimon: kmidimon
kmldonkey: kmldonkey
knutclient: knutclient
kopete: kopete
kover: kover
kppp: kppp
kprinter4: kprinter4
kradio4: kradio4
kredentials: kredentials
kremotecontrol: kremotecontrol
kscd: kscd
kvpnc: kvpnc
syncevolution: syncevolution-libs-kde

Making the bugs in these packages RC (some packages like kdbg or 
kmetronome already have Qt5 versions that someone might upload to
unstable) plus an upload of kopete from experimental to unstable,
that's what would be needed for complete removal of kde-runtime.

Complete removal of kde4libs would add another list of comparable size,
with no obvious blocker.

> Scott K

cu
Adrian

--

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#784479: [kde4libs] Qt4's WebKit removal

[Scott Kitterman]

On Thu, 01 Nov 2018 14:04:12 -0300 Lisandro 
=?ISO-8859-1?Q?Dami=E1n_Nicanor_P=E9rez?= Meyer  wrote:
> On Wed, 17 Oct 2018 15:57:25 +0200 Ivo De Decker  wrote:
> > Hi,
> > 
> > On Fri, Nov 24, 2017 at 04:59:58PM -0300, Lisandro Damián Nicanor Pérez 
> Meyer wrote:
> > > Control: tag -1 patch
> > > 
> > > There is patch available for this at 
 > > packages.git/tree/trunk/kdelibs-no-kdewebkit.patch?h=packages/kdelibs>
> > > 
> > > We might want to wait for the last tandem of KF5 apps though.
> > 
> > Is there anything still blocking this?
> 
> Yes, at least one co maintainer believes the kde-runtime patch is not 
> appropriate.

That patch no longer seems to be available, so I made my own.  Patches for 
kde4libs and kde-runtime attached.  I looked at the KDE4 packages still in 
Buster and I don't believe this interferes with anything.  This also fixes the 
FTBFS with Samba 4.9 by dropping the KDE4 kio_smb.

I think we should move forward on these (or some improved version if someone 
has suggestions).

Even though there are separate bugs for kde-runtime, since the patch for it 
was already discussed in this bug, I thought we might as well keep them 
together.

Scott Kdiff -Nru kde4libs-4.14.38/debian/changelog kde4libs-4.14.38/debian/changelog
--- kde4libs-4.14.38/debian/changelog	2018-12-01 08:29:23.0 -0500
+++ kde4libs-4.14.38/debian/changelog	2019-01-14 06:15:38.0 -0500
@@ -1,3 +1,17 @@
+kde4libs (4:4.14.38-4) UNRELEASED; urgency=medium
+
+  * Team upload.
+  * Drop support for Qt4 WebKit (Closes: #784479)
+- Drop build-depends
+- Add d/p/no_kdewebkit.patch to patch out building kdewebkit, kdewebkit
+  widgets, private/animablegraphicswebview, and widgets/webview
+- Drop libkdewebkit5 binary package
+- Build plasma3 without webkit
+- Update install files (verified header files that are no longer shipped
+  are not used elsewhere in Debian) 
+
+ -- Scott Kitterman   Mon, 14 Jan 2019 02:14:35 -0500
+
 kde4libs (4:4.14.38-3) unstable; urgency=medium
 
   * Team upload
diff -Nru kde4libs-4.14.38/debian/control kde4libs-4.14.38/debian/control
--- kde4libs-4.14.38/debian/control	2018-12-01 08:29:07.0 -0500
+++ kde4libs-4.14.38/debian/control	2019-01-14 06:11:58.0 -0500
@@ -37,7 +37,6 @@
libqca2-dev (>= 2.0.0),
libqt4-dev (>= 4:4.8.0),
libqt4-opengl-dev (>= 4:4.8.0),
-   libqtwebkit-dev,
libsm-dev,
libssl-dev (>= 1.1),
libudev-dev [linux-any],
@@ -374,14 +372,6 @@
  .
  This library is part of the KDE Development Platform libraries module.
 
-Package: libkdewebkit5
-Architecture: any
-Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: KDE WebKit Library
- This library provides KDE integration of the QtWebKit library.
- .
- This package is part of the KDE Development Platform libraries module.
-
 Package: libkcmutils4
 Architecture: any
 Depends: ${misc:Depends}, ${shlibs:Depends}
diff -Nru kde4libs-4.14.38/debian/kdelibs5-dev.install kde4libs-4.14.38/debian/kdelibs5-dev.install
--- kde4libs-4.14.38/debian/kdelibs5-dev.install	2018-12-01 04:19:39.0 -0500
+++ kde4libs-4.14.38/debian/kdelibs5-dev.install	2019-01-14 05:32:55.0 -0500
@@ -1175,7 +1175,6 @@
 usr/include/kdeui_export.h
 usr/include/kdeversion.h
 usr/include/kdevicelistmodel.h
-usr/include/kdewebkit_export.h
 usr/include/kdialog.h
 usr/include/kdialogbuttonbox.h
 usr/include/kdialogjobuidelegate.h
@@ -1246,7 +1245,6 @@
 usr/include/kglobalsettings.h
 usr/include/kglobalshortcutinfo.h
 usr/include/kglobalshortcutinfo_p.h
-usr/include/kgraphicswebview.h
 usr/include/kguiitem.h
 usr/include/khbox.h
 usr/include/khelpmenu.h
@@ -1640,10 +1638,6 @@
 usr/include/kviewstatemaintainer.h
 usr/include/kviewstatesaver.h
 usr/include/kwallet.h
-usr/include/kwebpage.h
-usr/include/kwebpluginfactory.h
-usr/include/kwebview.h
-usr/include/kwebwallet.h
 usr/include/kwidgetitemdelegate.h
 usr/include/kwidgetjobtracker.h
 usr/include/kwindowinfo.h
@@ -1748,7 +1742,6 @@
 usr/include/plasma/widgets/toolbutton.h
 usr/include/plasma/widgets/treeview.h
 usr/include/plasma/widgets/videowidget.h
-usr/include/plasma/widgets/webview.h
 usr/include/plasma/windoweffects.h
 usr/include/predicateproperties.h
 usr/include/qtest_kde.h
@@ -1816,7 +1809,6 @@
 usr/lib/libkdefakes.so
 usr/lib/libkdesu.so
 usr/lib/libkdeui.so
-usr/lib/libkdewebkit.so
 usr/lib/libkdnssd.so
 usr/lib/libkemoticons.so
 usr/lib/libkfile.so
diff -Nru kde4libs-4.14.38/debian/kdelibs5-plugins.install kde4libs-4.14.38/debian/kdelibs5-plugins.install
--- kde4libs-4.14.38/debian/kdelibs5-plugins.install	2018-12-01 04:19:39.0 -0500
+++ kde4libs-4.14.38/debian/kdelibs5-plugins.install	2019-01-14 05:29:54.0 -0500
@@ -1,6 +1,5 @@
 usr/lib/*/qt4/plugins/designer/kde3supportwidgets.so
 usr/lib/*/qt4/plugins/designer/kdedeprecated.so
-usr/lib/*/qt4/plugins/designer/kdewebkitwidgets.so
 

Bug#784479: [kde4libs] Qt4's WebKit removal

[Lisandro Damián Nicanor Pérez Meyer]

On Wed, 17 Oct 2018 15:57:25 +0200 Ivo De Decker  wrote:
> Hi,
> 
> On Fri, Nov 24, 2017 at 04:59:58PM -0300, Lisandro Damián Nicanor Pérez 
Meyer wrote:
> > Control: tag -1 patch
> > 
> > There is patch available for this at  > packages.git/tree/trunk/kdelibs-no-kdewebkit.patch?h=packages/kdelibs>
> > 
> > We might want to wait for the last tandem of KF5 apps though.
> 
> Is there anything still blocking this?

Yes, at least one co maintainer believes the kde-runtime patch is not 
appropriate.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.