Bug#784587: [Pkg-utopia-maintainers] Bug#784587: Bug#784587: network-manager: does not set up resolv.conf
Am 07.05.2015 um 19:30 schrieb Dan Williams: > On Thu, 2015-05-07 at 19:08 +0200, Michael Biebl wrote: >> Am 07.05.2015 um 18:09 schrieb Dan Williams: >>> In git master there is no longer fallback if resolvconf fails for some >>> reason; but the resolv.conf manager is now a config option. So we'd >>> expect distros to ship a sub-package that drops a config snippet >>> into /etc/NetworkManager/conf.d/ enabling resolvconf which also requires >>> the resolvconf package itself, so that when the config option is set, >>> resolvconf is always installed. We may need some tweaking of the >>> default handling here, but the idea is that if the user specifically >>> chose resolvconf and it fails, that should be a hard failure and NM >>> shouldn't be touching resolv.conf since the user told NM not to... >> >> I kind of liked the if-resolvconf-found-use-it behaviour. >> The new behaviour will be a bit icky if I go the subpackage route due to >> how conffiles are handled. >> conffiles (config files in /etc/) are not automatically removed by dpkg >> if the package is removed (they are only removed on purge). >> So if the user uninstalles (but doesn't purge) the sub-package, the >> conf.d snippet will stay around and he'll get resolv.conf failures >> because it's no longer guaranteed the resolvconf package is installed. > > Hmm, ok. I guess we'll have to allow fallback to writing resolvconf if > the executable doesn't exist. That would be nice, thanks! I think, it should only skip any fallbacks if rc-manager=resolvconf is explicitly set *and* the resolvconf binary does exist. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: Bug#784587: network-manager: does not set up resolv.conf
On Thu, 2015-05-07 at 19:08 +0200, Michael Biebl wrote: > Hi Dan! > > Am 07.05.2015 um 18:09 schrieb Dan Williams: > > On Thu, 2015-05-07 at 13:15 +0900, Norbert Preining wrote: > >> On Thu, 07 May 2015, Michael Biebl wrote: > >>> The attached patch should fix the issue. Will poke upstream for a review > >>> and upload tomorrow. > >> > >> Thanks for the quick fix! > > > > Got found and fixed yesterday in nm-1-0... > > Hm, I don't do any changes in the nm-1-0 related to that. Where those > fixes not pushed? Yeah, that was it. Pushed now. > > In git master there is no longer fallback if resolvconf fails for some > > reason; but the resolv.conf manager is now a config option. So we'd > > expect distros to ship a sub-package that drops a config snippet > > into /etc/NetworkManager/conf.d/ enabling resolvconf which also requires > > the resolvconf package itself, so that when the config option is set, > > resolvconf is always installed. We may need some tweaking of the > > default handling here, but the idea is that if the user specifically > > chose resolvconf and it fails, that should be a hard failure and NM > > shouldn't be touching resolv.conf since the user told NM not to... > > I kind of liked the if-resolvconf-found-use-it behaviour. > The new behaviour will be a bit icky if I go the subpackage route due to > how conffiles are handled. > conffiles (config files in /etc/) are not automatically removed by dpkg > if the package is removed (they are only removed on purge). > So if the user uninstalles (but doesn't purge) the sub-package, the > conf.d snippet will stay around and he'll get resolv.conf failures > because it's no longer guaranteed the resolvconf package is installed. Hmm, ok. I guess we'll have to allow fallback to writing resolvconf if the executable doesn't exist. dan -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: Bug#784587: Bug#784587: network-manager: does not set up resolv.conf
Am 07.05.2015 um 19:08 schrieb Michael Biebl: > Am 07.05.2015 um 18:09 schrieb Dan Williams: >> On Thu, 2015-05-07 at 13:15 +0900, Norbert Preining wrote: >>> On Thu, 07 May 2015, Michael Biebl wrote: The attached patch should fix the issue. Will poke upstream for a review and upload tomorrow. >>> >>> Thanks for the quick fix! >> >> Got found and fixed yesterday in nm-1-0... > > Hm, I don't do any changes in the nm-1-0 related to that. I don't *see* any changes in the nm-1-0 branch related to that. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: Bug#784587: network-manager: does not set up resolv.conf
Hi Dan! Am 07.05.2015 um 18:09 schrieb Dan Williams: > On Thu, 2015-05-07 at 13:15 +0900, Norbert Preining wrote: >> On Thu, 07 May 2015, Michael Biebl wrote: >>> The attached patch should fix the issue. Will poke upstream for a review >>> and upload tomorrow. >> >> Thanks for the quick fix! > > Got found and fixed yesterday in nm-1-0... Hm, I don't do any changes in the nm-1-0 related to that. Where those fixes not pushed? > In git master there is no longer fallback if resolvconf fails for some > reason; but the resolv.conf manager is now a config option. So we'd > expect distros to ship a sub-package that drops a config snippet > into /etc/NetworkManager/conf.d/ enabling resolvconf which also requires > the resolvconf package itself, so that when the config option is set, > resolvconf is always installed. We may need some tweaking of the > default handling here, but the idea is that if the user specifically > chose resolvconf and it fails, that should be a hard failure and NM > shouldn't be touching resolv.conf since the user told NM not to... I kind of liked the if-resolvconf-found-use-it behaviour. The new behaviour will be a bit icky if I go the subpackage route due to how conffiles are handled. conffiles (config files in /etc/) are not automatically removed by dpkg if the package is removed (they are only removed on purge). So if the user uninstalles (but doesn't purge) the sub-package, the conf.d snippet will stay around and he'll get resolv.conf failures because it's no longer guaranteed the resolvconf package is installed. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
On Thu, 2015-05-07 at 13:15 +0900, Norbert Preining wrote: > On Thu, 07 May 2015, Michael Biebl wrote: > > The attached patch should fix the issue. Will poke upstream for a review > > and upload tomorrow. > > Thanks for the quick fix! Got found and fixed yesterday in nm-1-0... In git master there is no longer fallback if resolvconf fails for some reason; but the resolv.conf manager is now a config option. So we'd expect distros to ship a sub-package that drops a config snippet into /etc/NetworkManager/conf.d/ enabling resolvconf which also requires the resolvconf package itself, so that when the config option is set, resolvconf is always installed. We may need some tweaking of the default handling here, but the idea is that if the user specifically chose resolvconf and it fails, that should be a hard failure and NM shouldn't be touching resolv.conf since the user told NM not to... Dan -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
On Thu, 07 May 2015, Michael Biebl wrote: > The attached patch should fix the issue. Will poke upstream for a review > and upload tomorrow. Thanks for the quick fix! Norbert PREINING, Norbert http://www.preining.info JAIST, Japan TeX Live & Debian Developer GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
On Thu, 07 May 2015 01:09:53 +0200 Michael Biebl wrote: > Control: tags -1 moreinfo > > Am 07.05.2015 um 01:00 schrieb Norbert Preining: > > Package: network-manager > > Version: 1.0.2-1 > > Severity: serious > > Justification: breaks conectivity > > > > Hi, > > > > today's update of NM broke connectivity. Even a restart of the system > > didn't bring it back. The reason is that /etc/resolv.conf was empty, > > containing only > > # Generated by NetworkManager > > without any other information. > > > > Checking the journal, I see that it *did* get a ns: > > NetworkManager[694]: address 10.0.0.18 > > NetworkManager[694]: plen 24 (255.255.255.0) > > NetworkManager[694]: gateway 10.0.0.1 > > NetworkManager[694]: server identifier 10.0.0.1 > > NetworkManager[694]: lease time 86400 > > NetworkManager[694]: nameserver '10.0.0.1' > > and manually adding the name server fixed the problem. > > I'm having the same problem. > > Please provide more informatin about your network setup: > a/ which interfaces are managed by NM, which are managed elsewhere > (ifupdown) /e/n/i has only the loopback interface. All else is NM-managed (ethernet and wlan). > b/ please provide a verbose debug log of NetworkManager This was a bit large for possibly mass email and I was not sure if some private info would be there. It is available at people.debian.org:~fsateler/nm.log > Do you have any custom configuration in > /etc/NetworManager/NetworkManager.conf? [main] plugins=ifupdown,keyfile [ifupdown] managed=false -- Saludos Felipe Sateler -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Processed: Re: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
Processing control commands: > tags -1 = confirmed Bug #784587 [network-manager] network-manager: does not set up resolv.conf Added tag(s) confirmed; removed tag(s) moreinfo. -- 784587: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=784587 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
Control: tags -1 = confirmed
> On Thu, 07 May 2015 02:30:16 +0200 Michael Biebl wrote:
>> Am 07.05.2015 um 01:55 schrieb Michael Biebl:
>> > Am 07.05.2015 um 01:32 schrieb Andrea Capriotti:
>> >> # grep resolvconf /var/log/syslog
>> >> May 7 01:16:15 nb-capriotti NetworkManager[13437]: could
> not commit DNS changes: /sbin/resolvconf is not executable
>> >>
>> >> I fixed it installing resolvconf.
>> >
>> NM should fallback to non-resolvconf mode, if the resolvconf binary was
>> not found during runtime.
Actually, the faulty commit is ba593c9d9d2492e221e759fa5d54f2a04adf81d2
The attached patch should fix the issue. Will poke upstream for a review
and upload tomorrow.
I think we need to clear the GError before passing it on to
dispatch_netconfig() and update_resolv_conf().
Otherwise we might return an error even if update_resolv_conf() was
successful.
Then again, I don't quite see the point in setting error in
dispatch_resolvconf() and dispatch_netconfig() in the first place.
Maybe Dan can comment on this.
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff --git a/src/dns-manager/nm-dns-manager.c b/src/dns-manager/nm-dns-manager.c
index 21d1603..48b293e 100644
--- a/src/dns-manager/nm-dns-manager.c
+++ b/src/dns-manager/nm-dns-manager.c
@@ -782,13 +782,16 @@ update_dns (NMDnsManager *self,
#ifdef NETCONFIG_PATH
if (success == FALSE) {
+ g_clear_error (error);
success = dispatch_netconfig (searches, nameservers,
nis_domain, nis_servers, error);
}
#endif
- if (success == FALSE)
+ if (success == FALSE) {
+ g_clear_error (error);
success = update_resolv_conf (searches, nameservers, error);
+ }
/* signal that resolv.conf was changed */
if (success)
signature.asc
Description: OpenPGP digital signature
Bug#784587: network-manager: does not set up resolv.conf
On Thu, 07 May 2015 02:30:16 +0200 Michael Biebl wrote: > Am 07.05.2015 um 01:55 schrieb Michael Biebl: > > Am 07.05.2015 um 01:32 schrieb Andrea Capriotti: > >> On Thu, 07 May 2015 01:09:53 +0200 Michael Biebl wrote: > >>> Control: tags -1 moreinfo > >>> > >>> Please provide more informatin about your network setup: > >>> a/ which interfaces are managed by NM, which are managed elsewhere > >>> (ifupdown) > >>> b/ please provide a verbose debug log of NetworkManager > >> > >> Same problem here. > >> > >> # grep resolvconf /var/log/syslog > >> May 7 01:16:15 nb-capriotti NetworkManager[13437]: could not commit DNS changes: /sbin/resolvconf is not executable > >> > >> I fixed it installing resolvconf. > > > > That's not a fix. Please provide the information I requested. > > Maybe that provides some hint's what's going wrong. > > Do you have any custom configuration in > > /etc/NetworManager/NetworkManager.conf? > > I think I tracked this down. > > The Debian package builds with resolvconf support, in case users decide > to install resolvconf. > Due to this commit [1], this makes NM now assume that resolvconf is also > available during runtime, which is not the case by default on Debian. > That's obviously wrong. > NM should fallback to non-resolvconf mode, if the resolvconf binary was > not found during runtime. This is consistent with what I am seeing. Also, this may be of interest to you, there is a file /etc/resolv.conf.tmp on my system when resolvconf is not installed: # Generated by NetworkManager nameserver 192.168.1.1 Yet another workaround seems to be to copy this file over to /etc/resolv.conf to get temporary internet access to install resolvconf (if it is not in your apt cache). Best regards, -- Cameron Norman
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: Bug#784587: Bug#784587: network-manager: does not set up resolv.conf
Am 07.05.2015 um 01:55 schrieb Michael Biebl: > Am 07.05.2015 um 01:32 schrieb Andrea Capriotti: >> On Thu, 07 May 2015 01:09:53 +0200 Michael Biebl wrote: >>> Control: tags -1 moreinfo >>> >>> Please provide more informatin about your network setup: >>> a/ which interfaces are managed by NM, which are managed elsewhere >>> (ifupdown) >>> b/ please provide a verbose debug log of NetworkManager >> >> Same problem here. >> >> # grep resolvconf /var/log/syslog >> May 7 01:16:15 nb-capriotti NetworkManager[13437]: could not commit >> DNS changes: /sbin/resolvconf is not executable >> >> I fixed it installing resolvconf. > > That's not a fix. Please provide the information I requested. > Maybe that provides some hint's what's going wrong. > Do you have any custom configuration in > /etc/NetworManager/NetworkManager.conf? I think I tracked this down. The Debian package builds with resolvconf support, in case users decide to install resolvconf. Due to this commit [1], this makes NM now assume that resolvconf is also available during runtime, which is not the case by default on Debian. That's obviously wrong. NM should fallback to non-resolvconf mode, if the resolvconf binary was not found during runtime. Michael [1] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e573977b808409ccb26562ca8536d46be701f833 -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
> Please provide more informatin about your network setup: All answered by Andrea (thanks to him also for the solution) > May 7 01:16:15 nb-capriotti NetworkManager[13437]: could not commit > DNS changes: /sbin/resolvconf is not executable Same here. Norbert PREINING, Norbert http://www.preining.info JAIST, Japan TeX Live & Debian Developer GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: Bug#784587: network-manager: does not set up resolv.conf
Am 07.05.2015 um 01:32 schrieb Andrea Capriotti: > On Thu, 07 May 2015 01:09:53 +0200 Michael Biebl wrote: >> Control: tags -1 moreinfo >> >> Please provide more informatin about your network setup: >> a/ which interfaces are managed by NM, which are managed elsewhere >> (ifupdown) >> b/ please provide a verbose debug log of NetworkManager > > Same problem here. > > # grep resolvconf /var/log/syslog > May 7 01:16:15 nb-capriotti NetworkManager[13437]: could not commit > DNS changes: /sbin/resolvconf is not executable > > I fixed it installing resolvconf. That's not a fix. Please provide the information I requested. Maybe that provides some hint's what's going wrong. Do you have any custom configuration in /etc/NetworManager/NetworkManager.conf? -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
On Thu, 07 May 2015 01:09:53 +0200 Michael Biebl wrote: > Control: tags -1 moreinfo > > Please provide more informatin about your network setup: > a/ which interfaces are managed by NM, which are managed elsewhere > (ifupdown) > b/ please provide a verbose debug log of NetworkManager Same problem here. # grep resolvconf /var/log/syslog May 7 01:16:15 nb-capriotti NetworkManager[13437]: could not commit DNS changes: /sbin/resolvconf is not executable I fixed it installing resolvconf. Bye -- Andrea Capriotti -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
Control: tags -1 moreinfo Am 07.05.2015 um 01:00 schrieb Norbert Preining: > Package: network-manager > Version: 1.0.2-1 > Severity: serious > Justification: breaks conectivity > > Hi, > > today's update of NM broke connectivity. Even a restart of the system > didn't bring it back. The reason is that /etc/resolv.conf was empty, > containing only > # Generated by NetworkManager > without any other information. > > Checking the journal, I see that it *did* get a ns: > NetworkManager[694]: address 10.0.0.18 > NetworkManager[694]: plen 24 (255.255.255.0) > NetworkManager[694]: gateway 10.0.0.1 > NetworkManager[694]: server identifier 10.0.0.1 > NetworkManager[694]: lease time 86400 > NetworkManager[694]: nameserver '10.0.0.1' > and manually adding the name server fixed the problem. > Please provide more informatin about your network setup: a/ which interfaces are managed by NM, which are managed elsewhere (ifupdown) b/ please provide a verbose debug log of NetworkManager [1] https://wiki.gnome.org/Projects/NetworkManager/Debugging -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Processed: Re: [Pkg-utopia-maintainers] Bug#784587: network-manager: does not set up resolv.conf
Processing control commands: > tags -1 moreinfo Bug #784587 [network-manager] network-manager: does not set up resolv.conf Added tag(s) moreinfo. -- 784587: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=784587 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#784587: network-manager: does not set up resolv.conf
Package: network-manager Version: 1.0.2-1 Severity: serious Justification: breaks conectivity Hi, today's update of NM broke connectivity. Even a restart of the system didn't bring it back. The reason is that /etc/resolv.conf was empty, containing only # Generated by NetworkManager without any other information. Checking the journal, I see that it *did* get a ns: NetworkManager[694]: address 10.0.0.18 NetworkManager[694]: plen 24 (255.255.255.0) NetworkManager[694]: gateway 10.0.0.1 NetworkManager[694]: server identifier 10.0.0.1 NetworkManager[694]: lease time 86400 NetworkManager[694]: nameserver '10.0.0.1' and manually adding the name server fixed the problem. Since this breaks connectivity (think about a remote server that suddently is offline), this is serious bug. Thanks Norbert -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (200, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.1.0-rc2 (SMP w/4 CPU cores; PREEMPT) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages network-manager depends on: ii adduser3.113+nmu3 ii dbus 1.8.16-1 ii init-system-helpers1.23 ii isc-dhcp-client4.3.1-6 ii libbluetooth3 5.23-2+b1 ii libc6 2.19-18 ii libdbus-1-31.8.16-1 ii libdbus-glib-1-2 0.102-1 ii libgcrypt201.6.3-2 ii libglib2.0-0 2.44.0-2 ii libgnutls-deb0-28 3.3.15-2 ii libgudev-1.0-0 215-17 ii libmm-glib01.4.0-1 ii libndp01.4-2 ii libnewt0.520.52.17-1+b1 ii libnl-3-2003.2.24-2 ii libnl-genl-3-200 3.2.24-2 ii libnl-route-3-200 3.2.24-2 ii libnm0 1.0.2-1 ii libpam-systemd 215-17 ii libpolkit-agent-1-00.105-8 ii libpolkit-gobject-1-0 0.105-8 ii libreadline6 6.3-8+b3 ii libsoup2.4-1 2.48.0-1 ii libsystemd0215-17 ii libteamdctl0 1.17-1 ii libuuid1 2.25.2-6 ii lsb-base 4.1+Debian13+nmu1 ii policykit-10.105-8 ii udev 215-17 ii wpasupplicant 2.3-2 Versions of packages network-manager recommends: ii crda3.13-1 pn dnsmasq-base ii iptables1.4.21-2+b1 ii iputils-arping 3:20121221-5+b2 ii modemmanager1.4.0-1 pn ppp Versions of packages network-manager suggests: pn avahi-autoipd pn libteam-utils -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
