Bug#785281: [pkg-php-pear] Bug#785281: Bug#785281: Split phpseclib?
2015-05-16 22:10 GMT+02:00 David Prévot : > Hi Mathieu, Hi David, > On Sat, May 16, 2015 at 09:22:48PM +0200, Mathieu Parent wrote: >> 2015-05-16 20:58 GMT+02:00 David Prévot : > >> 3./ The php-phpseclib should "provide" all the libraries it ships. >> This would be the proper fix for #785281. > >> I prefer the "fake provide" solution, maybe "provides: >> php-math-biginteger (= 1.0.2+phpseclib)" ? > > Sure, done. I added the other provides (php-seclib, as well as the 19 > php-seclib-* packages from the phpseclib channel you pointed earlier) > versionless, please shout (or directly fix in the VCS) if you prefer > versioned Provides (not that I mind about seeing #761219 fixed first, > but if versions are not needed, no need to add them). > > Upload in progress, you should be able to test it from incoming in a few > minutes (I successfully installed php-horde-mapi with php-seclib, but > didn’t test if it actually works). Seems to work (but I don't have access to a MAPI server for complete test). I've asked for removal of php-math-biginteger. Reards -- Mathieu -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#785281: [pkg-php-pear] Bug#785281: Bug#785281: Split phpseclib?
Hi Mathieu, On Sat, May 16, 2015 at 09:22:48PM +0200, Mathieu Parent wrote: > 2015-05-16 20:58 GMT+02:00 David Prévot : > 3./ The php-phpseclib should "provide" all the libraries it ships. > This would be the proper fix for #785281. > I prefer the "fake provide" solution, maybe "provides: > php-math-biginteger (= 1.0.2+phpseclib)" ? Sure, done. I added the other provides (php-seclib, as well as the 19 php-seclib-* packages from the phpseclib channel you pointed earlier) versionless, please shout (or directly fix in the VCS) if you prefer versioned Provides (not that I mind about seeing #761219 fixed first, but if versions are not needed, no need to add them). Upload in progress, you should be able to test it from incoming in a few minutes (I successfully installed php-horde-mapi with php-seclib, but didn’t test if it actually works). Regards David signature.asc Description: Digital signature
Bug#785281: [pkg-php-pear] Bug#785281: Bug#785281: Split phpseclib?
2015-05-16 20:58 GMT+02:00 David Prévot :
> Hi Mathieu,
Hi David,
3./ The php-phpseclib should "provide" all the libraries it ships.
This would be the proper fix for #785281.
>>
>> Digging a bit, this would not be the proper fix for #785281.
>>
>> Here is an extract from the diff:
>> * Here's an example of how to use this library:
>> *
>> * > - *include('Math/BigInteger.php');
>> - *
>> - *$a = new Math_BigInteger(2);
>> - *$b = new Math_BigInteger(3);
>> + *$a = new \phpseclib\Math\BigInteger(2);
>> + *$b = new \phpseclib\Math\BigInteger(3);
>> [...]
>> +namespace phpseclib\Math;
>> [...]
>>
>> Those are two different classes, with different namespaces.
>
> I can’t see such difference between the currently packaged phpseclib and
> php-math-biginteger. The namespaces change is supposed to happen in the
> next 1. or 2. branch of phpseclib, but the latest upstream version as
> available in Debian, is not yet inside this new namespace.
OK.
> Ha, that reminds me of the “good old times” and
> …
I see.
>> It seems They should probably be installed at a different path:
>>
>> /usr/share/php/Math/BigInteger.php
>> /usr/share/php/phpseclib/Math/BigInteger.php
>
> Not yet, sorry.
Indeed.
>> I prefer that the files are moved. But this may be a painfull transition.
>
> One we’ll have to take care anyway, but I don’t intend to start it before
> upstream publish a stable release with the new namespase (not even an
> alpha has been published yet).
>
>> I'd welcome if the phpseclib package Provides php-phpseclib-file-asn1
>
> Sure, I’ll had the others too, but the previous question still stands:
> should I
>> add another fake “provides: php-math-biginteger (= 1.0.2-3)” for example
>> (i.e., a bit higher than the current php-math-biginteger real package),
>> or [would] you […] patch php-horde-mapi to drop the versionned dependency
>> for php-math-biginteger.
> ?
I prefer the "fake provide" solution, maybe "provides:
php-math-biginteger (= 1.0.2+phpseclib)" ?
In parallel, I will remove php-math-integer source package from Debian.
Regards
--
Mathieu
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#785281: [pkg-php-pear] Bug#785281: Split phpseclib?
Hi Mathieu,
>>> 3./ The php-phpseclib should "provide" all the libraries it ships.
>>> This would be the proper fix for #785281.
>
> Digging a bit, this would not be the proper fix for #785281.
>
> Here is an extract from the diff:
> * Here's an example of how to use this library:
> *
> * - *include('Math/BigInteger.php');
> - *
> - *$a = new Math_BigInteger(2);
> - *$b = new Math_BigInteger(3);
> + *$a = new \phpseclib\Math\BigInteger(2);
> + *$b = new \phpseclib\Math\BigInteger(3);
> [...]
> +namespace phpseclib\Math;
> [...]
>
> Those are two different classes, with different namespaces.
I cant see such difference between the currently packaged phpseclib and
php-math-biginteger. The namespaces change is supposed to happen in the
next 1. or 2. branch of phpseclib, but the latest upstream version as
available in Debian, is not yet inside this new namespace.
Ha, that reminds me of the good old times and
> It seems They should probably be installed at a different path:
>
> /usr/share/php/Math/BigInteger.php
> /usr/share/php/phpseclib/Math/BigInteger.php
Not yet, sorry.
> I prefer that the files are moved. But this may be a painfull transition.
One well have to take care anyway, but I dont intend to start it before
upstream publish a stable release with the new namespase (not even an
alpha has been published yet).
> I'd welcome if the phpseclib package Provides php-phpseclib-file-asn1
Sure, Ill had the others too, but the previous question still stands:
should I
> add another fake provides: php-math-biginteger (= 1.0.2-3) for example
> (i.e., a bit higher than the current php-math-biginteger real package),
> or [would] you [
] patch php-horde-mapi to drop the versionned dependency
> for php-math-biginteger.
?
Regards
David
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#785281: [pkg-php-pear] Bug#785281: Split phpseclib?
2015-05-16 17:53 GMT+02:00 David Prévot : > [ Following up to #785281 only, all recipient should get the message > from it (once). ] > > Hi Mathieu, > > Le 16/05/2015 08:07, Mathieu Parent a écrit : > >> There are three problems here: > […] >> 2./ The current package name from composer should be php-phpseclib >> instead. I will file a bug about this. > > There is already #757537. If that’s enough, I can try and work on it. Yes, that would do it. >> 3./ The php-phpseclib should "provide" all the libraries it ships. >> This would be the proper fix for #785281. Digging a bit, this would not be the proper fix for #785281. Here is an extract from the diff: * Here's an example of how to use this library: * * Please let me know if you prefer me to add this additional hack into > phpseclib, or if you’re willing to drop the versionned dependency from > php-horde-mapi. I prefer that the files are moved. But this may be a painfull transition. I'd welcome if the phpseclib package Provides php-phpseclib-file-asn1 -- Mathieu -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#785281: Split phpseclib?
[ Following up to #785281 only, all recipient should get the message from it (once). ] Hi Mathieu, Le 16/05/2015 08:07, Mathieu Parent a écrit : > There are three problems here: […] > 2./ The current package name from composer should be php-phpseclib > instead. I will file a bug about this. There is already #757537. If that’s enough, I can try and work on it. > 3./ The php-phpseclib should "provide" all the libraries it ships. > This would be the proper fix for #785281. I can prepare that (with a temporary workaround for #757537 too). Since php-horde-mapi currently depends on php-math-biginteger (>= 1.0.2), php-math-biginteger (<< 2.0.0) (i.e. the older version from PEAR, but with a higher version), I’m not sure how we should move forward. A priori, versionless provides won’t be enough to satisfy the php-horde-mapi dependency, so just adding versionless provides for all the packages available from the phpseclib channel won’t be enough to fix this issue. Since versionless provides is not enough, using the phpseclib version (currently lower than 1) for all provided packages will not help satisfying the current php-horde-mapi dependency either. I could also add another fake “provides: php-math-biginteger (= 1.0.2-3)” for example (i.e., a bit higher than the current php-math-biginteger real package), or you could patch php-horde-mapi to drop the versionned dependency for php-math-biginteger. Please let me know if you prefer me to add this additional hack into phpseclib, or if you’re willing to drop the versionned dependency from php-horde-mapi. Regards David signature.asc Description: OpenPGP digital signature
Bug#785281: Split phpseclib?
Hello David, phpseclib is provided upstream in two shapes: Composer (monolithic) and PEAR (splitted, see PS). Debian currently ships one binary package built from composer. Some PEAR packages may depend on one particular package (this is currently the case for php-horde-imp which recommends FIle_ASN1, and for php-horde-mapi which depends on Math_BigInteger, see #785281). There are three problems here: 1./ The PEAR calculated package name is weird: phpseclib.sourceforge.net/File_ASN1 -> php-phpseclib-sourceforge-file-asn1 I will fix this in pkg-php-tools, to consider sourceforge.net like a TLD (we'll have php-phpseclib-file-asn1). This is #785446. 2./ The current package name from composer should be php-phpseclib instead. I will file a bug about this. 3./ The php-phpseclib should "provide" all the libraries it ships. This would be the proper fix for #785281. Regards -- Mathieu Parent PS: Here are the splitted packages $ sudo pear channel-add http://phpseclib.sourceforge.net/channel.xml Adding Channel "phpseclib.sourceforge.net" succeeded $ pear list-all -c phpseclib All packages [Channel phpseclib]: = PackageLatest Local phpseclib/Crypt_AES0.3.10 Pure-PHP implementation of AES phpseclib/Crypt_Base 0.3.10 Base class for symmetric key cryptographic algorithms phpseclib/Crypt_Blowfish 0.3.10 Pure-PHP implementation of Blowfish phpseclib/Crypt_DES0.3.10 Pure-PHP implementation of DES phpseclib/Crypt_Hash 0.3.10 Pure-PHP implementations of keyed-hash message authentication codes (HMACs) and various cryptographic hashing functions phpseclib/Crypt_Random 0.3.10 Random Number Generator phpseclib/Crypt_RC40.3.10 Pure-PHP implementation of RC4 phpseclib/Crypt_Rijndael 0.3.10 Pure-PHP implementation of Rijndael phpseclib/Crypt_RSA0.3.10 Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA phpseclib/Crypt_TripleDES 0.3.10 Pure-PHP implementation of Triple DES phpseclib/Crypt_Twofish0.3.10 Pure-PHP implementation of Twofish phpseclib/File_ANSI0.3.10 Pure-PHP ANSI decoder phpseclib/File_ASN10.3.10 Pure-PHP ASN1 parser phpseclib/File_X5090.3.10 Pure-PHP X.509 encoder / decoder phpseclib/Math_BigInteger 0.3.10 Pure-PHP arbitrary precision integer arithmetic library phpseclib/Net_SFTP 0.3.10 Pure-PHP implementation of SFTP phpseclib/Net_SSH1 0.3.10 Pure-PHP implementation of SSHv1 phpseclib/Net_SSH2 0.3.10 Pure-PHP implementation of SSHv2 phpseclib/System_SSH_Agent 0.3.10 Pure-PHP ssh-agent client -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
