Bug#788561: Bug RC #788561 (python3-memcache not Python 3 compatible)
On 07/05/2015 02:35 PM, Hugo Lefeuvre wrote: > Ces derniers temps, je me suis mis à travailler activement sur des bugs > RC pour pouvoir répondre à l'une de tes questions. Je suis donc tombé > sur le bug #788561[0] et ai commencé à y travailler... avant de me rendre > compte que tu t'y étais probablement déjà attelé. :-) Hi, This is typically the kind of message which you should write in English, because like that, I can forward it to the BTS. Indeed, I worked on this. At the time, there was no compat for Py3 upstream, and the Py3 support was added only by myself, with patches on top of the upstream code. However, what I did wasn't enough. > Seulement, je n'aurais pas exactement suivi la même méthodologie qu'il > me semble avoir été choisi ici: Ne penses tu pas qu'il serait bon de > supprimer ce paquet python3 injustifié assez rapidement, quitte à le > recréer dans un mois, quand l'upstream aura sorti sa nouvelle version ? The issue is there only in Jessie. In Sid, the situation is already much better, as the package now uses the latest commit from upstream plus this pull request: https://github.com/linsomniac/python-memcached/pull/67 I really wish we could say "let's wait for upstream", but in the case of this package, this is not really realistic, as upstream is too slow to respond. As you can see, the pull request finalizing the Py3 support has been waiting in github since the 23rd of april, without even a single reply from upstream. > Il me semble en effet que l'upstream n'est pas particulièrement pressé > dans l'intégration de la push request[1]... Indeed! > Sinon, il serait peut être possible d'appliquer la push request dans > debian sous forme de patch, que l'on enlèvera une fois la prochaine > version upstream libérée. C'est plus compliqué, mais cela permet > d'éviter la suppression de ce paquet. La tâche sera sûrement facilitée > par la suite. This has already been done in Sid, and therefore, it is my opinion that we should have one of the below action: 1/ Remove support for Py3 in Jessie, and ask the release team to approve that. I do believe that they will accept this. 2/ Ask for the release team to accept an update to the package version which is in Sid. It's very unlikely that they accept. If you want to work on one of these, it'd be great. But dealing with the release team for doing this type of fix in stable is famously difficult because: 1/ They are very busy 2/ They don't accept often big changes in already existing package, and you need to convince them. Both are very valid reasons and I don't blame the release team for that. BTW, the Debian BTS should be updated so that it shows the version in Sid isn't affected, otherwise indeed, we risk memcached to be removed from testing for a wrong reason. Can you do such update, with "fixed" and "found" commands to the BTS? Cheers, Thomas Goirand (zigo) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#788561: Bug RC #788561 (python3-memcache not Python 3 compatible)
Hi Thomas, > This has already been done in Sid, and therefore, it is my opinion that > we should have one of the below action: > 1/ Remove support for Py3 in Jessie, and ask the release team to approve > that. I do believe that they will accept this. > 2/ Ask for the release team to accept an update to the package version > which is in Sid. It's very unlikely that they accept. > > If you want to work on one of these, it'd be great. But dealing with the > release team for doing this type of fix in stable is famously difficult > because: > 1/ They are very busy > 2/ They don't accept often big changes in already existing package, and > you need to convince them. > > Both are very valid reasons and I don't blame the release team for that. I'd be glad to try to help you to fix this bug. I agree with the fact that it will be quite difficult to update Jessie with the version currently in Sid. A lot of changes have been made between 1.53 and 1.54; it will be really hard to prove that this new version won't introduce new bugs. So, the first solution seems to be much easier. Moreover, according to memcache's popcon[0], python3-memcache isn't downloaded a lot. So, it won't be prolematic to remove this package in Jessie, at least for the moment. Naturally, I think it's sad to lose memcache's Python 3 support on Jessie, but we must fix this bug, and the first solution seems to be the only realistic solution. Maybe that we could try to ask the release team for the second solution, and, if they do not accept, ask them for the first solution ? > BTW, the Debian BTS should be updated so that it shows the version in > Sid isn't affected, otherwise indeed, we risk memcached to be removed > from testing for a wrong reason. Can you do such update, with "fixed" > and "found" commands to the BTS? #788561 is now marked as fixed in 1.54+20150423+git+48e882719c-2. Is it enough ? Cheers, Hugo [0] https://qa.debian.org/popcon.php?package=python-memcache -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
Bug#788561: Bug RC #788561 (python3-memcache not Python 3 compatible)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 07/06/2015 01:10 AM, Hugo Lefeuvre wrote: > Hi Thomas, > >> This has already been done in Sid, and therefore, it is my opinion that >> we should have one of the below action: >> 1/ Remove support for Py3 in Jessie, and ask the release team to approve >> that. I do believe that they will accept this. >> 2/ Ask for the release team to accept an update to the package version >> which is in Sid. It's very unlikely that they accept. >> >> If you want to work on one of these, it'd be great. But dealing with the >> release team for doing this type of fix in stable is famously difficult >> because: >> 1/ They are very busy >> 2/ They don't accept often big changes in already existing package, and >> you need to convince them. >> >> Both are very valid reasons and I don't blame the release team for that. > > I'd be glad to try to help you to fix this bug. > > I agree with the fact that it will be quite difficult to update Jessie > with the version currently in Sid. A lot of changes have been made > between 1.53 and 1.54; it will be really hard to prove that this new > version won't introduce new bugs. > > So, the first solution seems to be much easier. Moreover, according to > memcache's popcon[0], python3-memcache isn't downloaded a lot. So, it > won't be prolematic to remove this package in Jessie, at least for the > moment. > > Naturally, I think it's sad to lose memcache's Python 3 support on Jessie, > but we must fix this bug, and the first solution seems to be the only > realistic solution. > > Maybe that we could try to ask the release team for the second solution, > and, if they do not accept, ask them for the first solution ? Yes, that's the way to go. I think it's better to go directly for the removal of python3-memcached in fact. > #788561 is now marked as fixed in 1.54+20150423+git+48e882719c-2. Is it > enough ? I believe so, yes. Cheers, Thomas Goirand (zigo) -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBCAAGBQJVnEqxAAoJENQWrRWsa0P+11sQAJuJnIZ34SSA6vs4c7Zki19B vNK0493SxdFmw9XlSsvmw9dKLkN6IzMzGcpFhLv3CZjn2F7q7pt8yvHS6mqzxRZk HVhz1QyGdYGu0oGbrYXJ++zpbvB+dArINq8FRIGaYaz5hPtjVKmrVFYoEHV4z7bs quKTbLV6eGXiZtKbVhUpnYufXylqFXysxwHO7P/qQKaf3h7k8SoYLTBCkbvJneX4 sLQuYZsYaj8bKOPhOtC0W5UosxMA+dSN6sQ+IYQCncOB8hbpCrpFO07+p0offlfF aexjnPWjBTNfb1iTmZG6r7qPHmnPAV8FQnbAd3+UIBAtGiVfBpLwxhGCY//Z1lGf dExddXhjaA65FlbJpILwpEtJluQyb7CgRUjtXqbL4uLC/Cz2/fZ6cF99pK1rj86g /NTOTChZYDPixQWZbc6otdYwFd8JuJAdXpyeh0wBxCISuCEz2pPSWB/GcZph96CH dMZDgzdycq5CeRDYoBA/5ZMNwO+/FrEw/irlBgywquKpROGaI8RvNrov3ZAeTJ5B NfWwE7l9kmnuDUxYSA5WLuq+5mDOCseFtJosQmB99Dn0duxu+4VVBJzoRulfulmi fEBom7uKHnWeMg1seNK1VunJgtcu0yq8BWyBYgpiGW+9+YbPUwSunKVFS820dkIg VkhtH/4yrnKM765/TvmT =r8D9 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#788561: Bug RC #788561 (python3-memcache not Python 3 compatible)
Hi Thomas,
> Yes, that's the way to go. I think it's better to go directly for the
> removal of python3-memcached in fact.
I've prepared the diff that I'd like to suggest to the release team.
Could you have a look at it ? The diff is in attachement.
I've decided to just make the package stops building python3-memcache. I
haven't reverted the upstream changes you made on the package; I think
it wouldn't be really useful, and it will surely make the backporting
process harder.
Thanks !
Cheers,
Hugo
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
--- a/debian/changelog 2015-07-13 11:00:34.426439594 +0200
+++ b/debian/changelog 2015-07-13 11:00:49.106419709 +0200
@@ -1,3 +1,12 @@
+python-memcache (1.53+2014.06.08.git.918e88c496-1+deb8u1) jessie;
urgency=medium
+
+ * Team upload.
+ * debian/control, debian/rules:
+ - Don't build python3-memcache anymore, upstream's Python3 support
+ is too incomplete (Closes: #788561).
+
+ -- Hugo Lefeuvre Sun, 12 Jul 2015 22:22:34 +0200
+
python-memcache (1.53+2014.06.08.git.918e88c496-1) unstable; urgency=medium
* New upstream release.
--- a/debian/control2015-07-13 11:00:34.426439594 +0200
+++ b/debian/control2015-07-13 11:00:34.422439599 +0200
@@ -5,9 +5,7 @@
Uploaders: Carl Chenet , Thomas Goirand
Build-Depends: debhelper (>= 9),
python-all (>= 2.6.6-3),
- python-setuptools,
- python3-all,
- python3-setuptools
+ python-setuptools
Standards-Version: 3.9.5
Homepage: http://www.tummy.com/Community/software/python-memcached/
Vcs-Svn:
svn://anonscm.debian.org/python-modules/packages/python-memcache/trunk/
@@ -23,14 +21,3 @@
one or more, possibly remote, memcached servers.
.
This package contains the Python 2.x module.
-
-Package: python3-memcache
-Architecture: all
-Depends: python3-six, ${misc:Depends}, ${python3:Depends}
-Suggests: memcached
-Description: pure python memcached client - Python 3.x
- This software is a 100% Python interface to the memcached memory cache daemon.
- It is the client side software which allows storing values in one or more,
- possibly remote, memcached servers.
- .
- This package contains the Python 3.x module.
--- a/debian/rules 2015-07-13 11:00:34.426439594 +0200
+++ b/debian/rules 2015-07-13 11:00:34.422439599 +0200
@@ -1,22 +1,17 @@
#!/usr/bin/make -f
PYTHONS:=$(shell pyversions -vr)
-PYTHON3S:=$(shell py3versions -vr)
UPSTREAM_GIT = git://github.com/linsomniac/python-memcached.git
%:
- dh $@ --buildsystem=python_distutils --with python2,python3
+ dh $@ --buildsystem=python_distutils --with python2
override_dh_install:
set -e && for pyvers in $(PYTHONS); do \
python$$pyvers setup.py install --install-layout=deb \
--root $(CURDIR)/debian/python-memcache; \
done
- set -e && for pyvers in $(PYTHON3S); do \
- python$$pyvers setup.py install --install-layout=deb \
- --root $(CURDIR)/debian/python3-memcache; \
- done
override_dh_clean:
dh_clean -O--buildsystem=python_distutils
signature.asc
Description: Digital signature
Bug#788561: Bug RC #788561 (python3-memcache not Python 3 compatible)
On 07/13/2015 11:02 AM, Hugo Lefeuvre wrote: > Hi Thomas, > >> Yes, that's the way to go. I think it's better to go directly for the >> removal of python3-memcached in fact. > > I've prepared the diff that I'd like to suggest to the release team. > Could you have a look at it ? The diff is in attachement. > > I've decided to just make the package stops building python3-memcache. I > haven't reverted the upstream changes you made on the package; I think > it wouldn't be really useful, and it will surely make the backporting > process harder. > > Thanks ! > > Cheers, > Hugo The diff looks ok, and I do support this. Please push it to the release team. I really think this is the most reasonable course of action we can do in Jessie. Cheers, Thomas Goirand (zigo) -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#788561: Bug RC #788561 (python3-memcache not Python 3 compatible)
Hi, > The diff looks ok, and I do support this. Please push it to the release > team. I really think this is the most reasonable course of action we can > do in Jessie. Done[0]. Cheers, Hugo [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=793117 -- Hugo Lefeuvre (hugo6390)|www.hugo6390.org 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E signature.asc Description: Digital signature
