Bug#793607: FTBFS against QT5

[Gianfranco Costamagna]

Hi Daniele, I would like to sponsor and fix the package.
Something that comes to my mind:
Drop all at build dependencies, drop insighttoolkit and so the package from non 
intel anche (please don't restrict to and and 8386 only, in case itk4 starts to 
build everywhere e.g. Like it does on Ubuntu)Fix the qt5 build
Drop cdbs (nice to have I really don't understand it)
I would like to sponsor the package in the next few days if possible, to see it 
in testing soon and in the next Ubuntu LTD
Cheers
G.

On Tue, 12 Jan 2016 14:38:51 +0100 "Daniele E. Domenichelli" 
 wrote:
> pending 793607
> thanks
> 
> Hello Gert,
> 
> Thanks for the patch. Actually, I fixed this some time ago and I have
> the package ready for the upload, but it fails to build on testing
> because libinsighttoolkit-dev disappeared from testing.
> If you want to try, the package from git should be building now (you
> will have to use libinsighttoolkit-dev from unstable).
> 
> 
> Cheers,
>  Daniele
> 
> 
> 

Sent from Yahoo Mail on Android

Bug#793607: FTBFS against QT5

[Daniele E. Domenichelli]

pending 793607
thanks

Hello Gert,

Thanks for the patch. Actually, I fixed this some time ago and I have
the package ready for the upload, but it fails to build on testing
because libinsighttoolkit-dev disappeared from testing.
If you want to try, the package from git should be building now (you
will have to use libinsighttoolkit-dev from unstable).


Cheers,
 Daniele

Bug#793607: FTBFS against QT5

[Gert Wollny]

Hello, 

the error actually stems from the handling of the QT5 includes an
libraries. The attached patch corrects this problem. 

Note that you will also have to build depend on libvtk6-qt-dev (instead
of only libvtk6-dev). 

(There is an open issue with libvtk6-qt-dev that I didn't report in the
BTS, but only confirmed with the VTK6 maintainers, the package pulls in
some qt4 packages. This is an annoyance, but nifti2dicom still builds
properly.)

Many thanks, 
Gert
Description: Correct the includes and libraries for QT5
Author: Gert Wollny 
Forwarded: no
Last-Update: 2016-01-10

--- nifti2dicom-0.4.9.orig/src/gui/CMakeLists.txt
+++ nifti2dicom-0.4.9/src/gui/CMakeLists.txt
@@ -50,6 +50,10 @@ endif()
 if(Nifti2Dicom_QT_VERSION EQUAL 5)
 qt5_wrap_cpp(qnifti2dicom_MOC_SRCS ${qnifti2dicom_MOC_HDR})
 qt5_add_resources(qnifti2dicom_QRC_SRCS ${qnifti2dicom_QRC_RCC})
+set(QT_QTCORE_INCLUDE_DIR ${Qt5Core_INCLUDE_DIR})
+set(QT_QTCOREGUI_INCLUDE_DIR ${Qt5Gui_INCLUDE_DIR})
+set(QT_QTCORE_LIBRARY ${Qt5Core_LIBRARIES})
+set(QT_QTGUI_LIBRARY ${Qt5Gui_LIBRARIES})
 else()
 qt4_wrap_cpp(qnifti2dicom_MOC_SRCS ${qnifti2dicom_MOC_HDR})
 qt4_add_resources(qnifti2dicom_QRC_SRCS ${qnifti2dicom_QRC_RCC})