Bug#805403: libpango-perl: FTBFS: undefined symbol: pango_cairo_update_layout (broken by pkg-config 0.29)

2015-11-21 Thread Niko Tyni 
Control: tag -1 patch

On Tue, Nov 17, 2015 at 10:07:51PM +0200, Niko Tyni wrote:
> Package: libpango-perl
> Version: 1.226-2
> Tags: sid
> Severity: serious
> X-Debbugs-Cc: pkg-con...@packages.debian.org
> 
> The libpango-perl package fails to build on current sid.
> 
>   [...]
>   Warning (mostly harmless): No library found for -lglib-2.0-lpangocairo-1.0
>   [...]
>   Can't load 'blib/arch/auto/Pango/Pango.so' for module Pango: 
> blib/arch/auto/Pango/Pango.so: undefined symbol: pango_cairo_update_layout at 
> /usr/lib/x86_64-linux-gnu/perl/5.20/DynaLoader.pm line 187.

> This broke with pkg-config 0.28-1 -> 0.29-2, because 'pkg-config --libs
> pango' output no longer has a space at the end.  The libpango-perl build
> system concatenates the output with the 'pkg-config --libs pangocairo'
> output, which now breaks.
> 
> Cc'ing the pkg-config maintainer. Tollef, is this an intentional change?

Looking at
 
http://cgit.freedesktop.org/pkg-config/commit/?id=f26a505826acec6b1e1af8d1efdf959913421c3a
it apparently was intentional.

Patch for libpango-perl attached.
-- 
Niko Tyni   nt...@debian.org
>From 6bdc1e830eb1bb48209a22510425f9b0d88592ae Mon Sep 17 00:00:00 2001
From: Niko Tyni 
Date: Sat, 21 Nov 2015 10:38:52 +0200
Subject: [PATCH] Ensure word separation in linker arguments with pkg-config >=
 0.29

Since pkg-config 0.29,
 http://cgit.freedesktop.org/pkg-config/commit/?id=f26a505826acec6b1e1af8d1efdf959913421c3a
the cflags and libs no longer have a trailing space, resulting
in bogus linker arguments like -lglib-2.0-lpangocairo-1.0.

The 'cflags' strings are already joined with whitespace earlier
so only the 'libs' need fixing.
---
 Makefile.PL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.PL b/Makefile.PL
index e644209..1d3349d 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -161,7 +161,7 @@ my $libs = $pango_pkgcfg{libs};
 if ($have_cairo) {
 	push @deps, qw/Cairo/;
 	$inc .= $pangocairo_pkgcfg{cflags};
-	$libs .= $pangocairo_pkgcfg{libs};
+	$libs .= ' ' . $pangocairo_pkgcfg{libs};
 }
 
 my @typemaps = map { File::Spec->catfile(cwd(), $_) }
-- 
2.6.2

Processed: Re: Bug#805403: libpango-perl: FTBFS: undefined symbol: pango_cairo_update_layout (broken by pkg-config 0.29)

2015-11-21 Thread Debian Bug Tracking System 
Processing control commands:

> tag -1 patch
Bug #805403 [libpango-perl] libpango-perl: FTBFS: undefined symbol: 
pango_cairo_update_layout (broken by pkg-config 0.29)
Bug #805671 [libpango-perl] libpango-perl: FTBFS: Pango.so: undefined symbol: 
pango_cairo_update_layout
Added tag(s) patch.
Added tag(s) patch.

-- 
805403: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805403
805671: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805671
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#805403: libpango-perl: FTBFS: undefined symbol: pango_cairo_update_layout (broken by pkg-config 0.29)

2015-11-17 Thread Niko Tyni 
Package: libpango-perl
Version: 1.226-2
Tags: sid
Severity: serious
X-Debbugs-Cc: pkg-con...@packages.debian.org

The libpango-perl package fails to build on current sid.

  [...]
  Warning (mostly harmless): No library found for -lglib-2.0-lpangocairo-1.0
  [...]
  Can't load 'blib/arch/auto/Pango/Pango.so' for module Pango: 
blib/arch/auto/Pango/Pango.so: undefined symbol: pango_cairo_update_layout at 
/usr/lib/x86_64-linux-gnu/perl/5.20/DynaLoader.pm line 187.
   at -e line 0.
  Compilation failed in require.
  BEGIN failed--compilation aborted.
  Makefile:1388: recipe for target 'build/podindex' failed
  make[1]: *** [build/podindex] Error 2

This broke with pkg-config 0.28-1 -> 0.29-2, because 'pkg-config --libs
pango' output no longer has a space at the end.  The libpango-perl build
system concatenates the output with the 'pkg-config --libs pangocairo'
output, which now breaks.

Cc'ing the pkg-config maintainer. Tollef, is this an intentional change?

With 0.28-1:

% pkg-config --libs pango|grep -q ' $' && echo ok
ok

With 0.29-2:

% pkg-config --libs pango|grep -q ' $' && echo ok
%

-- 
Niko Tyni   nt...@debian.org