Bug#808603: [debhelper-devel] Bug#808603: debhelper: dh_installmanpages is broken

2015-12-23 Thread Axel Beckert
Control: tag -1 + pending

Hi,

Niko Tyni wrote:
> It looks like 
>  
> https://anonscm.debian.org/cgit/debhelper/debhelper.git/commit/?id=1bd369cc52115fd179a46d6f8d9af6e9f126ffa8
> 
> broke dh_installmanpages, which has
> @allpackages=getpackages('');
> 
> The new code handles a missing argument but not an empty one.
> 
> +   my ($type) = @_;
> +   $type //= 'both';
> 
> This made at least four packages FTBFS, see
>  #808592 #808590 #808589 #808588

At least one more in the meanwhile: #808758

> Not sure which side to fix so I'm leaving it to you.  

Niels has pushed a fix to git two days ago:

https://anonscm.debian.org/cgit/debhelper/debhelper.git/commit/?id=61df6eb53302cadf11c1e0aa87b2ff0af207da2f

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Processed: Re: [debhelper-devel] Bug#808603: debhelper: dh_installmanpages is broken

2015-12-23 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 + pending
Bug #808603 [debhelper] debhelper: dh_installmanpages is broken
Bug #808588 [debhelper] code2html: FTBFS: dh_installmanpages: getpackages: 
First argument must be one of "arch", "indep" or "both"
Bug #808589 [debhelper] cplay: FTBFS: dh_installmanpages: getpackages: First 
argument must be one of "arch", "indep" or "both"
Bug #808590 [debhelper] funny-manpages: FTBFS: dh_installmanpages: getpackages: 
First argument must be one of "arch", "indep" or "both"
Bug #808592 [debhelper] rinetd: FTBFS: dh_installmanpages: getpackages: First 
argument must be one of "arch", "indep" or "both"
Bug #808758 [debhelper] jpeginfo: FTBFS: dh_installmanpages: getpackages: First 
argument must be one of "arch", "indep" or "both"
Added tag(s) pending.
Added tag(s) pending.
Added tag(s) pending.
Added tag(s) pending.
Added tag(s) pending.
Added tag(s) pending.

-- 
808588: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808588
808589: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808589
808590: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808590
808592: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808592
808603: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808603
808758: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808758
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#808603: debhelper: dh_installmanpages is broken

2015-12-21 Thread Niko Tyni
Package: debhelper
Version: 9.20151220
Severity: serious

It looks like 
 
https://anonscm.debian.org/cgit/debhelper/debhelper.git/commit/?id=1bd369cc52115fd179a46d6f8d9af6e9f126ffa8

broke dh_installmanpages, which has
@allpackages=getpackages('');

The new code handles a missing argument but not an empty one.

+   my ($type) = @_;
+   $type //= 'both';

This made at least four packages FTBFS, see
 #808592 #808590 #808589 #808588

  dh_installmanpages
  dh_installmanpages: This program is deprecated, switch to dh_installman.
  dh_installmanpages: getpackages: First argument must be one of "arch", 
"indep" or "both"
  debian/rules:35: recipe for target 'binary-arch' failed

Not sure which side to fix so I'm leaving it to you.  

codesearch.debian.net reports no other hits for getpackages("") or
getpackages('') FWIW.
-- 
Niko Tyni   nt...@debian.org