Bug#811708: init-system-helpers openrc branch pull request

[Andreas Henriksson]

Hello again Benda Xu.

I've noticed that you in 
http://anonscm.debian.org/cgit/openrc/openrc.git/commit/?id=e29522cd4ee0cb20de161eb7ef33312cf3ac2ae8
have dropped the diverts you shipped in previous openrc package revision
(in  favour of now using invoke-rc.d/update-rc.d from init-system-helpers).

Is this really enough though? Don't you need to actively undivert
on package upgrades to undo the diverts (for those that had the
0.20.4-1 revision installed. Please note that you'll need to handle
the case where the files are not diverted as well (eg. when upgrading
from Debian stable version to current unstable version).

You should be able to check $1 for upgrade and $2 for which version
you're upgrading from. See for example:
https://wiki.debian.org/DpkgConffileHandling

Regards,
Andreas Henriksson

Bug#811708: init-system-helpers openrc branch pull request

[Benda Xu]

Dear Martin and Michael,
Cc Andreas,

I have added openrc support to invoke-rc.d and update-rc.d in
collab-maint/init-system-helpers.git[1].  Does it look good to be
uploaded?

replying to Andreas below:

Andreas Henriksson  writes:

> On Fri, Feb 19, 2016 at 03:36:38PM +0900, Benda Xu wrote:
>> I have pushed an openrc branch into
>> collab-maint/init-system-helpers.git[1], to have openrc supports in
>> invoke-rc.d and update-rc.d.  I didn't add a changelog item though.
>
> Great that you implemented what I consider the preferred solution
> by implementing it in the same version as supports other init systems.

Yeah, as I said in the last email I agree it is the right way to move
forward to benefit everyone.

>> 
>> Could you please help review it?
>
> I've quickly looked at it and while not knowing anything in particular
> about openrc from the viewpoint of other init systems I don't see
> how your changes could possibly cause any problems for those.

Thanks for your positive comments.

>> 
>> After init-system-helpers make a version bump supporting openrc, I will
>> bump openrc to finish the transition.
>
> Please beware that I'm *not* the maintainer of init-system-helpers
> so please contact them for final review, merge and upload.

Probably it's a good chance to join to maintain invoke-rc.d and
update-rc.d for the long term.

Yours,
Benda

1. 
http://anonscm.debian.org/cgit/collab-maint/init-system-helpers.git/log/?h=openrc

Bug#811708: init-system-helpers openrc branch pull request

[Benda Xu]

Hi Andreas,

I have pushed an openrc branch into
collab-maint/init-system-helpers.git[1], to have openrc supports in
invoke-rc.d and update-rc.d.  I didn't add a changelog item though.

Could you please help review it? 

After init-system-helpers make a version bump supporting openrc, I will
bump openrc to finish the transition.

Thanks Svante, and thanks Adam for the report.

Cheers,
Benda

1. 
http://anonscm.debian.org/cgit/collab-maint/init-system-helpers.git/log/?h=openrc