Bug#813125: [pkg-php-pear] Bug#813125: Bug#813125: php-proxy-manager 2.0.0* has a dependency on a new PHP API PackageVersions

2016-02-09 Thread Nish Aravamudan
On 30.01.2016 [09:10:58 -0400], David Prévot wrote:
> Le 29/01/2016 18:45, Nish Aravamudan a écrit :
> > On 29.01.2016 [18:31:11 -0400], David Prévot wrote:
> >> Le 29/01/2016 12:39, Nishanth Aravamudan a écrit :

> >>> […] it has a dependency that prevents it
> >>> from successfully packaging currently. The upstream code has introduced
> >>> a new dependency on https://github.com/Ocramius/PackageVersions, which I
> >>> am guessing would need to be packaged as a new package, i.e.,
> >>> php-package-versions.
> >>
> >> I instead patched the package to not use this new dependency.
> > 
> > Ok, I'll look at your version when it's in the VCS tomorrow.
> 
> 
> http://anonscm.debian.org/cgit/pkg-php/php-proxy-manager.git/commit/?id=599baa2548cfc9be768f7436c9457796acad2094
> 

I was finally able to get to this, and I see build failures using that
base (due to phpcs issues):

phpcs --standard=PSR2 ./src/

FILE:
0.0/src/ProxyManager/Exception/InvalidProxiedClassException.php
--
FOUND 2 ERRORS AFFECTING 2 LINES
--
 54 | ERROR | [x] Multi-line function call not indented correctly;
|   | expected 20 spaces but found 24
 59 | ERROR | [x] Multi-line function call not indented correctly;
|   | expected 24 spaces but found 28
--
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--


FILE:
0/src/ProxyManager/ProxyGenerator/LazyLoadingGhostGenerator.php
--
FOUND 1 ERROR AFFECTING 1 LINE
--
 150 | ERROR | [x] Multi-line function call not indented correctly;
 |   | expected 12 spaces but found 16
--
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--


FILE:
...-2.0.0/src/ProxyManager/ProxyGenerator/RemoteObjectGenerator.php
--
FOUND 1 ERROR AFFECTING 1 LINE
--
 75 | ERROR | [x] Multi-line function call not indented correctly;
|   | expected 20 spaces but found 24
--
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--


FILE:
.../src/ProxyManager/ProxyGenerator/Assertion/CanProxyAssertion.php
--
FOUND 1 ERROR AFFECTING 1 LINE
--
 90 | ERROR | [x] Multi-line function call not indented correctly;
|   | expected 12 spaces but found 16
--
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--


FILE:
0/src/ProxyManager/ProxyGenerator/Util/ProxiedMethodsFilter.php
--
FOUND 1 ERROR AFFECTING 1 LINE
--
 83 | ERROR | [x] Multi-line function call not indented correctly;
|   | expected 12 spaces but found 16
--
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--


FILE:
...anager-2.0.0/src/ProxyManager/ProxyGenerator/Util/Properties.php
--
FOUND 1 ERROR AFFECTING 1 LINE
--
 59 | ERROR | [x] Multi-line function call not indented correctly;
|   | expected 20 spaces but found 24
--
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--


FILE:
...rc/ProxyManager/ProxyGenerator/Util/UnsetPropertiesGenerator.php
--
FOUND 1 ERROR AFFECTING 1 LINE
--
 104 | ERROR | [x] Multi-line function call not indented correctly;
 |   | expected 20 spaces but found 24
--
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Bug#813125: [pkg-php-pear] Bug#813125: Bug#813125: php-proxy-manager 2.0.0* has a dependency on a new PHP API PackageVersions

2016-01-30 Thread David Prévot
Le 29/01/2016 18:45, Nish Aravamudan a écrit :
> On 29.01.2016 [18:31:11 -0400], David Prévot wrote:
>> Le 29/01/2016 12:39, Nishanth Aravamudan a écrit :

>>> The same issues should be seen with Debian unstable.
>>
>> FWIW, with what is currently in Debian, I don’t get such issue.
> 
> Right, because, I'm expecting that the php-proxy-manager package is
> still depending on PHP5, rather than PHP7.

Worst, (I didn’t remember yesterday, but) the tests have been stripped
away from the proper tarball :/

>>> I see that per https://packages.qa.debian.org/p/php-proxy-manager.html,
>>> there is a 2.0.0~beta1 available to package.
>>
>> Even 2.0.0~beta2, I already prepared the package for experimental, will
>> push my changes to the VCS tomorrow.
> 
> Ok, thanks, I'll take a look!

Now pushed.

>>> […] it has a dependency that prevents it
>>> from successfully packaging currently. The upstream code has introduced
>>> a new dependency on https://github.com/Ocramius/PackageVersions, which I
>>> am guessing would need to be packaged as a new package, i.e.,
>>> php-package-versions.
>>
>> I instead patched the package to not use this new dependency.
> 
> Ok, I'll look at your version when it's in the VCS tomorrow.


http://anonscm.debian.org/cgit/pkg-php/php-proxy-manager.git/commit/?id=599baa2548cfc9be768f7436c9457796acad2094

Regards

David



signature.asc
Description: OpenPGP digital signature