Bug#813125: phpcs upstream issue [was: php-proxy-manager 2.0.0* has a dependency on a new PHP API PackageVersions]
Hi Nish, Le 09/02/2016 15:05, Nish Aravamudan a écrit : > I was finally able to get to this, and I see build failures using that > base (due to phpcs issues): > > phpcs --standard=PSR2 ./src/ […] > I can fix this up on my end by putting in a staged build, but it seems > like something needs to be fixed still? That’s probably caused by a new issue in php-codesniffer 2.5.1, e.g., https://github.com/squizlabs/PHP_CodeSniffer/issues/876 FWIW, the build runs fine with php-codesniffer 2.5.1 (not in the archive, but I can push my update to the VCS if you wish), but php-codesniffer 2.5.1 does break other packages build, so I’d prefer to see an upstream php-codesniffer (and php-proxy-manager) fix before uploading it (unless I push both to experimental for the time being, would that be useful?). Regards David signature.asc Description: OpenPGP digital signature
Bug#813125: [pkg-php-pear] Bug#813125: phpcs upstream issue [was: php-proxy-manager 2.0.0* has a dependency on a new PHP API PackageVersions]
Hi Nish, >> On 09.02.2016 [15:17:17 -0400], David Prévot wrote: >>> Le 09/02/2016 15:05, Nish Aravamudan a écrit : >>> I was finally able to get to this, and I see build failures using that base (due to phpcs issues): > [ ] I can fix this up on my end by putting in a staged build, but it seems like something needs to be fixed still? >>> >>> Thats probably caused by a new issue in php-codesniffer 2.5.1, e.g., >>> >>> https://github.com/squizlabs/PHP_CodeSniffer/issues/876 >> >> Did you mean an issue with 2.5.0? > > No. I believed 2.5.1 introduced an indent issue, and that > php-proxy-manager was (probably automatically, with phpcbf) fixed to use > the new (broken) phpcs behavior. I just run phpcbf/2.5.0 and now believe > that I was wrong, so Ill have a closer look at what broke with > phpcs/2.5.1, and may upload the updated packages, or file/document a > proper upstream issue. Filed as https://github.com/squizlabs/PHP_CodeSniffer/issues/889 I guess nothing is stopping us to upload both php-codesniffer 2.5.1 and php-proxy-manager 2.0.0 to experimental. Ill upload a recent php-codesniffer to unstable once the aforementioned upstream issue will be fixed (one way or the other ;). Regards David
Bug#813125: phpcs upstream issue [was: php-proxy-manager 2.0.0* has a dependency on a new PHP API PackageVersions]
On 09.02.2016 [15:17:17 -0400], David Prévot wrote: > Hi Nish, > > Le 09/02/2016 15:05, Nish Aravamudan a écrit : > > > I was finally able to get to this, and I see build failures using that > > base (due to phpcs issues): > > > > phpcs --standard=PSR2 ./src/ > […] > > I can fix this up on my end by putting in a staged build, but it seems > > like something needs to be fixed still? > > That’s probably caused by a new issue in php-codesniffer 2.5.1, e.g., > > https://github.com/squizlabs/PHP_CodeSniffer/issues/876 Did you mean an issue with 2.5.0? > FWIW, the build runs fine with php-codesniffer 2.5.1 (not in the > archive, but I can push my update to the VCS if you wish), but > php-codesniffer 2.5.1 does break other packages build, so I’d prefer to > see an upstream php-codesniffer (and php-proxy-manager) fix before > uploading it (unless I push both to experimental for the time being, > would that be useful?). Well, for the purposes of syncing with Debian, it's probably only worth pushing something to experimental once upstream has the fixes in, I agree. I'll just wait on those and I'll request a sync once Debian updates. -Nish -- Nishanth Aravamudan Ubuntu Server Canonical Ltd
Bug#813125: phpcs upstream issue [was: php-proxy-manager 2.0.0* has a dependency on a new PHP API PackageVersions]
Hi Nish, > On 09.02.2016 [15:17:17 -0400], David Prévot wrote: >> Le 09/02/2016 15:05, Nish Aravamudan a écrit : >> >>> I was finally able to get to this, and I see build failures using that >>> base (due to phpcs issues): [ ] >>> I can fix this up on my end by putting in a staged build, but it seems >>> like something needs to be fixed still? >> >> Thats probably caused by a new issue in php-codesniffer 2.5.1, e.g., >> >> https://github.com/squizlabs/PHP_CodeSniffer/issues/876 > > Did you mean an issue with 2.5.0? No. I believed 2.5.1 introduced an indent issue, and that php-proxy-manager was (probably automatically, with phpcbf) fixed to use the new (broken) phpcs behavior. I just run phpcbf/2.5.0 and now believe that I was wrong, so Ill have a closer look at what broke with phpcs/2.5.1, and may upload the updated packages, or file/document a proper upstream issue. Regards David
