Bug#813339: isc-dhcp-server: Update to 4.3.3-7 today makes isc-dhcp-server unable to work

[Sven Hartge]

On Tue, 16 Feb 2016 23:10:33 +0100 Pierre Ynard  wrote:

> Thank you for your efforts to fix most of the issues with the
> initscript.

There is one other issue with the init-script:

The config option points to the same config file:

DHCPDv4_CONF=${DHCPDv4_CONF:-/etc/dhcp/dhcpd.conf}
DHCPDv6_CONF=${DHCPDv6_CONF:-/etc/dhcp/dhcpd.conf}

This will not work, both config files have a different syntax and have
to be different.

I propose /etc/dhcp/dhcp6.conf as name for the IPv6 config file.

(The same error is made in /etc/default/isc-dhcp-server.)

Grüße,
Sven.



signature.asc
Description: OpenPGP digital signature

Bug#813339: isc-dhcp-server: Update to 4.3.3-7 today makes isc-dhcp-server unable to work

[Pierre Ynard]

reopen 813339
thanks

Thank you for your efforts to fix most of the issues with the
initscript. However, after migrating from 4.3.3-5 and the DHCPv4 server
successfully starting, I still see two obvious issues, both with the
status command:

 - It fails to see that servers are running:

# service isc-dhcp-server status
Status of ISC DHCPv4 server:  is not running.
Status of ISC DHCPv6 server:  is not running.

   This is because it checks the wrong variables DHCPv4/6_PID, which are
   never set, instead of DHCPDv4/6_PID

 - As mentioned before, the status will return an error code if the
   DHCPv4 server is running but the DHCPv6 server is not running, even
   if the latter is disabled in the configuration, as when simply
   upgrading the package. This seems wrong and breaks stuff. I suggest
   that the status command uses `test -n "$INTERFACESv4/6"` conditional
   guards similar to the start command too, with the $INTERFACES magic
   factored out.

Please fix the status command in all cases.

Thanks,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

Bug#813339: isc-dhcp-server: Update to 4.3.3-7 today makes isc-dhcp-server unable to work

[Pierre Ynard]

The init script should probably check and copy the contents of
INTERFACES into INTERFACESv4 if the latter is missing, for best
portability reasons.

On top of the migration being broken for startup, silently leaving dhcpd
down after upgrade, the status command of the init script is broken too:
a classic setup with only v4 enabled will have the status command return
a failed status, contrary to before. This seems wrong and breaks stuff.
I suggest that the status command uses `test -n "$INTERFACESv4/6"`
conditional guards similar to the start command too.

Furthermore, the start_daemon() function checks the stray DHCPD_PID
variable, which is probably a mistake and should be updated to PIDFILE.

Please fix and improve migration.

Best regards,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

Bug#813339: isc-dhcp-server: Update to 4.3.3-7 today makes isc-dhcp-server unable to work

[Russel Winder]

On Sun, 31 Jan 2016 21:33:35 +0100 Sven Hartge 
wrote:
[…]
> 
> The variable to define which interface the dhcpd runs on has changed,
> but unfortunately the contents of /etc/default/isc-dhcp-server were
not
> adapted at the same time.
> 
> You need to change
> 
> INTERFACES="..."
> 
> to
> 
> INTERFACESv4="..."
> 
> to be able to start the DHCP server again.
> 
> And I guess this bug is not just important but of severity "grave".

I tried:

INTERFACESv4=""

on the assumption of interface discovery as used to happen, but this
didn't work.

INTERFACESv4="eth0"

does however work fine. I have a DHCP server again. :-) Thanks for
pointing me to the solution, and quickly, it is very much appreciated. 

-- 
Russel.
=
Dr Russel Winder  t: +44 20 7585 2200   voip: sip:russel.win...@ekiga.net
41 Buckmaster Roadm: +44 7770 465 077   xmpp: rus...@winder.org.uk
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder



signature.asc
Description: This is a digitally signed message part