Bug#817006: [PKG-OpenRC-Debian] Bug#817006: ack to NMU

2016-03-08 Thread Benda Xu
Hi Adam,

Adam Borowski  writes:

> The popcon for openrc is 83, which, assuming that 10% of users run popcon
> (a wild-ass guess) means 830 users.  I have no idea what part of this is
> unstable, but as openrc in Debian is quite experimental, I guess quite a
> bunch of such users are affected.
>
> The breakage is pretty severe -- it does match the description of "critical"
> after all.  Every affected user would have to research the fix and apply
> it manually.  Thus, I don't think it's a good idea to ignore this bug,
> especially that the fix is easy.

Okay, I will take this lesson. Thank you for your help!

>> That said, I understand theoretically your NMU is the correctly way to
>> go.  So if you intend to do so, consider this email as an ack to NMU
>> from the maintainer team.
>
> I'll upload it then.

Great!  It is in Sid now.

>> One thing to notice is that we are tracking the package at
>> 
>>   http://anonscm.debian.org/cgit/openrc/openrc.git
>> 
>> Would you mind if I ask you to prepare a commit to the master
>> corresponding to the NMU?
>
> Of course.  I don't have push rights to that repository, so two commits are
> attached to this mail (one for the fix, one for changelog).

Applied and pushed.

You could apply at

https://alioth.debian.org/projects/openrc

to get push rights.

>> BTW, if you are interested in OpenRC, you are welcomed to join the
>> maintenance team.
>
> I'm afraid I don't really know inner workings of openrc, I use it on only
> one machine (which happens to be my main desktop, but still...).  Everywhere
> else I'm on sysv-rc.

Ah-ha. Me too, desktops, laptops or newly installed servers (those I
could access the consoles).

> This said, keeping openrc viable seems important for resisting
> systemd-ization of Debian so I probably should help in _some_ way.

Agreed.

>> 1. 0.20.4-1 was uploaded in a hurry to keep itself in testing.  The pts
>> system lied and we did not make it.  divert should not have existed in
>> OpenRC.
>
> It can be removed in some time, after the affected systems are fixed.

Okay.


Also I would like to thank Andreas for pointing this out.

Yours,
Benda



Bug#817006: ack to NMU

2016-03-08 Thread Adam Borowski
On Tue, Mar 08, 2016 at 04:31:24PM +0900, Benda Xu wrote:
> Basically, my taking to this bug is to ignore it, leaving the users to
> fix the breakage by
> 
>   dpkg-divert --remove /usr/sbin/invoke-rc.d
>   dpkg-divert --remove /usr/sbin/update-rc.d
> 
> manually.  
> 
> 0.20.4-1 lasted only 10days.  Only few users would be affected.

The popcon for openrc is 83, which, assuming that 10% of users run popcon
(a wild-ass guess) means 830 users.  I have no idea what part of this is
unstable, but as openrc in Debian is quite experimental, I guess quite a
bunch of such users are affected.

The breakage is pretty severe -- it does match the description of "critical"
after all.  Every affected user would have to research the fix and apply
it manually.  Thus, I don't think it's a good idea to ignore this bug,
especially that the fix is easy.

> That said, I understand theoretically your NMU is the correctly way to
> go.  So if you intend to do so, consider this email as an ack to NMU
> from the maintainer team.

I'll upload it then.

> One thing to notice is that we are tracking the package at
> 
>   http://anonscm.debian.org/cgit/openrc/openrc.git
> 
> Would you mind if I ask you to prepare a commit to the master
> corresponding to the NMU?

Of course.  I don't have push rights to that repository, so two commits are
attached to this mail (one for the fix, one for changelog).

> BTW, if you are interested in OpenRC, you are welcomed to join the
> maintenance team.

I'm afraid I don't really know inner workings of openrc, I use it on only
one machine (which happens to be my main desktop, but still...).  Everywhere
else I'm on sysv-rc.  This said, keeping openrc viable seems important for
resisting systemd-ization of Debian so I probably should help in _some_ way.

> 1. 0.20.4-1 was uploaded in a hurry to keep itself in testing.  The pts
> system lied and we did not make it.  divert should not have existed in
> OpenRC.

It can be removed in some time, after the affected systems are fixed.


Meow!
-- 
A tit a day keeps the vet away.
>From b4653519c5109967be09976e1fbf431316d07dcf Mon Sep 17 00:00:00 2001
From: Adam Borowski 
Date: Tue, 8 Mar 2016 05:19:25 +0100
Subject: [PATCH 1/2] Remove dangling diverts introduced by 0.20.4-1.

---
 debian/openrc.postinst | 13 +
 1 file changed, 13 insertions(+)

diff --git a/debian/openrc.postinst b/debian/openrc.postinst
index 4d09a68..cd0284e 100644
--- a/debian/openrc.postinst
+++ b/debian/openrc.postinst
@@ -2,6 +2,19 @@
 
 set -e
 
+# Remove diverts made by 0.20.4-1
+if [ "$(dpkg-divert --list /usr/sbin/invoke-rc.d)" = \
+ "diversion of /usr/sbin/invoke-rc.d to /usr/sbin/invoke-rc.d.init-system-helpers by openrc" ]
+	then dpkg-divert --package openrc --remove --rename \
+		--divert /usr/sbin/invoke-rc.d.init-system-helpers /usr/sbin/invoke-rc.d
+fi
+if [ "$(dpkg-divert --list /usr/sbin/update-rc.d)" = \
+ "diversion of /usr/sbin/update-rc.d to /usr/sbin/update-rc.d.init-system-helpers by openrc" ]
+	then dpkg-divert --package openrc --remove --rename \
+		--divert /usr/sbin/update-rc.d.init-system-helpers /usr/sbin/update-rc.d
+fi
+
+
 if [ "${1}" = "configure" ] ; then
 	echo "Add existing services ..."
 
-- 
2.7.0

>From 26d115187fdb7d64cd0569ade30421216d210714 Mon Sep 17 00:00:00 2001
From: Adam Borowski 
Date: Tue, 8 Mar 2016 05:20:10 +0100
Subject: [PATCH 2/2] release 0.20.4-2.1 into sid.

---
 debian/changelog | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 15aaae8..8e5269d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+openrc (0.20.4-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove diversions to update-rc.d + invoke-rc.d (Closes: #817006).
+
+ -- Adam Borowski   Tue, 08 Mar 2016 05:17:44 +0100
+
 openrc (0.20.4-2) unstable; urgency=high
 
   * Bump standard to 3.9.7.
-- 
2.7.0



Bug#817006: ack to NMU

2016-03-07 Thread Benda Xu
Hi Adam,

Thank you for your report.  I appreciate your enthusiasm.

Sorry, I forgot to append my reply to Andreas to #811708:

  
http://lists.alioth.debian.org/pipermail/openrc-devel/Week-of-Mon-20160307/000436.html

Basically, my taking to this bug is to ignore it, leaving the users to
fix the breakage by

  dpkg-divert --remove /usr/sbin/invoke-rc.d
  dpkg-divert --remove /usr/sbin/update-rc.d

manually.  

0.20.4-1 lasted only 10days.  Only few users would be affected.
Provided OpenRC have already been removed from testing thanks to i-s-h
[1], such a breakage is tolerable for unstable.


That said, I understand theoretically your NMU is the correctly way to
go.  So if you intend to do so, consider this email as an ack to NMU
from the maintainer team.


One thing to notice is that we are tracking the package at

  http://anonscm.debian.org/cgit/openrc/openrc.git

Would you mind if I ask you to prepare a commit to the master
corresponding to the NMU?

BTW, if you are interested in OpenRC, you are welcomed to join the
maintenance team.

Yours,
Benda


1. 0.20.4-1 was uploaded in a hurry to keep itself in testing.  The pts
system lied and we did not make it.  divert should not have existed in
OpenRC.