Bug#842675: [Pkg-xfce-devel] Bug#842675: Fix, NMU to DELAYED/5

[Yves-Alexis Perez]

On Sun, 2016-12-18 at 15:51 +0100, Hilko Bengen wrote:
> Yes, I have done successful builds on amd64, mipsel, mips64el, armhf,
> arm64.

> Please do the upload yourself.
> 
> Since the Qt symbols that somehow got into the library are not really
> part of the ABI, you may want to change them like this:
> 
>  (c++|optional)"QByteArray::~QByteArray()@Base" 0
>  (c++|optional)"QDBusError::~QDBusError()@Base" 0
>  (c++|optional)"QHash::~QHash()@Base" 0
>  (c++|optional)"QString::~QString()@Base" 0

Thanks, I didn't know about the |optional syntax. I'll include your patch and
upload.

Regards,
-- 
Yves-Alexis

signature.asc
Description: This is a digitally signed message part

Bug#842675: [Pkg-xfce-devel] Bug#842675: Bug#842675: Fix, NMU to DELAYED/5

[Hilko Bengen]

* Yves-Alexis Perez:

> On Sun, 2016-12-18 at 13:28 +0100, Yves-Alexis Perez wrote:
>> On Fri, 2016-12-16 at 08:05 +0100, Hilko Bengen wrote:
>> > here is a set of patches that I intend to NMU to DELAYED/5 later. I have
>> > changed the .symbols file to use C++ name demangling and added some
>> > optional symbols that seem to come directly from the Qt library.
>> > 
>> > I have also taken the liberty to add a missing dependency on lsb-base
>> > which was flagged as an error by Lintian.
>> 
>> Hi,
>> 
>> can you confirm it works on both Intel and non Intel arches?
>
> I'd prefer to do the upload myself, but in any case please don't upload with
> the package revisions in the symbols file.

You're right, I'll cancel my NMU. Oops.

Please do the upload yourself.

Since the Qt symbols that somehow got into the library are not really
part of the ABI, you may want to change them like this:

 (c++|optional)"QByteArray::~QByteArray()@Base" 0
 (c++|optional)"QDBusError::~QDBusError()@Base" 0
 (c++|optional)"QHash::~QHash()@Base" 0
 (c++|optional)"QString::~QString()@Base" 0

Cheers,
-Hilko

Bug#842675: [Pkg-xfce-devel] Bug#842675: Fix, NMU to DELAYED/5

[Hilko Bengen]

* Yves-Alexis Perez:

> On Fri, 2016-12-16 at 08:05 +0100, Hilko Bengen wrote:
>> here is a set of patches that I intend to NMU to DELAYED/5 later. I have
>> changed the .symbols file to use C++ name demangling and added some
>> optional symbols that seem to come directly from the Qt library.
>> 
>> I have also taken the liberty to add a missing dependency on lsb-base
>> which was flagged as an error by Lintian.
>
> can you confirm it works on both Intel and non Intel arches?

Yes, I have done successful builds on amd64, mipsel, mips64el, armhf,
arm64.

Cheers,
-Hilko

Bug#842675: [Pkg-xfce-devel] Bug#842675: Bug#842675: Fix, NMU to DELAYED/5

[Yves-Alexis Perez]

On Sun, 2016-12-18 at 13:28 +0100, Yves-Alexis Perez wrote:
> On Fri, 2016-12-16 at 08:05 +0100, Hilko Bengen wrote:
> > here is a set of patches that I intend to NMU to DELAYED/5 later. I have
> > changed the .symbols file to use C++ name demangling and added some
> > optional symbols that seem to come directly from the Qt library.
> > 
> > I have also taken the liberty to add a missing dependency on lsb-base
> > which was flagged as an error by Lintian.
> 
> Hi,
> 
> can you confirm it works on both Intel and non Intel arches?

I'd prefer to do the upload myself, but in any case please don't upload with
the package revisions in the symbols file.

Regards,
-- 
Yves-Alexis

signature.asc
Description: This is a digitally signed message part

Bug#842675: [Pkg-xfce-devel] Bug#842675: Fix, NMU to DELAYED/5

[Yves-Alexis Perez]

On Fri, 2016-12-16 at 08:05 +0100, Hilko Bengen wrote:
> here is a set of patches that I intend to NMU to DELAYED/5 later. I have
> changed the .symbols file to use C++ name demangling and added some
> optional symbols that seem to come directly from the Qt library.
> 
> I have also taken the liberty to add a missing dependency on lsb-base
> which was flagged as an error by Lintian.

Hi,

can you confirm it works on both Intel and non Intel arches?

Regards,
-- 
Yves-Alexis

signature.asc
Description: This is a digitally signed message part

Bug#842675: Fix, NMU to DELAYED/5

[Hilko Bengen]

Hi,

here is a set of patches that I intend to NMU to DELAYED/5 later. I have
changed the .symbols file to use C++ name demangling and added some
optional symbols that seem to come directly from the Qt library.

I have also taken the liberty to add a missing dependency on lsb-base
which was flagged as an error by Lintian.

Cheers,
-Hilko
>From 94e74966b47a28e0753c75311d7073d9763ffc25 Mon Sep 17 00:00:00 2001
From: Hilko Bengen 
Date: Wed, 14 Dec 2016 17:46:21 +0100
Subject: [PATCH 1/4] Use demangled symbols

---
 debian/liblightdm-qt-3-0.symbols | 260 ++-
 1 file changed, 118 insertions(+), 142 deletions(-)

diff --git a/debian/liblightdm-qt-3-0.symbols b/debian/liblightdm-qt-3-0.symbols
index a1cd79c..3ceea6a 100644
--- a/debian/liblightdm-qt-3-0.symbols
+++ b/debian/liblightdm-qt-3-0.symbols
@@ -1,143 +1,119 @@
 liblightdm-qt-3.so.0 liblightdm-qt-3-0 #MINVER#
- _ZN10QDBusErrorD1Ev@Base 1.8.7
- _ZN10QDBusErrorD2Ev@Base 1.8.7
- _ZN10QDBusReplyI7QStringED1Ev@Base 1.8.7
- _ZN10QDBusReplyI7QStringED2Ev@Base 1.8.7
- _ZN11SessionItemD1Ev@Base 1.8.7
- _ZN11SessionItemD2Ev@Base 1.8.7
- _ZN20SessionsModelPrivate12loadSessionsEN8QLightDM13SessionsModel11SessionTypeE@Base 1.8.7
- _ZN20SessionsModelPrivateC1EPN8QLightDM13SessionsModelE@Base 1.8.7
- _ZN20SessionsModelPrivateC2EPN8QLightDM13SessionsModelE@Base 1.8.7
- _ZN5QHashIi10QByteArrayE11deleteNode2EPN9QHashData4NodeE@Base 1.8.7
- _ZN5QHashIi10QByteArrayE13detach_helperEv@Base 1.8.7
- _ZN5QHashIi10QByteArrayE13duplicateNodeEPN9QHashData4NodeEPv@Base 1.8.7
- _ZN5QListI11SessionItemE18detach_helper_growEii@Base 1.8.7
- _ZN5QListI11SessionItemE6appendERKS0_@Base 1.8.7
- _ZN5QListI8UserItemE13detach_helperEi@Base 1.8.7
- _ZN5QListI8UserItemE18detach_helper_growEii@Base 1.8.7
- _ZN5QListI8UserItemE6appendERKS0_@Base 1.8.7
- _ZN6QDebugD1Ev@Base 1.8.7
- _ZN6QDebugD2Ev@Base 1.8.7
- _ZN8QLightDM10UsersModel11qt_metacallEN11QMetaObject4CallEiPPv@Base 1.8.7
- _ZN8QLightDM10UsersModel11qt_metacastEPKc@Base 1.8.7
- _ZN8QLightDM10UsersModel16staticMetaObjectE@Base 1.8.7
- _ZN8QLightDM10UsersModelC1EP7QObject@Base 1.8.7
- _ZN8QLightDM10UsersModelC2EP7QObject@Base 1.8.7
- _ZN8QLightDM10UsersModelD0Ev@Base 1.8.7
- _ZN8QLightDM10UsersModelD1Ev@Base 1.8.7
- _ZN8QLightDM10UsersModelD2Ev@Base 1.8.7
- _ZN8QLightDM13SessionsModel11qt_metacallEN11QMetaObject4CallEiPPv@Base 1.8.7
- _ZN8QLightDM13SessionsModel11qt_metacastEPKc@Base 1.8.7
- _ZN8QLightDM13SessionsModel16staticMetaObjectE@Base 1.8.7
- _ZN8QLightDM13SessionsModelC1ENS0_11SessionTypeEP7QObject@Base 1.8.7
- _ZN8QLightDM13SessionsModelC1EP7QObject@Base 1.8.7
- _ZN8QLightDM13SessionsModelC2ENS0_11SessionTypeEP7QObject@Base 1.8.7
- _ZN8QLightDM13SessionsModelC2EP7QObject@Base 1.8.7
- _ZN8QLightDM13SessionsModelD0Ev@Base 1.8.7
- _ZN8QLightDM13SessionsModelD1Ev@Base 1.8.7
- _ZN8QLightDM13SessionsModelD2Ev@Base 1.8.7
- _ZN8QLightDM14GreeterPrivate13cb_showPromptEP14LightDMGreeterPKc17LightDMPromptTypePv@Base 1.8.7
- _ZN8QLightDM14GreeterPrivate14cb_showMessageEP14LightDMGreeterPKc18LightDMMessageTypePv@Base 1.8.7
- _ZN8QLightDM14GreeterPrivate19cb_autoLoginExpiredEP14LightDMGreeterPv@Base 1.8.7
- _ZN8QLightDM14GreeterPrivate25cb_authenticationCompleteEP14LightDMGreeterPv@Base 1.8.7
- _ZN8QLightDM14GreeterPrivate7cb_idleEP14LightDMGreeterPv@Base 1.12.2
- _ZN8QLightDM14GreeterPrivate8cb_resetEP14LightDMGreeterPv@Base 1.12.2
- _ZN8QLightDM14GreeterPrivateC1EPNS_7GreeterE@Base 1.8.7
- _ZN8QLightDM14GreeterPrivateC2EPNS_7GreeterE@Base 1.8.7
- _ZN8QLightDM14PowerInterface10canRestartEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface10canSuspendEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface11canShutdownEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface11qt_metacallEN11QMetaObject4CallEiPPv@Base 1.8.7
- _ZN8QLightDM14PowerInterface11qt_metacastEPKc@Base 1.8.7
- _ZN8QLightDM14PowerInterface12canHibernateEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface16staticMetaObjectE@Base 1.8.7
- _ZN8QLightDM14PowerInterface21PowerInterfacePrivateC1Ev@Base 1.8.7
- _ZN8QLightDM14PowerInterface21PowerInterfacePrivateC2Ev@Base 1.8.7
- _ZN8QLightDM14PowerInterface7restartEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface7suspendEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface8shutdownEv@Base 1.8.7
- _ZN8QLightDM14PowerInterface9hibernateEv@Base 1.8.7
- _ZN8QLightDM14PowerInterfaceC1EP7QObject@Base 1.8.7
- _ZN8QLightDM14PowerInterfaceC2EP7QObject@Base 1.8.7
- _ZN8QLightDM14PowerInterfaceD0Ev@Base 1.8.7
- _ZN8QLightDM14PowerInterfaceD1Ev@Base 1.8.7
- _ZN8QLightDM14PowerInterfaceD2Ev@Base 1.8.7
- _ZN8QLightDM17UsersModelPrivate12cb_userAddedEP15LightDMUserListP11LightDMUserPv@Base 1.8.7
- _ZN8QLightDM17UsersModelPrivate14cb_userChangedEP15LightDMUserListP11LightDMUserPv@Base 1.8.7
- _ZN8QLightDM17UsersModelPrivate14cb_userRemovedEP15LightDMUserListP11LightDMUserPv@Base 1.8.7
- _ZN8QLightDM17UsersModelPrivate9loadUsersEv@Base 1.8.7
- _ZN8QLightDM17UsersModelPrivateC1EPNS_10UsersModelE@Base 1.8.7
-