Bug#875885: netkit-tftp: does not trap ./configure errors
On Tue, Jul 03, 2018 at 12:29:00PM +0200, Alberto Gonzalez Iniesta wrote: > Have you tested your assertion? Because if ./configure fails, MCONFIG is > not created and the build (make) fails: That was a general statement. I think it doesn't really matter whether it practically does cause misbuilds: The cost/benefit ratio is fairly obvious. Fixing such issues is generally trivial. Checking whether they really can result in misbuilds is generally expensive. Thus the policy prohibits this bad pattern. The other issue is that delayed failure costs time when diagnosing build failures. You look at the failing step and then notice that some prerequisite was missing/broken until you find the root cause. For instance, a cross build of netkit-tftp fails in dh_strip even though the cause is in the ./configure invocation. That is another reason for not allowing the delaying of failure. The policy not just prohibits silent misbuilds, it goes further and disallows the pattern than can make them happen. Helmut
Bug#875885: netkit-tftp: does not trap ./configure errors
On Fri, Sep 15, 2017 at 05:17:44PM +0200, Helmut Grohne wrote: > Source: netkit-tftp > Version: 0.17-18.1 > Severity: serious > Justification: policy 4.6 > > netkit-tftp's debian/rules does not trap errors from ./configure. In > case ./configure fails, the build continues. This can produces > apparently successful misbuilds and is prohibited by the Debian policy > in section 4.6. > > Helmut Hello, Helmut. Have you tested your assertion? Because if ./configure fails, MCONFIG is not created and the build (make) fails: make[1]: Entering directory '/home/agi/debian/netkit-tftp/netkit-tftp/tftp' Makefile:3: ../MCONFIG: No such file or directory make[1]: *** No rule to make target '../MCONFIG'. Stop. make[1]: Leaving directory '/home/agi/debian/netkit-tftp/netkit-tftp/tftp' make: *** [Makefile:7: tftp.build] Error 2 Could you let me know how to reproduce a misbuild? Regards, Alberto -- Alberto Gonzalez Iniesta| Formación, consultoría y soporte técnico mailto/sip: a...@inittab.org | en GNU/Linux y software libre Encrypted mail preferred| http://inittab.com Key fingerprint = 5347 CBD8 3E30 A9EB 4D7D 4BF2 009B 3375 6B9A AA55
Bug#875885: netkit-tftp: does not trap ./configure errors
Hello, Raphael. Dead upstream requires few updates to a package. Anyway, I was just looking into that now. Regards, Alberto On Tue, Jul 03, 2018 at 09:44:46AM +0200, Raphael Hertzog wrote: > Hello Alberto, > > it's been 8 years that you haven't touched netkit-tftp and the package > has been removed from Debian testing due to the bug I'm replying to. > > Can you take care of fixing the bug and/or properly orphaning the package > if you are no longer interested in it? > > Regards, > > On Fri, 15 Sep 2017, Helmut Grohne wrote: > > Source: netkit-tftp > > Version: 0.17-18.1 > > Severity: serious > > Justification: policy 4.6 > > > > netkit-tftp's debian/rules does not trap errors from ./configure. In > > case ./configure fails, the build continues. This can produces > > apparently successful misbuilds and is prohibited by the Debian policy > > in section 4.6. > > > > Helmut > -- Alberto Gonzalez Iniesta| Formación, consultoría y soporte técnico mailto/sip: a...@inittab.org | en GNU/Linux y software libre Encrypted mail preferred| http://inittab.com Key fingerprint = 5347 CBD8 3E30 A9EB 4D7D 4BF2 009B 3375 6B9A AA55
Bug#875885: netkit-tftp: does not trap ./configure errors
Hello Alberto, it's been 8 years that you haven't touched netkit-tftp and the package has been removed from Debian testing due to the bug I'm replying to. Can you take care of fixing the bug and/or properly orphaning the package if you are no longer interested in it? Regards, On Fri, 15 Sep 2017, Helmut Grohne wrote: > Source: netkit-tftp > Version: 0.17-18.1 > Severity: serious > Justification: policy 4.6 > > netkit-tftp's debian/rules does not trap errors from ./configure. In > case ./configure fails, the build continues. This can produces > apparently successful misbuilds and is prohibited by the Debian policy > in section 4.6. > > Helmut -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Bug#875885: netkit-tftp: does not trap ./configure errors
Source: netkit-tftp Version: 0.17-18.1 Severity: serious Justification: policy 4.6 netkit-tftp's debian/rules does not trap errors from ./configure. In case ./configure fails, the build continues. This can produces apparently successful misbuilds and is prohibited by the Debian policy in section 4.6. Helmut
