Bug#886275: gourmet: Don't depend on python-poppler

[Christian Marillat]

On 03 janv. 2018 12:55, Jeremy Bicha  wrote:

> Source: gourmet
> Version: 0.17.4-4
> Severity: serious
> Tags: patch pending
> X-Debbugs-CC: steve.langa...@ubuntu.com
>
> I am uploading an NMU to the DELAYED/10 queue to drop the
> python-poppler dependency and not install gourmet's printing plugin
> since that seems more reasonable than dropping gourmet completely at
> this point. (This was originally done by Steve Langasek in Ubuntu.)

gourmet is almost killed by Debian as gourmet has been not ported to
python 3.

In #849087 : Port to Python 3 and python3-gst-1.0
In #886276 : gourmet: Depends on unmaintained pygtk

Christian

Bug#886275: gourmet: Don't depend on python-poppler

[Jeremy Bicha]

From 1cf2c5fbd5520fdf16c2d9aab401329fc00ba930 Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Wed, 3 Jan 2018 12:49:20 -0500
Subject: [PATCH] Don't depend on python-poppler

since it's being removed from Debian and
don't install the printing plugin. Thanks Steve Langasek.

Closes: #886275
---
 debian/changelog | 8 
 debian/control   | 2 +-
 debian/rules | 2 ++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index f0ca49c..a84b7b4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+gourmet (0.17.4-4.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Don't depend on python-poppler (since it's being removed from Debian) and
+don't install the printing plugin. Thanks Steve Langasek. (Closes: #886275)
+
+ -- Jeremy Bicha   Wed, 03 Jan 2018 12:48:28 -0500
+
 gourmet (0.17.4-4) unstable; urgency=medium
 
   * Remove python-imaging dependency (Closes: #866427)
diff --git a/debian/control b/debian/control
index 1c84c57..d2d7ff2 100644
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@ Build-Depends-Indep: intltool, python-distutils-extra
 
 Package: gourmet
 Architecture: all
-Depends: ${misc:Depends}, ${python:Depends}, python-gtk2 (>= 2.22.0), python-reportlab, python-sqlalchemy, python-poppler, python-elib.intl, python-pil (>= 3.0.0~)
+Depends: ${misc:Depends}, ${python:Depends}, python-gtk2 (>= 2.22.0), python-reportlab, python-sqlalchemy, python-elib.intl, python-pil (>= 3.0.0~)
 Recommends: python-gst-1.0, python-gtkspell, python-beautifulsoup, python-lxml
 Description: Recipe organizer and shopping list generator
  Gourmet Recipe Manager is a gtk-based application to store, organize and
diff --git a/debian/rules b/debian/rules
index 0bc7a15..b6c05bf 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,6 +10,8 @@ override_dh_install:
 	dh_install --fail-missing
 
 	rm debian/gourmet/usr/share/doc/gourmet/LICENSE
+	# python-poppler has been removed from Debian
+	rm debian/gourmet/usr/lib/python2.*/dist-packages/gourmet/plugins/import_export/pdf_plugin/print_plugin.py
 
 override_dh_clean:
 	dh_clean po/gourmet.pot
-- 
2.14.1

Bug#886275: gourmet: Don't depend on python-poppler

[Jeremy Bicha]

Source: gourmet
Version: 0.17.4-4
Severity: serious
Tags: patch pending
X-Debbugs-CC: steve.langa...@ubuntu.com

I am uploading an NMU to the DELAYED/10 queue to drop the
python-poppler dependency and not install gourmet's printing plugin
since that seems more reasonable than dropping gourmet completely at
this point. (This was originally done by Steve Langasek in Ubuntu.)
Please let me know if I should speed up or slow down the upload.

Once the upload is accepted into Debian, we can lower the severity of
https://bugs.debian.org/879035 to important.

Note that the Debian GNOME would like to remove pygtk from Debian
soon, but I'll file a separate bug for that.

I'm attaching the debdiff in my follow-up email here.

Thanks,
Jeremy Bicha